From: John Garry <john.garry@huawei.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-fbdev@vger.kernel.org, linux-pci@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Ettore Chimenti <ek5.chimenti@gmail.com>,
linux-ide@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
Guo Ren <guoren@kernel.org>,
linux-i2c@vger.kernel.org, linux-riscv@lists.infradead.org,
Vincent Chen <deanbo422@gmail.com>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Hannes Reinecke <hare@suse.com>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
linux-scsi@vger.kernel.org,
Sumit Saxena <sumit.saxena@broadcom.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
linux-csky@vger.kernel.org,
Kashyap Desai <kashyap.desai@broadcom.com>,
Nilesh Javali <njavali@marvell.com>,
intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org,
GR-QLogic-Storage-Upstream@marvell.com,
Jakub Kicinski <kuba@kernel.org>,
MPT-FusionLinux.pdl@broadcom.com,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-media@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Jean Delvare <jdelvare@suse.com>,
linux-watchdog@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Niklas Schnelle <schnelle@linux.ibm.com>, Jouni Malinen <j@w1.fi>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Kalle Valo <kvalo@kernel.org>,
linux-input@vger.kernel.org, linux-spi@vger.kernel.org,
linux-gpio@vger.kernel.org, Ian Abbott <abbotti@mev.co.uk>,
Mark Brown <broonie@kernel.org>,
Greentime Hu <green.hu@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
megaraidlinux.pdl@broadcom.com,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-hwmon@vger.kernel.org, Arnd Bergmann <arnd@kernel.org>,
Karsten Keil <isdn@linux-pingi.de>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Nick Hu <nickhu@andestech.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dri-devel@lists.freedesktop.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-wireless@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
"David S. Miller" <davem@davemloft.net>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Forest Bond <forest@alittletooquiet.net>,
netdev@vger.kernel.org, Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI
Date: Fri, 7 Jan 2022 17:16:23 +0000 [thread overview]
Message-ID: <b0e772ed-4c21-3d5a-d890-aba05c41904c@huawei.com> (raw)
In-Reply-To: <20220106181409.GA297735@bhelgaas>
On 06/01/2022 18:14, Bjorn Helgaas wrote:
>> That driver would prob not be used on systems which does not support PIO,
>> and so could have a HAS_IOPORT dependency. But it is not strictly necessary.
> I don't want the path of "this driver isn't needed because the device
> is unlikely to be used on this arch."
Sure, that was just a one off example. As I mentioned before, I think
that Arnd already did most of the ifdeffery work, but it was not
included in this series.
>
> Maybe it's not_always_ possible, but if the device can be plugged
> into the platform, I think we should be able to build the driver for
> it.
>
> If the device requires I/O port space and the platform doesn't support
> it, the PCI core or the driver should detect that and give a useful
> diagnostic.
>
I'm not sure what the driver can say apart from -ENODEV. Or IO port
management in resource.c could warn for requesting IO port region when
it's unsupported.
Anyway, this same conversion was had with Linus before I got involved.
If you think it is worth discussing again then I suppose the authors
here need to gain consensus.
Thanks,
John
next prev parent reply other threads:[~2022-01-08 14:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211227164317.4146918-1-schnelle@linux.ibm.com>
2021-12-27 16:42 ` [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI Niklas Schnelle
2021-12-27 17:48 ` Guenter Roeck
2021-12-28 2:09 ` Mauro Carvalho Chehab
2021-12-28 8:21 ` Greg Kroah-Hartman
2021-12-28 9:15 ` Mauro Carvalho Chehab
2021-12-28 10:58 ` Niklas Schnelle
2021-12-28 12:01 ` Greg Kroah-Hartman
2021-12-28 12:54 ` Mauro Carvalho Chehab
2021-12-28 15:06 ` Niklas Schnelle
2021-12-28 17:12 ` Mauro Carvalho Chehab
2021-12-29 11:45 ` Niklas Schnelle
2021-12-29 12:12 ` Mauro Carvalho Chehab
2021-12-29 16:03 ` Bjorn Helgaas
2021-12-29 16:55 ` Niklas Schnelle
2022-01-05 17:42 ` John Garry
2022-01-05 19:47 ` Bjorn Helgaas
[not found] ` <74bf4fde-3972-1c36-ca04-58089da0d82b@huawei.com>
2022-01-06 18:14 ` Bjorn Helgaas
2022-01-07 17:16 ` John Garry [this message]
2022-01-10 9:34 ` Niklas Schnelle
2021-12-27 16:43 ` [RFC 22/32] video: handle HAS_IOPORT dependencies Niklas Schnelle
2021-12-27 16:43 ` [RFC 26/32] drm: " Niklas Schnelle
2022-01-03 6:11 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0e772ed-4c21-3d5a-d890-aba05c41904c@huawei.com \
--to=john.garry@huawei.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=abbotti@mev.co.uk \
--cc=anthony.l.nguyen@intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=davem@davemloft.net \
--cc=deanbo422@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ek5.chimenti@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=green.hu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=guoren@kernel.org \
--cc=hare@suse.com \
--cc=helgaas@kernel.org \
--cc=hsweeten@visionengravers.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=isdn@linux-pingi.de \
--cc=j@w1.fi \
--cc=jdelvare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=jesse.brandeburg@intel.com \
--cc=jirislaby@kernel.org \
--cc=kashyap.desai@broadcom.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m.grzeschik@pengutronix.de \
--cc=martin.petersen@oracle.com \
--cc=mchehab@kernel.org \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nickhu@andestech.com \
--cc=njavali@marvell.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=perex@perex.cz \
--cc=sathya.prakash@broadcom.com \
--cc=schnelle@linux.ibm.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=teddy.wang@siliconmotion.com \
--cc=tiwai@suse.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).