From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87D95C433F5 for ; Thu, 24 Feb 2022 20:39:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 930FC10E6AC; Thu, 24 Feb 2022 20:39:09 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDB4010E6AB; Thu, 24 Feb 2022 20:39:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645735147; x=1677271147; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Y7jHjX9MeTWbmPnQb38nq6YUV/k+5S99uIoIq/DHVWM=; b=Ayl1L1Hm8NMulyX3nuGQEbhByyeR+/8OtVLsmpVe+pNWHFb1E/iKw+tX eF5IYLmrhAiiAfEl5NCCXv1yuUPIXMEw7ksmFbtjspZXlJD53GYRjFaJ/ bdRx47EkRbRsKhZj6VzYof41i+J/FUgcfWA9rnnt20fcKG3GxvWsnCKTU 3utJZfXJR/OyTzqGMWLQx490DG0wXoJDyeidtBko4kML+47hNtyXaHtJ+ rnBfNuLZXmGmSR9qcVXoIZV6WyVF+r1+5d6gQez5tKhRNMJyrJlhKr/RX 9J4LVBIbeK1x/LaIp28+nRuRoBK6j2VeVCQIs5VFFIbXLaTHJjC53yrAa w==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="252264043" X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="252264043" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 12:39:07 -0800 X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="533288969" Received: from shravank-mobl1.gar.corp.intel.com (HELO [10.252.46.141]) ([10.252.46.141]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 12:39:06 -0800 Message-ID: Date: Thu, 24 Feb 2022 21:39:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.6.0 Subject: Re: [PATCH 0/3] drm/helpers: Make the suballocation manager drm generic. Content-Language: en-US To: =?UTF-8?Q?Christian_K=c3=b6nig?= , dri-devel@lists.freedesktop.org References: <20220223135112.655569-1-maarten.lankhorst@linux.intel.com> <868b0d69-0620-95a6-ed47-7f89288afdc5@amd.com> From: Maarten Lankhorst In-Reply-To: <868b0d69-0620-95a6-ed47-7f89288afdc5@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Deucher , intel-gfx@lists.freedesktop.org, Xinhui Pan Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Op 23-02-2022 om 16:11 schreef Christian König: > Am 23.02.22 um 14:51 schrieb Maarten Lankhorst: >> Second version of the patch. I didn't fix the copyright (which ame up >> in the previous version), as I feel the original author should send a >> patch for that. >> >> I've made the suballocator into its own module, and did a cleanup pass on it. >> The suballocator is generic enough to be useful for any resource that can be >> subdivided and is guarded by a completion fence. > > Well the main issue is still that you removed the per allocation alignment. > > For amdgpu that is not much of a problem, but for radeon that could cause massive issues with UVD semaphore synchronization. Hey, Is this really a problem? I made the per allocation alignment fixed and set it to the higher of the 2 places it's used in by radeon. This just means that slightly more memory might be allocated to each suballocation. This shouldn't cause any problem. It would reserve 256 bytes for a semaphore allocation, instead of 8. ~Maarten