dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: "Michel Dänzer" <michel.daenzer@mailbox.org>, xaver.hugl@gmail.com
Cc: pierre-eric.pelloux-prayer@amd.com,
	"Pekka Paalanen" <pekka.paalanen@collabora.com>,
	kernel-dev@igalia.com, "'Marek Olšák'" <maraeo@gmail.com>,
	dri-devel@lists.freedesktop.org,
	"Randy Dunlap" <rdunlap@infradead.org>,
	linux-kernel@vger.kernel.org,
	wayland-devel@lists.freedesktop.org,
	"Pekka Paalanen" <ppaalanen@gmail.com>,
	amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
	joshua@froggi.es, hwentlan@amd.com, christian.koenig@amd.com
Subject: Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set
Date: Mon, 16 Oct 2023 12:52:32 +0200	[thread overview]
Message-ID: <b48bd1fc-fcb0-481b-8413-9210d44d709b@igalia.com> (raw)
In-Reply-To: <1b23576d-1649-ff5c-6273-b54729ea46d8@mailbox.org>

Hi Michel,

On 8/17/23 12:37, Michel Dänzer wrote:
> On 8/15/23 20:57, André Almeida wrote:
>> From: Pekka Paalanen <pekka.paalanen@collabora.com>
>>
>> Specify how the atomic state is maintained between userspace and
>> kernel, plus the special case for async flips.
>>
>> Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
>> Signed-off-by: André Almeida <andrealmeid@igalia.com>
> [...]
>
>> +An atomic commit with the flag DRM_MODE_PAGE_FLIP_ASYNC is allowed to
>> +effectively change only the FB_ID property on any planes. No-operation changes
>> +are ignored as always. [...]
> During the hackfest in Brno, it was mentioned that a commit which re-sets the same FB_ID could actually have an effect with VRR: It could trigger scanout of the next frame before vertical blank has reached its maximum duration. Some kind of mechanism is required for this in order to allow user space to perform low frame rate compensation.
>
Xaver tested this hypothesis in a flipping the same fb in a VRR monitor 
and it worked as expected, so this shouldn't be a concern.

Thanks,
     André



  parent reply	other threads:[~2023-10-16 10:53 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 18:57 [PATCH v6 0/6] drm: Add support for atomic async page-flip André Almeida
2023-08-15 18:57 ` [PATCH v6 1/6] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits André Almeida
2023-08-15 18:57 ` [PATCH v6 2/6] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP André Almeida
2023-08-15 18:57 ` [PATCH v6 3/6] drm: introduce drm_mode_config.atomic_async_page_flip_not_supported André Almeida
2023-08-15 18:57 ` [PATCH v6 4/6] amd/display: indicate support for atomic async page-flips on DC André Almeida
2023-08-15 18:57 ` [PATCH v6 5/6] drm: Refuse to async flip with atomic prop changes André Almeida
2023-08-22  9:55   ` Sebastian Wick
2023-10-15 15:37   ` Simon Ser
2023-08-15 18:57 ` [PATCH v6 6/6] drm/doc: Define KMS atomic state set André Almeida
2023-08-17 10:37   ` Michel Dänzer
2023-08-17 10:48     ` Michel Dänzer
2023-08-21 20:02     ` André Almeida
2023-08-22 10:03       ` Michel Dänzer
2023-10-16 10:52     ` André Almeida [this message]
2023-10-16 12:18       ` Pekka Paalanen
2023-10-16 13:42         ` André Almeida
2023-10-16 14:52           ` Pekka Paalanen
2023-10-16 15:01             ` André Almeida
2023-10-16 15:10             ` Ville Syrjälä
2023-10-16 22:00               ` Simon Ser
2023-10-17 12:10                 ` Ville Syrjälä
2023-10-23  8:25                   ` Simon Ser
2023-11-13  9:18                     ` Simon Ser
2023-11-13  9:38                       ` Pekka Paalanen
2023-11-13  9:44                         ` Simon Ser
2023-11-13 10:15                           ` Pekka Paalanen
2023-11-13 10:18                             ` Simon Ser
2023-11-13  9:41                       ` Michel Dänzer
2023-11-13  9:47                         ` Simon Ser
2023-11-13  9:53                           ` Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b48bd1fc-fcb0-481b-8413-9210d44d709b@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hwentlan@amd.com \
    --cc=joshua@froggi.es \
    --cc=kernel-dev@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maraeo@gmail.com \
    --cc=michel.daenzer@mailbox.org \
    --cc=pekka.paalanen@collabora.com \
    --cc=pierre-eric.pelloux-prayer@amd.com \
    --cc=ppaalanen@gmail.com \
    --cc=rdunlap@infradead.org \
    --cc=wayland-devel@lists.freedesktop.org \
    --cc=xaver.hugl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).