From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC736C433DF for ; Thu, 18 Jun 2020 07:18:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9ED0721532 for ; Thu, 18 Jun 2020 07:18:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9ED0721532 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4755E6EAC0; Thu, 18 Jun 2020 07:17:33 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 758C36E546 for ; Wed, 17 Jun 2020 09:17:39 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C70BF31B; Wed, 17 Jun 2020 02:17:37 -0700 (PDT) Received: from [10.37.12.67] (unknown [10.37.12.67]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CFD4A3F6CF; Wed, 17 Jun 2020 02:17:27 -0700 (PDT) Subject: Re: [PATCH v8 0/8] Add support for devices in the Energy Model To: "Rafael J. Wysocki" References: <20200527095854.21714-1-lukasz.luba@arm.com> <8fca24a1-93f7-f859-bd1f-b7bf484737f4@arm.com> From: Lukasz Luba Message-ID: Date: Wed, 17 Jun 2020 10:17:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mailman-Approved-At: Thu, 18 Jun 2020 07:17:31 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Juri Lelli , Peter Zijlstra , Viresh Kumar , Liviu Dudau , dri-devel , Bjorn Andersson , Benjamin Segall , alyssa.rosenzweig@collabora.com, Matthias Kaehlcke , Amit Kucheria , Lorenzo Pieralisi , Vincent Guittot , Kevin Hilman , Andy Gross , Daniel Lezcano , steven.price@arm.com, Chanwoo Choi , Ingo Molnar , dl-linux-imx , "Zhang, Rui" , Mel Gorman , orjan.eide@arm.com, Linux PM , linux-arm-msm , Sascha Hauer , Steven Rostedt , "moderated list:ARM/Mediatek SoC..." , Matthias Brugger , Linux OMAP Mailing List , Dietmar Eggemann , Linux ARM , David Airlie , Tomeu Vizoso , Quentin Perret , Stephen Boyd , Randy Dunlap , "Rafael J. Wysocki" , Linux Kernel Mailing List , Bartlomiej Zolnierkiewicz , Sascha Hauer , Sudeep Holla , patrick.bellasi@matbug.net, Shawn Guo Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Rafael, On 5/29/20 5:18 PM, Rafael J. Wysocki wrote: > On Fri, May 29, 2020 at 5:01 PM Lukasz Luba wrote: >> >> Hi Rafael, >> >> >> On 5/27/20 10:58 AM, Lukasz Luba wrote: >>> Hi all, >>> >>> Background of this version: >>> This is the v8 of the patch set and is has smaller scope. I had to split >>> the series into two: EM changes and thermal changes due to devfreq >>> dependencies. The patches from v7 9-14 which change devfreq cooling are >>> going to be sent in separate patch series, just after this set get merged >>> into mainline. These patches related to EM got acks and hopefully can go >>> through linux-pm tree. The later thermal patches will go through thermal >>> tree. >>> >>> The idea and purpose of the Energy Model framework changes: >>> This patch set introduces support for devices in the Energy Model (EM) >>> framework. It will unify the power model for thermal subsystem. It will >>> make simpler to add support for new devices willing to use more >>> advanced features (like Intelligent Power Allocation). Now it should >>> require less knowledge and effort for driver developer to add e.g. >>> GPU driver with simple energy model. A more sophisticated energy model >>> in the thermal framework is also possible, driver needs to provide >>> a dedicated callback function. More information can be found in the >>> updated documentation file. >>> >>> First 7 patches are refactoring Energy Model framework to add support >>> of other devices that CPUs. They change: >>> - naming convention from 'capacity' to 'performance' state, >>> - API arguments adding device pointer and not rely only on cpumask, >>> - change naming when 'cpu' was used, now it's a 'device' >>> - internal structure to maintain registered devices >>> - update users to the new API >>> Patch 8 updates OPP framework helper function to be more generic, not >>> CPU specific. >>> >>> The patch set is based on linux-pm branch linux-next 813946019dfd. >>> >> >> Could you take the patch set via your linux-pm? > > I can do that, but I didn't realize that it was targeted at me, so I > need some more time to review the patches. > > Thanks! > Gentle ping. I've resend the patch 4/8 [1] which addresses your comments and a comment regarding static analyzes conducted by Dan [2]. Do you need more time for this patch set? Maybe you would like me to help you with rebasing this series? Then please point me to the desired branch, I am happy to do this. Regards, Lukasz [1] https://lore.kernel.org/lkml/20200610101223.7152-1-lukasz.luba@arm.com/ [2] https://lore.kernel.org/lkml/da0debe1-73da-33f1-c24e-154c2123c522@arm.com/ _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel