Re: [RFC PATCH v2 3/3] drm: initialize accel framework

From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Oded Gabbay <ogabbay@kernel.org>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	Jason Gunthorpe <jgg@nvidia.com>,
	John Hubbard <jhubbard@nvidia.com>,
	Alex Deucher <alexander.deucher@amd.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
	Jiho Chu <jiho.chu@samsung.com>,
	Christoph Hellwig <hch@infradead.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Kevin Hilman <khilman@baylibre.com>,
	Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>,
	Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: Re: [RFC PATCH v2 3/3] drm: initialize accel framework
Date: Wed, 2 Nov 2022 15:30:27 -0600	[thread overview]
Message-ID: <b6faacac-46f2-7643-7796-b34840fc94f5@quicinc.com> (raw)
In-Reply-To: <20221102203405.1797491-4-ogabbay@kernel.org>

On 11/2/2022 2:34 PM, Oded Gabbay wrote:
> @@ -163,7 +174,11 @@ static int drm_minor_register(struct drm_device *dev, unsigned int type)
>   
>   	ret = drm_debugfs_init(minor, minor->index, drm_debugfs_root);
>   	if (ret) {
> -		DRM_ERROR("DRM: Failed to initialize /sys/kernel/debug/dri.\n");
> +		if (minor->type == DRM_MINOR_ACCEL)
> +			DRM_ERROR("DRM: Failed to initialize /sys/kernel/debug/accel.\n");
> +		else
> +			DRM_ERROR("DRM: Failed to initialize /sys/kernel/debug/dri.\n");
> +
>   		goto err_debugfs;
>   	}
>   

This doesn't look right.  Don't you need to call drm_debugfs_init() with 
accel_debugfs_root for the case - minor->type == DRM_MINOR_ACCEL? 
Unless I fail to understand something, this will put all the accel 
devices under /sys/kernel/debug/dri