From: "Noralf Trønnes" <noralf@tronnes.org>
To: Maxime Ripard <maxime@cerno.tech>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Ben Skeggs <bskeggs@redhat.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Maxime Ripard <mripard@kernel.org>,
Samuel Holland <samuel@sholland.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Emma Anholt <emma@anholt.net>, Karol Herbst <kherbst@redhat.com>,
Daniel Vetter <daniel@ffwll.ch>, Chen-Yu Tsai <wens@csie.org>,
Lyude Paul <lyude@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>
Cc: "Dom Cobley" <dom@raspberrypi.com>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-sunxi@lists.linux.dev,
"Hans de Goede" <hdegoede@redhat.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Mateusz Kwiatkowski" <kfyatek+publicgit@gmail.com>,
"Phil Elwell" <phil@raspberrypi.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 15/23] drm/modes: Introduce more named modes
Date: Tue, 8 Nov 2022 10:38:12 +0100 [thread overview]
Message-ID: <ba532387-6329-c57a-1fa2-627b2cf40281@tronnes.org> (raw)
In-Reply-To: <262f0953-1e05-e68e-3e96-2ac2132a1e57@tronnes.org>
Den 07.11.2022 19.03, skrev Noralf Trønnes:
>
>
> Den 07.11.2022 15.16, skrev Maxime Ripard:
>> Now that we can easily extend the named modes list, let's add a few more
>> analog TV modes that were used in the wild, and some unit tests to make
>> sure it works as intended.
>>
>> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>>
>> ---
>> Changes in v6:
>> - Renamed the tests to follow DRM test naming convention
>>
>> Changes in v5:
>> - Switched to KUNIT_ASSERT_NOT_NULL
>> ---
>> drivers/gpu/drm/drm_modes.c | 2 +
>> drivers/gpu/drm/tests/drm_client_modeset_test.c | 54 +++++++++++++++++++++++++
>> 2 files changed, 56 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
>> index 49441cabdd9d..17c5b6108103 100644
>> --- a/drivers/gpu/drm/drm_modes.c
>> +++ b/drivers/gpu/drm/drm_modes.c
>> @@ -2272,7 +2272,9 @@ struct drm_named_mode {
>>
>> static const struct drm_named_mode drm_named_modes[] = {
>> NAMED_MODE("NTSC", 13500, 720, 480, DRM_MODE_FLAG_INTERLACE, DRM_MODE_TV_MODE_NTSC),
>> + NAMED_MODE("NTSC-J", 13500, 720, 480, DRM_MODE_FLAG_INTERLACE, DRM_MODE_TV_MODE_NTSC_J),
>> NAMED_MODE("PAL", 13500, 720, 576, DRM_MODE_FLAG_INTERLACE, DRM_MODE_TV_MODE_PAL),
>> + NAMED_MODE("PAL-M", 13500, 720, 480, DRM_MODE_FLAG_INTERLACE, DRM_MODE_TV_MODE_PAL_M),
>> };
>
> I'm now having second thoughts about the tv_mode commandline option. Can
> we just add all the variants to this table and drop the tv_mode option?
> IMO this will be more user friendly and less confusing.
>
One downside of this is that it's not possible to force connector status
when using named modes, but I think it would be better to have a force
option than a tv_mode option. A lot of userspace treats unknown status
as disconnected.
Anyone know if it's possible to set the connector status sysfs file
using a udev rule?
Noralf.
next prev parent reply other threads:[~2022-11-08 9:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 14:16 [PATCH v7 00/23] drm: Analog TV Improvements Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 01/23] drm/tests: Add Kunit Helpers Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 02/23] drm/connector: Rename legacy TV property Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 03/23] drm/connector: Only register TV mode property if present Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 04/23] drm/connector: Rename drm_mode_create_tv_properties Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 05/23] drm/connector: Add TV standard property Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 06/23] drm/modes: Add a function to generate analog display modes Maxime Ripard
2022-11-08 13:28 ` [Nouveau] " Lukas Satin
2022-11-08 21:51 ` Mateusz Kwiatkowski
2022-11-07 14:16 ` [PATCH v7 07/23] drm/client: Add some tests for drm_connector_pick_cmdline_mode() Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 08/23] drm/modes: Move named modes parsing to a separate function Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 09/23] drm/modes: Switch to named mode descriptors Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 10/23] drm/modes: Fill drm_cmdline mode from named modes Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 11/23] drm/connector: Add pixel clock to cmdline mode Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 12/23] drm/connector: Add a function to lookup a TV mode by its name Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 13/23] drm/modes: Introduce the tv_mode property as a command-line option Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 14/23] drm/modes: Properly generate a drm_display_mode from a named mode Maxime Ripard
2022-11-07 17:49 ` Noralf Trønnes
2022-11-08 9:40 ` Noralf Trønnes
2022-11-10 10:36 ` Maxime Ripard
2022-11-10 9:31 ` Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 15/23] drm/modes: Introduce more named modes Maxime Ripard
2022-11-07 18:03 ` Noralf Trønnes
2022-11-08 9:38 ` Noralf Trønnes [this message]
2022-11-08 21:27 ` Mateusz Kwiatkowski
2022-11-09 11:18 ` Maxime Ripard
2022-11-09 14:09 ` Noralf Trønnes
2022-11-07 14:16 ` [PATCH v7 16/23] drm/probe-helper: Provide a TV get_modes helper Maxime Ripard
2022-11-07 18:11 ` Noralf Trønnes
2022-11-09 15:41 ` Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 17/23] drm/atomic-helper: Add a TV properties reset helper Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 18/23] drm/atomic-helper: Add an analog TV atomic_check implementation Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 19/23] drm/vc4: vec: Use TV Reset implementation Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 20/23] drm/vc4: vec: Check for VEC output constraints Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 21/23] drm/vc4: vec: Convert to the new TV mode property Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 22/23] drm/vc4: vec: Add support for more analog TV standards Maxime Ripard
2022-11-08 13:17 ` [Nouveau] " Lukas Satin
2022-11-08 22:16 ` Mateusz Kwiatkowski
2022-11-09 1:15 ` Mateusz Kwiatkowski
2022-11-09 16:55 ` [Nouveau] " Lukas Satin
2022-11-10 10:39 ` Maxime Ripard
2022-11-10 10:57 ` Maxime Ripard
2022-11-07 14:16 ` [PATCH v7 23/23] drm/sun4i: tv: Convert to the new TV mode property Maxime Ripard
2022-11-08 13:20 ` [Nouveau] [PATCH v7 00/23] drm: Analog TV Improvements Lukas Satin
2022-11-08 13:42 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba532387-6329-c57a-1fa2-627b2cf40281@tronnes.org \
--to=noralf@tronnes.org \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dave.stevenson@raspberrypi.com \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=geert@linux-m68k.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jernej.skrabec@gmail.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kfyatek+publicgit@gmail.com \
--cc=kherbst@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=phil@raspberrypi.com \
--cc=rodrigo.vivi@intel.com \
--cc=samuel@sholland.org \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).