From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF92CC433B4 for ; Fri, 23 Apr 2021 15:54:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F11F601FD for ; Fri, 23 Apr 2021 15:54:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F11F601FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A8576E123; Fri, 23 Apr 2021 15:54:31 +0000 (UTC) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D9336E123 for ; Fri, 23 Apr 2021 15:54:30 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id x7so48833656wrw.10 for ; Fri, 23 Apr 2021 08:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nu1AQU+twsRz9Nxjz3ymYspXF0v3XdvGCJQ0v8RcVRo=; b=zzs2nDvmtgNn4vNGiTRoEFSmyZbqBJbAtiMphuEg6JWh/Bdg0bCBMnbuTxtZIEd3Xn Vwy3vTifWKZRRsrrS4WnmDTh/mYnBU4MS3yAl5j0+xIaRVdek32fO8fcQydcayFD/2W+ bZAW/jScVBCqnth5PSQeqLv0jzajFH4T3e9Wi5JAqCNqTkEZ26iFQGw+jcDHXM9DPISb omjCxL9i4OxGp1qYfGRdZoqYFQcVXeGf/GeLGsaVmApLiEpXrnq2zLaXXRZrWeBgkXiH 8wFslsPahoseJoFrAaYzi+5ZFvo6d1B5iAFq5Bb06LU+c3XDDisDnJWdO4xnlZGFaCmE zRPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nu1AQU+twsRz9Nxjz3ymYspXF0v3XdvGCJQ0v8RcVRo=; b=osIz9Z7yzJtRHIJbI9tkcqMNnrQ7prT4HYmdOhX4dBlEDQ5qyN1EKEpKb1/b5S5cPO IOBISFqKcMwktBzi1+7TSCIY1cDd7KUGcGtr4KE88wiTAq3zThNk7uC69dH63zv4J+nu df8xr9GpMj1+ESpoIf6V6m/vj4aH2P3niNp1dn+PbYH/AkabAJg02GI7iN47wzO9NJuV pRheepXelZkiS1DKCTCBzH1F4OGRY8wtC1T7+VoBykhcgctrUk/dB9quBebfIWi2y+gz cL958ECTNNx50/9u1+xgYi5lGpkUVBvQUa7NN+fpvBfzZzm4fN2DXK2ihfujBdXxu3Iq PBUQ== X-Gm-Message-State: AOAM531lXsyrkFet9IVj/43DkHtfbzq9Q3hAtN3td4uhMAvE3PgqbCgi zVOoeS1Zkw15hLqsCZhyzLdBzMqDiH1QlZnN X-Google-Smtp-Source: ABdhPJwLByVzjeQfrGQm37MTSxSmM8jUI0bZu5jLgqs98P2DdRBHTGNZGkVrk74Y3o5VcWcVKxExdA== X-Received: by 2002:adf:fd90:: with SMTP id d16mr5478562wrr.96.1619193269230; Fri, 23 Apr 2021 08:54:29 -0700 (PDT) Received: from ?IPv6:2a01:e0a:82c:5f0:cdf4:4f8:cdd5:cc88? ([2a01:e0a:82c:5f0:cdf4:4f8:cdd5:cc88]) by smtp.gmail.com with ESMTPSA id c16sm9281685wrt.83.2021.04.23.08.54.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Apr 2021 08:54:28 -0700 (PDT) Subject: Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver To: Marek Vasut , dri-devel@lists.freedesktop.org References: <20210421223122.112736-2-marex@denx.de> From: Loic Poulain Message-ID: Date: Fri, 23 Apr 2021 18:03:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210421223122.112736-2-marex@denx.de> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dianders@chromium.org, swboyd@chromium.org, philippe.schenker@toradex.com, laurent.pinchart@ideasonboard.com, valentin@compulab.co.il, sam@ravnborg.org, jagan@amarulasolutions.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 22/04/2021 00:31, Marek Vasut wrote: > Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge > and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS > bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on, > but easy to add. > > The driver operates the chip via I2C bus. Currently the LVDS clock are > always derived from DSI clock lane, which is the usual mode of operation. > Support for clock from external oscillator is not implemented, but it is > easy to add if ever needed. Only RGB888 pixel format is implemented, the > LVDS666 is not supported, but could be added if needed. > > Signed-off-by: Marek Vasut > Cc: Douglas Anderson > Cc: Jagan Teki > Cc: Laurent Pinchart > Cc: Linus Walleij > Cc: Philippe Schenker > Cc: Sam Ravnborg > Cc: Stephen Boyd > Cc: Valentin Raevsky > To: dri-devel@lists.freedesktop.org > --- > V2: - Use dev_err_probe() > - Set REG_RC_RESET as volatile > - Wait for PLL stabilization by polling REG_RC_LVDS_PLL > - Use ctx->mode = *adj instead of *mode in sn65dsi83_mode_set > - Add tested DSI84 support in dual-link mode > - Correctly set VCOM > - Fill in missing DSI CHB and LVDS CHB bits from DSI84 and DSI85 > datasheets, with that all the reserved bits make far more sense > as the DSI83 and DSI84 seems to be reduced version of DSI85 > --- > drivers/gpu/drm/bridge/Kconfig | 10 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 617 ++++++++++++++++++++++++++ > 3 files changed, 628 insertions(+) > create mode 100644 drivers/gpu/drm/bridge/ti-sn65dsi83.c Tested on MSC-SM2S-IMX8MINI module with a 1024x768 (VESA-24) single LVDS channel panel. Tested-by: Loic Poulain Loic _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel