From: Lucas Stach <l.stach@pengutronix.de>
To: John Hubbard <jhubbard@nvidia.com>
Cc: David Airlie <airlied@linux.ie>,
etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
LKML <linux-kernel@vger.kernel.org>,
Russell King <linux+etnaviv@armlinux.org.uk>
Subject: Re: [PATCH v2] drm/etnaviv: convert get_user_pages() --> pin_user_pages()
Date: Thu, 18 Jun 2020 17:51:34 +0200 [thread overview]
Message-ID: <be88faf0aa10d1c71dbf2c22e6c72623d4598a0c.camel@pengutronix.de> (raw)
In-Reply-To: <20200525234946.512848-1-jhubbard@nvidia.com>
Am Montag, den 25.05.2020, 16:49 -0700 schrieb John Hubbard:
> This code was using get_user_pages*(), in a "Case 2" scenario
> (DMA/RDMA), using the categorization from [1]. That means that it's
> time to convert the get_user_pages*() + put_page() calls to
> pin_user_pages*() + unpin_user_pages() calls.
>
> There is some helpful background in [2]: basically, this is a small
> part of fixing a long-standing disconnect between pinning pages, and
> file systems' use of those pages.
>
> [1] Documentation/core-api/pin_user_pages.rst
>
> [2] "Explicit pinning of user-space pages":
> https://lwn.net/Articles/807108/
>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Thanks, I've applied this to etnaviv/next.
Regards,
Lucas
> ---
>
> Hi,
>
> Changes since v1:
>
> * Rebased onto Linux 5.7-rc7
>
> * Added: Lucas Stach
>
> thanks
> John Hubbard
> NVIDIA
>
>
> drivers/gpu/drm/etnaviv/etnaviv_gem.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> index dc9ef302f517..0f4578dc169d 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> @@ -675,10 +675,10 @@ static int etnaviv_gem_userptr_get_pages(struct etnaviv_gem_object *etnaviv_obj)
> uint64_t ptr = userptr->ptr + pinned * PAGE_SIZE;
> struct page **pages = pvec + pinned;
>
> - ret = get_user_pages_fast(ptr, num_pages,
> + ret = pin_user_pages_fast(ptr, num_pages,
> !userptr->ro ? FOLL_WRITE : 0, pages);
> if (ret < 0) {
> - release_pages(pvec, pinned);
> + unpin_user_pages(pvec, pinned);
> kvfree(pvec);
> return ret;
> }
> @@ -702,7 +702,7 @@ static void etnaviv_gem_userptr_release(struct etnaviv_gem_object *etnaviv_obj)
> if (etnaviv_obj->pages) {
> int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
>
> - release_pages(etnaviv_obj->pages, npages);
> + unpin_user_pages(etnaviv_obj->pages, npages);
> kvfree(etnaviv_obj->pages);
> }
> }
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-06-18 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 23:49 [PATCH v2] drm/etnaviv: convert get_user_pages() --> pin_user_pages() John Hubbard
2020-06-18 15:51 ` Lucas Stach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be88faf0aa10d1c71dbf2c22e6c72623d4598a0c.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=jhubbard@nvidia.com \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).