From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
devicetree@vger.kernel.org, Jyri Sarha <jsarha@ti.com>,
dri-devel@lists.freedesktop.org,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCH 3/3] drm/panel: simple: fix osd070t1718_19ts sync drive edge
Date: Mon, 13 Jan 2020 14:04:32 +0200 [thread overview]
Message-ID: <beb62b97-f45e-2cbc-6e2b-a05f1ef60e29@ti.com> (raw)
In-Reply-To: <20191202130717.GI4929@pendragon.ideasonboard.com>
Hi Thierry,
On 02/12/2019 15:07, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Thu, Nov 14, 2019 at 11:39:50AM +0200, Tomi Valkeinen wrote:
>> The panel datasheet says that the panel samples at falling edge, but
>> does not say anything about h/v sync signals. Testing shows that if the
>> sync signals are driven on falling edge, the picture on the panel will
>> be slightly shifted right.
>>
>> Setting sync drive edge to the same as data drive edge fixes this issue.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> I don't have access to the documentation, but this makes sense, so
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
>> ---
>> drivers/gpu/drm/panel/panel-simple.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>> index 5d487686d25c..0784536ae6af 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -2397,7 +2397,8 @@ static const struct panel_desc osddisplays_osd070t1718_19ts = {
>> .height = 91,
>> },
>> .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>> - .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
>> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |
>> + DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE,
>> .connector_type = DRM_MODE_CONNECTOR_DPI,
>> };
>>
>
Can you pick this one up?
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-13 12:04 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 9:39 [PATCH 0/3] drm/omap: fix am4 evm lcd Tomi Valkeinen
2019-11-14 9:39 ` Tomi Valkeinen
2019-11-14 9:39 ` [PATCH 1/3] ARM: dts: am437x-gp/epos-evm: fix panel compatible Tomi Valkeinen
2019-11-14 9:39 ` Tomi Valkeinen
2019-12-02 13:01 ` Laurent Pinchart
2019-12-11 16:51 ` Tony Lindgren
2019-11-14 9:39 ` [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings Tomi Valkeinen
2019-11-14 9:39 ` Tomi Valkeinen
2019-12-02 13:04 ` Laurent Pinchart
2019-12-11 16:53 ` Tony Lindgren
2019-12-12 9:37 ` Tomi Valkeinen
2019-12-12 20:35 ` Laurent Pinchart
2020-01-13 12:01 ` Tomi Valkeinen
2020-02-11 10:01 ` Tomi Valkeinen
2020-02-11 11:07 ` Laurent Pinchart
2020-02-11 11:08 ` Tomi Valkeinen
2020-02-11 11:10 ` Laurent Pinchart
2020-02-14 0:33 ` Sebastian Reichel
2020-02-11 12:54 ` Merlijn Wajer
2020-02-11 16:05 ` Tony Lindgren
2020-02-11 16:13 ` Tomi Valkeinen
2020-02-11 16:27 ` Tony Lindgren
2020-02-11 17:22 ` Tomi Valkeinen
2020-02-13 21:57 ` Sebastian Reichel
2019-11-14 9:39 ` [PATCH 3/3] drm/panel: simple: fix osd070t1718_19ts sync drive edge Tomi Valkeinen
2019-11-14 9:39 ` Tomi Valkeinen
2019-12-02 13:07 ` Laurent Pinchart
2020-01-13 12:04 ` Tomi Valkeinen [this message]
2020-02-10 8:15 ` Tomi Valkeinen
2020-02-14 21:39 ` Sam Ravnborg
2020-02-21 10:43 ` Tomi Valkeinen
2020-02-22 12:16 ` Sam Ravnborg
2019-11-27 12:59 ` [PATCH 0/3] drm/omap: fix am4 evm lcd Tomi Valkeinen
2019-11-27 12:59 ` Tomi Valkeinen
2019-11-27 15:45 ` Tony Lindgren
2019-11-28 7:03 ` Tomi Valkeinen
2019-12-02 13:13 ` Laurent Pinchart
2019-12-02 13:24 ` Adam Ford
2019-12-03 21:27 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beb62b97-f45e-2cbc-6e2b-a05f1ef60e29@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=peter.ujfalusi@ti.com \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).