From: bugzilla-daemon@bugzilla.kernel.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 206575] [amdgpu] [drm] No video signal on resume from suspend, R9 380
Date: Tue, 18 Feb 2020 21:33:02 +0000 [thread overview]
Message-ID: <bug-206575-2300-tXNNM00MqH@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-206575-2300@https.bugzilla.kernel.org/>
https://bugzilla.kernel.org/show_bug.cgi?id=206575
--- Comment #7 from Noel Maersk (veox+kernel@veox.pw) ---
`git bisect log` output at:
https://gist.github.com/veox/36aeb77acfbcaea9c4ba1cc70052329a
Had to `skip` a few because of system instability on v5.5.4 (cause unknown,
likely
unrelated to this bug); switched to v5.4.20 halfway-in to avoid.
Result as follows (e-mails changed).
1ea8751bd28d1ec2b36a56ec6bc1ac28903d09b4 is the first bad commit
commit 1ea8751bd28d1ec2b36a56ec6bc1ac28903d09b4
Author: Noah Abradjian <spam@gmail.com>
Date: Fri Sep 27 16:30:57 2019 -0400
drm/amd/display: Make clk mgr the only dto update point
[Why]
* Clk Mgr DTO update point did not cover all needed updates, as it included
a
check for plane_state which does not exist yet when the updater is called
on
driver startup
* This resulted in another update path in the pipe programming sequence,
based
on a dppclk update flag
* However, this alternate path allowed for stray DTO updates, some of which
would
occur in the wrong order during dppclk lowering and cause underflow
[How]
* Remove plane_state check and use of plane_res.dpp->inst, getting rid
of sequence dependencies (this results in extra dto programming for
unused
pipes but that doesn't cause issues and is a small cost)
* Allow DTOs to be updated even if global clock is equal, to account for
edge case exposed by diags tests
* Remove update_dpp_dto call in pipe programming sequence (leave update to
dppclk_control there, as that update is necessary and shouldn't occur in
clk
mgr)
* Remove call to optimize_bandwidth when committing state, as it is not
needed
and resulted in sporadic underflows even with other fixes in place
Signed-off-by: Noah Abradjian <spam@gmail.com>
Reviewed-by: Jun Lei <spam@gmail.com>
Acked-by: Leo Li <spam@gmail.com>
Signed-off-by: Alex Deucher <spam@gmail.com>
.../gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 14 +++++++++-----
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 3 ++-
drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ----
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 8 +-------
4 files changed, 12 insertions(+), 17 deletions(-)
--
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-18 21:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 16:28 [Bug 206575] New: [amdgpu] [drm] No video signal on resume from suspend, R9 380 bugzilla-daemon
2020-02-17 16:29 ` [Bug 206575] " bugzilla-daemon
2020-02-17 16:29 ` bugzilla-daemon
2020-02-17 16:30 ` bugzilla-daemon
2020-02-17 16:30 ` bugzilla-daemon
2020-02-17 16:33 ` bugzilla-daemon
2020-02-17 16:38 ` bugzilla-daemon
2020-02-18 17:47 ` bugzilla-daemon
2020-02-18 21:33 ` bugzilla-daemon [this message]
2020-02-18 21:44 ` bugzilla-daemon
2020-02-18 22:06 ` bugzilla-daemon
2020-02-19 19:51 ` bugzilla-daemon
2020-02-21 0:42 ` bugzilla-daemon
2020-02-24 2:12 ` bugzilla-daemon
2020-03-16 9:39 ` bugzilla-daemon
2020-03-20 19:54 ` bugzilla-daemon
2020-03-20 20:15 ` bugzilla-daemon
2020-03-20 22:03 ` bugzilla-daemon
2020-03-23 5:06 ` bugzilla-daemon
2020-03-24 20:11 ` bugzilla-daemon
2020-04-10 8:35 ` bugzilla-daemon
2020-04-11 13:56 ` bugzilla-daemon
2020-04-11 13:59 ` bugzilla-daemon
2020-04-14 9:09 ` bugzilla-daemon
2020-04-14 13:28 ` bugzilla-daemon
2020-04-14 13:31 ` bugzilla-daemon
2020-04-14 14:10 ` bugzilla-daemon
2020-04-15 11:43 ` bugzilla-daemon
2020-04-15 11:44 ` bugzilla-daemon
2020-04-15 11:45 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-206575-2300-tXNNM00MqH@https.bugzilla.kernel.org/ \
--to=bugzilla-daemon@bugzilla.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).