From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 80419] XCOM: Enemy Unknown Causes lockup Date: Wed, 02 Mar 2016 17:17:27 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1202138091==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id CDFBF6E926 for ; Wed, 2 Mar 2016 17:17:33 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1202138091== Content-Type: multipart/alternative; boundary="14569390533.4eFC4C.21481"; charset="UTF-8" --14569390533.4eFC4C.21481 Date: Wed, 2 Mar 2016 17:17:33 +0000 MIME-Version: 1.0 Content-Type: text/plain https://bugs.freedesktop.org/show_bug.cgi?id=80419 --- Comment #118 from Edwin Smith --- In summary I think it was intimated that the issue might be caused by how XCOM deals with indices. === The game is passing indices outside start..end range, which is illegal per https://www.opengl.org/sdk/docs/man/html/glDrawRangeElementsBaseVertex.xhtml "all values in the array indices must lie between start and end, inclusive, prior to adding base vertex" === Mesa Intel and AMD/Nvidia closed source deal with this gracefully by ignoring the range hint if they are invalid however RadeonSi does not and can in some cases crash. Due to XCOM originally being designed for DirectX on Windows where this behaviour is not a fatal error combined with other OpenGL drivers on Linux & Mac also not throwing an error/warning this issue was overlooked/missed on the original port as Mesa RadeonSi was not a supported driver at the time so no-one saw the issue. This has already been fixed for our more recent games as the Mesa AMD drivers now support most of the features needed for many games so they are actively used/tested/bugs logged at Feral. We don't have any plans for a patch in the short term but we'll definitely back port this fix so we match the spec correctly into XCOM when we next patch it. -- You are receiving this mail because: You are the assignee for the bug. --14569390533.4eFC4C.21481 Date: Wed, 2 Mar 2016 17:17:33 +0000 MIME-Version: 1.0 Content-Type: text/html

Comment # 118 on bug 80419 from
In summary I think it was intimated that the issue might be caused by how XCOM
deals with indices.

===
The game is passing indices outside start..end range, which is illegal per
https://www.opengl.org/sdk/docs/man/html/glDrawRangeElementsBaseVertex.xhtml
"all values in the array indices must lie between start and end, inclusive,
prior to adding base vertex"
===

Mesa Intel and AMD/Nvidia closed source deal with this gracefully by ignoring
the range hint if they are invalid however RadeonSi does not and can in some
cases crash.

Due to XCOM originally being designed for DirectX on Windows where this
behaviour is not a fatal error combined with other OpenGL drivers on Linux &
Mac also not throwing an error/warning this issue was overlooked/missed on the
original port as Mesa RadeonSi was not a supported driver at the time so no-one
saw the issue.

This has already been fixed for our more recent games as the Mesa AMD drivers
now support most of the features needed for many games so they are actively
used/tested/bugs logged at Feral. 

We don't have any plans for a patch in the short term but we'll definitely back
port this fix so we match the spec correctly into XCOM when we next patch it.


You are receiving this mail because:
  • You are the assignee for the bug.
--14569390533.4eFC4C.21481-- --===============1202138091== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1202138091==--