From: Thomas Zimmermann <tzimmermann@suse.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 11/11] drm/udl: Sync pending URBs at the end of suspend
Date: Wed, 7 Sep 2022 09:34:06 +0200 [thread overview]
Message-ID: <c07b50fa-1741-0be8-a811-30208a92f521@suse.de> (raw)
In-Reply-To: <20220906073951.2085-12-tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 3722 bytes --]
Hi
Am 06.09.22 um 09:39 schrieb Takashi Iwai:
> It's better to perform the sync at the very last of the suspend
> instead of the pipe-disable function, so that we can catch all pending
> URBs (if any).
>
> While we're at it, drop the error code from udl_sync_pending_urb()
> since we basically ignore it; instead, give a clear error message
> indicating a problem.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/udl/udl_drv.c | 8 +++++++-
> drivers/gpu/drm/udl/udl_drv.h | 2 +-
> drivers/gpu/drm/udl/udl_main.c | 6 ++----
> drivers/gpu/drm/udl/udl_modeset.c | 2 --
> 4 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c
> index 0ba88e5472a9..91effdcefb6d 100644
> --- a/drivers/gpu/drm/udl/udl_drv.c
> +++ b/drivers/gpu/drm/udl/udl_drv.c
> @@ -21,8 +21,14 @@ static int udl_usb_suspend(struct usb_interface *interface,
> pm_message_t message)
> {
> struct drm_device *dev = usb_get_intfdata(interface);
> + int ret;
>
> - return drm_mode_config_helper_suspend(dev);
> + ret = drm_mode_config_helper_suspend(dev);
> + if (ret)
> + return ret;
> +
> + udl_sync_pending_urbs(dev);
> + return 0;
> }
>
> static int udl_usb_resume(struct usb_interface *interface)
> diff --git a/drivers/gpu/drm/udl/udl_drv.h b/drivers/gpu/drm/udl/udl_drv.h
> index d943684b5bbb..b4cc7cc568c7 100644
> --- a/drivers/gpu/drm/udl/udl_drv.h
> +++ b/drivers/gpu/drm/udl/udl_drv.h
> @@ -77,7 +77,7 @@ struct drm_connector *udl_connector_init(struct drm_device *dev);
> struct urb *udl_get_urb(struct drm_device *dev);
>
> int udl_submit_urb(struct drm_device *dev, struct urb *urb, size_t len);
> -int udl_sync_pending_urbs(struct drm_device *dev);
> +void udl_sync_pending_urbs(struct drm_device *dev);
> void udl_urb_completion(struct urb *urb);
>
> int udl_init(struct udl_device *udl);
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index 808a5ab5e14e..442080fa1061 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -290,10 +290,9 @@ int udl_submit_urb(struct drm_device *dev, struct urb *urb, size_t len)
> }
>
> /* wait until all pending URBs have been processed */
> -int udl_sync_pending_urbs(struct drm_device *dev)
> +void udl_sync_pending_urbs(struct drm_device *dev)
> {
> struct udl_device *udl = to_udl(dev);
> - int ret = 0;
>
> spin_lock_irq(&udl->urbs.lock);
> /* 2 seconds as a sane timeout */
> @@ -301,9 +300,8 @@ int udl_sync_pending_urbs(struct drm_device *dev)
> udl->urbs.available == udl->urbs.count,
> udl->urbs.lock,
> msecs_to_jiffies(2000)))
> - ret = -ETIMEDOUT;
> + drm_err(dev, "Timeout for syncing pending URBs\n");
> spin_unlock_irq(&udl->urbs.lock);
> - return ret;
> }
>
> int udl_init(struct udl_device *udl)
> diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
> index 9896c16c74f5..c506fff8f0c4 100644
> --- a/drivers/gpu/drm/udl/udl_modeset.c
> +++ b/drivers/gpu/drm/udl/udl_modeset.c
> @@ -383,8 +383,6 @@ udl_simple_display_pipe_disable(struct drm_simple_display_pipe *pipe)
> buf = udl_dummy_render(buf);
>
> udl_submit_urb(dev, urb, buf - (char *)urb->transfer_buffer);
> -
> - udl_sync_pending_urbs(dev);
> }
>
> static void
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
prev parent reply other threads:[~2022-09-07 7:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 7:39 [PATCH v2 00/11] drm/udl: More fixes Takashi Iwai
2022-09-06 7:39 ` [PATCH v2 01/11] drm/udl: Restore display mode on resume Takashi Iwai
2022-09-06 7:39 ` [PATCH v2 02/11] drm/udl: Add reset_resume Takashi Iwai
2022-09-07 6:58 ` Daniel Vetter
2022-09-06 7:39 ` [PATCH v2 03/11] drm/udl: Enable damage clipping Takashi Iwai
2022-09-06 7:39 ` [PATCH v2 04/11] Revert "drm/udl: Kill pending URBs at suspend and disconnect" Takashi Iwai
2022-09-06 7:39 ` [PATCH v2 05/11] drm/udl: Suppress error print for -EPROTO at URB completion Takashi Iwai
2022-09-06 7:39 ` [PATCH v2 06/11] drm/udl: Increase the default URB list size to 20 Takashi Iwai
2022-09-06 7:39 ` [PATCH v2 07/11] drm/udl: Drop unneeded alignment Takashi Iwai
2022-09-07 7:29 ` Thomas Zimmermann
2022-09-08 7:01 ` Takashi Iwai
2022-09-06 7:39 ` [PATCH v2 08/11] drm/udl: Fix potential URB leaks Takashi Iwai
2022-09-06 7:39 ` [PATCH v2 09/11] drm/udl: Fix inconsistent urbs.count value during udl_free_urb_list() Takashi Iwai
2022-09-07 7:31 ` Thomas Zimmermann
2022-09-06 7:39 ` [PATCH v2 10/11] drm/udl: Don't re-initialize stuff at retrying the URB list allocation Takashi Iwai
2022-09-06 7:39 ` [PATCH v2 11/11] drm/udl: Sync pending URBs at the end of suspend Takashi Iwai
2022-09-07 7:34 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c07b50fa-1741-0be8-a811-30208a92f521@suse.de \
--to=tzimmermann@suse.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).