From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D225C4332B for ; Mon, 23 Mar 2020 23:20:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6072A20719 for ; Mon, 23 Mar 2020 23:20:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="QCIdhTeH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6072A20719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DCE26E41D; Mon, 23 Mar 2020 23:20:52 +0000 (UTC) Received: from mail.kmu-office.ch (mail.kmu-office.ch [IPv6:2a02:418:6a02::a2]) by gabe.freedesktop.org (Postfix) with ESMTPS id 127766E41D for ; Mon, 23 Mar 2020 23:20:51 +0000 (UTC) Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 9B20F5C061C; Tue, 24 Mar 2020 00:20:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1585005649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ME2uFteKgH9PYBPF9Oi8ehn0DrL/JqFaIdGOvjepkbU=; b=QCIdhTeHdf8YUEA6S93r49BL5mBN5OJVczuVRarJyolXF2TWN8foI+nZdtXk6VGOE3SRNT cTsaR5vgt0PtoehmPtNxD8AOYz26oColyhBRDKH6DRUBXuCN2AWtYUSK9RNjxHIJGJqmgm dF1RaQWbDsxOyuMb33d8yzie12k1MUM= MIME-Version: 1.0 Date: Tue, 24 Mar 2020 00:20:49 +0100 From: Stefan Agner To: Laurent Pinchart Subject: Re: [PATCH 17/21] drm: mxsfb: Update internal IP version number for i.MX6SX In-Reply-To: <20200309195216.31042-18-laurent.pinchart@ideasonboard.com> References: <20200309195216.31042-1-laurent.pinchart@ideasonboard.com> <20200309195216.31042-18-laurent.pinchart@ideasonboard.com> User-Agent: Roundcube Webmail/1.4.1 Message-ID: X-Sender: stefan@agner.ch X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , kernel@pengutronix.de, dri-devel@lists.freedesktop.org, linux-imx@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-03-09 20:52, Laurent Pinchart wrote: > The LCDIF present in the i.MX6SX has extra features compared to > the i.MX28. It has however lost its IP version register, so no official > version number is known. Bump the version to MXSFB_V6 following the i.MX > version, in preparation for support for the additional features. > > Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > index 7c9a041f5f6d..2316c12c5c42 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > @@ -35,6 +35,11 @@ > enum mxsfb_devtype { > MXSFB_V3, > MXSFB_V4, > + /* > + * Starting at i.MX6 the hardware version register is gone, use the > + * i.MX family number as the version. > + */ > + MXSFB_V6, > }; > > static const struct mxsfb_devdata mxsfb_devdata[] = { > @@ -52,6 +57,13 @@ static const struct mxsfb_devdata mxsfb_devdata[] = { > .hs_wdth_mask = 0x3fff, > .hs_wdth_shift = 18, > }, > + [MXSFB_V6] = { > + .transfer_count = LCDC_V4_TRANSFER_COUNT, > + .cur_buf = LCDC_V4_CUR_BUF, > + .next_buf = LCDC_V4_NEXT_BUF, > + .hs_wdth_mask = 0x3fff, > + .hs_wdth_shift = 18, > + }, > }; > > void mxsfb_enable_axi_clk(struct mxsfb_drm_private *mxsfb) > @@ -279,7 +291,7 @@ static struct drm_driver mxsfb_driver = { > static const struct platform_device_id mxsfb_devtype[] = { > { .name = "imx23-fb", .driver_data = MXSFB_V3, }, > { .name = "imx28-fb", .driver_data = MXSFB_V4, }, > - { .name = "imx6sx-fb", .driver_data = MXSFB_V4, }, > + { .name = "imx6sx-fb", .driver_data = MXSFB_V6, }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(platform, mxsfb_devtype); _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel