From: xinlei.lee <xinlei.lee@mediatek.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: chunkuang.hu@kernel.org, Jitao Shi <jitao.shi@mediatek.com>,
airlied@linux.ie, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2,1/2] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186
Date: Tue, 23 Aug 2022 09:53:37 +0800 [thread overview]
Message-ID: <c29ca6a93fb06608d173659aff40e0f6bfed059f.camel@mediatek.com> (raw)
In-Reply-To: <20220822132350.tw73ph6nnvti6h5i@notapiano>
On Mon, 2022-08-22 at 09:23 -0400, Nícolas F. R. A. Prado wrote:
> On Mon, Aug 22, 2022 at 08:50:45PM +0800, xinlei.lee wrote:
> [..]
> > Hi Nícolas:
> >
> > Thanks for your careful review.
> > I will correct it in the next version:
> > 1. Modify key nouns in the description;
> > 2. Modify the label of jitao to Co-developed-by;
>
> To be clear, you shouldn't change jitao's signed-off-by to a co-
> developed-by,
> but add a co-developed-by. If you check the link I sent earlier [1],
> it should
> be clear that you should have something like
>
> Co-developed-by: Jitao Shi <jitao.shi@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
>
> [1]
> https://urldefense.com/v3/__https://www.kernel.org/doc/html/latest/process/submitting-patches.html*when-to-use-acked-by-cc-and-co-developed-by__;Iw!!CTRNKA9wMg0ARbw!1bj8UrTx32ihWiD-1dbKF8XsXg4tod3zHr90aemam8bnL_4jgcA9oa44UiF9ILFN9A$
>
>
> Thanks,
> Nícolas
>
> > 3. Macro definition address lowercase problem and function naming.
> >
> > If there are no other questions, I will send out the second edition
> > in
> > the near future.
> >
> > Best Regards!
> > xinlei
> >
Hi Nícolas:
Yes, maybe my statement is not very accurate, thank you for your
explanation.
Best Regards!
Xinlei
next prev parent reply other threads:[~2022-08-23 1:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 9:57 [PATCH v2,0/2] Add dpi output format control for MT8186 xinlei.lee
2022-08-05 9:57 ` [PATCH v2, 1/2] soc: mediatek: Add mmsys func to adapt to dpi output " xinlei.lee
2022-08-19 18:54 ` [PATCH v2,1/2] " Nícolas F. R. A. Prado
2022-08-22 12:50 ` xinlei.lee
2022-08-22 13:23 ` Nícolas F. R. A. Prado
2022-08-23 1:53 ` xinlei.lee [this message]
2022-08-05 9:57 ` [PATCH v2,2/2] drm: mediatek: Adjust the dpi output format to MT8186 xinlei.lee
2022-08-19 18:43 ` Nícolas F. R. A. Prado
2022-08-22 13:01 ` xinlei.lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c29ca6a93fb06608d173659aff40e0f6bfed059f.camel@mediatek.com \
--to=xinlei.lee@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).