From: Lyude Paul <lyude@redhat.com>
To: Maya Rashish <coypu@sdf.org>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/dp_mst: make build_clear_payload_id_table return void
Date: Tue, 31 Mar 2020 16:59:38 -0400 [thread overview]
Message-ID: <c427110aa4e0eb4ffdc11bb8e3b9eebfc6b50544.camel@redhat.com> (raw)
In-Reply-To: <20200321222959.GA1053@SDF.ORG>
Reviewed-by: Lyude Paul <lyude@redhat.com>
I'll go ahead and push it to drm-misc-next, thanks!
On Sat, 2020-03-21 at 22:29 +0000, Maya Rashish wrote:
> Nothing uses the always-0 return value.
>
> Signed-off-by: Maya Rashish <coypu@sdf.org>
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 4b255e25e4a1..398da29ba1bd 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -1060,13 +1060,12 @@ static void build_link_address(struct
> drm_dp_sideband_msg_tx *msg)
> drm_dp_encode_sideband_req(&req, msg);
> }
>
> -static int build_clear_payload_id_table(struct drm_dp_sideband_msg_tx *msg)
> +static void build_clear_payload_id_table(struct drm_dp_sideband_msg_tx
> *msg)
> {
> struct drm_dp_sideband_msg_req_body req;
>
> req.req_type = DP_CLEAR_PAYLOAD_ID_TABLE;
> drm_dp_encode_sideband_req(&req, msg);
> - return 0;
> }
>
> static int build_enum_path_resources(struct drm_dp_sideband_msg_tx *msg,
--
Cheers,
Lyude Paul (she/her)
Associate Software Engineer at Red Hat
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-03-31 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 22:29 [PATCH] drm/dp_mst: make build_clear_payload_id_table return void Maya Rashish
2020-03-31 20:59 ` Lyude Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c427110aa4e0eb4ffdc11bb8e3b9eebfc6b50544.camel@redhat.com \
--to=lyude@redhat.com \
--cc=coypu@sdf.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).