From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF3E5C433FE for ; Tue, 5 Oct 2021 10:13:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7279161159 for ; Tue, 5 Oct 2021 10:13:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7279161159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 995086E3BB; Tue, 5 Oct 2021 10:13:22 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4DE0C89178; Tue, 5 Oct 2021 10:13:21 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10127"; a="226016660" X-IronPort-AV: E=Sophos;i="5.85,348,1624345200"; d="scan'208";a="226016660" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 03:13:20 -0700 X-IronPort-AV: E=Sophos;i="5.85,348,1624345200"; d="scan'208";a="438643168" Received: from tbarret1-mobl.ger.corp.intel.com (HELO [10.213.238.194]) ([10.213.238.194]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 03:13:18 -0700 Subject: Re: [Intel-gfx] [PATCH 25/33] drm/i915/guc: Support request cancellation To: Sebastian Andrzej Siewior , Daniele Ceraolo Spurio Cc: Matthew Brost , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, john.c.harrison@intel.com, Thomas Gleixner , Joonas Lahtinen , Rodrigo Vivi References: <20210727002348.97202-1-matthew.brost@intel.com> <20210727002348.97202-26-matthew.brost@intel.com> <2a417f11-050a-2445-d5e9-38fe354402f2@intel.com> <20211005070656.25xszayci52wqe7h@linutronix.de> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: Date: Tue, 5 Oct 2021 11:13:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211005070656.25xszayci52wqe7h@linutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 05/10/2021 08:06, Sebastian Andrzej Siewior wrote: > On 2021-07-27 12:15:59 [-0700], Daniele Ceraolo Spurio wrote: >> On 7/26/2021 5:23 PM, Matthew Brost wrote: >>> This adds GuC backend support for i915_request_cancel(), which in turn >>> makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. >>> >> Reviewed-by: Daniele Ceraolo Spurio > > I have a few instances of ODEBUG warnings since this commit > 62eaf0ae217d4 ("drm/i915/guc: Support request cancellation") > > like: > > | ------------[ cut here ]------------ > | ODEBUG: init destroyed (active state 0) object type: i915_sw_fence hint: sw_fence_dummy_notify+0x0/0x10 > | WARNING: CPU: 0 PID: 987 at lib/debugobjects.c:505 debug_print_object+0x6e/0x90 > | Modules linked in: > | CPU: 0 PID: 987 Comm: Xorg Not tainted 5.15.0-rc4+ #67 > | Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./Z68 Pro3-M, BIOS P2.10 04/24/2012 > | RIP: 0010:debug_print_object+0x6e/0x90 > … > | Call Trace: > | i915_sw_fence_reinit+0x10/0x40 > | intel_context_init+0x185/0x1e0 > | intel_context_create+0x2e/0x100 > | default_engines+0x9d/0x120 > | i915_gem_create_context+0x40a/0x5d0 > | ? trace_kmalloc+0x29/0xd0 > | ? kmem_cache_alloc_trace+0xdd/0x190 > | i915_gem_context_open+0x140/0x1c0 > | i915_gem_open+0x70/0xa0 > | drm_file_alloc+0x1af/0x270 > | drm_open+0xdc/0x270 > | drm_stub_open+0xa6/0x130 > | chrdev_open+0xbe/0x250 > | ? cdev_device_add+0x80/0x80 > | do_dentry_open+0x15e/0x390 > | path_openat+0x76b/0xa60 > | do_filp_open+0xa4/0x150 > | ? lock_release+0x149/0x2f0 > | ? _raw_spin_unlock+0x24/0x40 > | do_sys_openat2+0x92/0x160 > | __x64_sys_openat+0x4f/0x90 > | do_syscall_64+0x3b/0xc0 > | entry_SYSCALL_64_after_hwframe+0x44/0xae > | RIP: 0033:0x7f91b5cfdf07 > > and: > | ODEBUG: activate destroyed (active state 0) object type: i915_sw_fence hint: sw_fence_dummy_notify+0x0/0x10 > | WARNING: CPU: 0 PID: 987 at lib/debugobjects.c:505 debug_print_object+0x6e/0x90 > | > | Call Trace: > | debug_object_activate+0x174/0x200 > | i915_sw_fence_commit+0x10/0x20 > | intel_context_init+0x18d/0x1e0 > | intel_context_create+0x2e/0x100 > | default_engines+0x9d/0x120 > > --- > > | ODEBUG: active_state destroyed (active state 0) object type: i915_sw_fence hint: sw_fence_dummy_notify+0x0/0x10 > | WARNING: CPU: 0 PID: 987 at lib/debugobjects.c:505 debug_print_object+0x6e/0x90 > | Call Trace: > | __i915_sw_fence_complete+0x6f/0x280 > | intel_context_init+0x18d/0x1e0 > | intel_context_create+0x2e/0x100 > | default_engines+0x9d/0x120 > > Is this known? This is yesterday's -rc4, I first noticed it in -rc3. Needs this fix: commit d576b31bdece7b5034047cbe21170e948198d32f Author: Matthew Auld Date: Fri Sep 24 15:46:46 2021 +0100 drm/i915: remember to call i915_sw_fence_fini But in the fix we forgot to add: Fixes: 62eaf0ae217d ("drm/i915/guc: Support request cancellation") So not sure if it will appear on it's own. Adding Joonas and Rodrigo for maintainer level help. Regards, Tvrtko