From: Neil Armstrong <narmstrong@baylibre.com>
To: Jitao Shi <jitao.shi@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
huijuan.xie@mediatek.com, stonea168@163.com,
cawa.cheng@mediatek.com, linux-mediatek@lists.infradead.org,
yingjoe.chen@mediatek.com, eddie.huang@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v13 1/6] dt-bindings: media: add pclk-sample dual edge property
Date: Wed, 11 Mar 2020 14:53:16 +0100 [thread overview]
Message-ID: <c46e49e6-846f-4f41-a8e3-57d5503e1cd7@baylibre.com> (raw)
In-Reply-To: <20200311071823.117899-2-jitao.shi@mediatek.com>
Hi,
On 11/03/2020 08:18, Jitao Shi wrote:
> Some chips's sample mode are rising, falling and dual edge (both
> falling and rising edge).
> Extern the pclk-sample property to support dual edge.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
> Documentation/devicetree/bindings/media/video-interfaces.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt
> index f884ada0bffc..da9ad24935db 100644
> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt
> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
> @@ -118,8 +118,8 @@ Optional endpoint properties
> - data-enable-active: similar to HSYNC and VSYNC, specifies the data enable
> signal polarity.
> - field-even-active: field signal level during the even field data transmission.
> -- pclk-sample: sample data on rising (1) or falling (0) edge of the pixel clock
> - signal.
> +- pclk-sample: sample data on rising (1), falling (0) or both rising and
> + falling (2) edge of the pixel clock signal.
> - sync-on-green-active: active state of Sync-on-green (SoG) signal, 0/1 for
> LOW/HIGH respectively.
> - data-lanes: an array of physical data lane indexes. Position of an entry
>
This changes the bus format, but we recently introduced a bus format negociation
between bridges to avoid adding such properties into DT, and make bus format setup
dynamic between an encoder and a bridge.
It would be great to use that instead.
Neil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-11 13:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 7:18 [PATCH v13 0/6] mt8183 dpi supports dual edge and pin mode swap Jitao Shi
2020-03-11 7:18 ` [PATCH v13 1/6] dt-bindings: media: add pclk-sample dual edge property Jitao Shi
2020-03-11 13:53 ` Neil Armstrong [this message]
2020-03-17 13:33 ` Chun-Kuang Hu
2020-03-11 7:18 ` [PATCH v13 2/6] dt-bindings: display: mediatek: control dpi pins mode to avoid leakage Jitao Shi
2020-03-11 13:44 ` Chun-Kuang Hu
2020-03-19 18:29 ` Rob Herring
2020-03-11 7:18 ` [PATCH v13 3/6] dt-bindings: display: mediatek: dpi sample data in dual edge support Jitao Shi
2020-03-11 7:18 ` [PATCH v13 4/6] dt-bindings: display: mediatek: convert the document format from txt to yaml Jitao Shi
2020-03-19 18:33 ` Rob Herring
2020-03-11 7:18 ` [PATCH v13 5/6] drm/mediatek: dpi sample mode support Jitao Shi
2020-03-11 13:56 ` Neil Armstrong
2020-03-11 7:18 ` [PATCH v13 6/6] drm/mediatek: set dpi pin mode to gpio low to avoid leakage current Jitao Shi
2020-03-11 13:45 ` Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c46e49e6-846f-4f41-a8e3-57d5503e1cd7@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=airlied@linux.ie \
--cc=cawa.cheng@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eddie.huang@mediatek.com \
--cc=huijuan.xie@mediatek.com \
--cc=jitao.shi@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=stonea168@163.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).