From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C856C433EF for ; Mon, 3 Jan 2022 18:57:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7464889D9A; Mon, 3 Jan 2022 18:57:40 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC67889870; Mon, 3 Jan 2022 18:57:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641236258; x=1672772258; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nU6vWZWZhKZhv6sqSOiFoNQ0cbmogFp4gZjuVnk1evc=; b=bcQLlRWKPwGt+u5dzAgSxtHiPvp9rGvGpNDQdhTxTPzUqHWP7qDrUTHV wr1uigIAnzr3XuIZLElv5oLAK/iSXECIN+iMNmyYStqOWat4gXiTCk2ZX fnqje5/Anywe4/gr5umMpU4ExOZDUZx/QszkK6JnrAuj72Zmu2CiiLugc 1XkadfEvw+S92sZZgwCl1j4rosz1851ymE2F9EON8HJaG5fsTR+s7KYN0 eH/H7Q0Ad95YYWNpPvWkzjtEJXa95pNXyusVwL2vaQ58tt3rz2dAV3vyT i4svZTCUsM5hrmWMJmzpoaD1h0dUTnfeZTY69a3xG5s0UGsB8aY2n5RIP A==; X-IronPort-AV: E=McAfee;i="6200,9189,10215"; a="242312984" X-IronPort-AV: E=Sophos;i="5.88,258,1635231600"; d="scan'208";a="242312984" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2022 10:57:38 -0800 X-IronPort-AV: E=Sophos;i="5.88,258,1635231600"; d="scan'208";a="487944544" Received: from mikaelsk-mobl1.ger.corp.intel.com (HELO [10.249.254.198]) ([10.249.254.198]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2022 10:57:36 -0800 Message-ID: Date: Mon, 3 Jan 2022 19:57:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the vma resource as argument for gtt binding / unbinding Content-Language: en-US To: "Zeng, Oak" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" References: <20220103115947.92688-1-thomas.hellstrom@linux.intel.com> <20220103115947.92688-3-thomas.hellstrom@linux.intel.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Auld, Matthew" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Oak. On 1/3/22 19:17, Zeng, Oak wrote: > > Regards, > Oak > >> -----Original Message----- >> From: Intel-gfx On Behalf Of Thomas Hellström >> Sent: January 3, 2022 7:00 AM >> To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org >> Cc: Thomas Hellström ; Auld, Matthew >> Subject: [Intel-gfx] [PATCH v4 2/4] drm/i915: Use the vma resource as argument for gtt binding / unbinding >> >> When introducing asynchronous unbinding, the vma itself may no longer >> be alive when the actual binding or unbinding takes place. > Can we take an extra reference counter of the vma to keep the vma alive, until the actual binding/unbinding takes place? The point here is that that's not needed, and should be avoided. If the vma is no longer alive, that means nobody uses it anymore, but the GPU may still have work in the pipe that references the GPU virtual address. /Thomas.