From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Brodsky Subject: Re: [PATCH v13 10/20] kernel, arm64: untag user pointers in prctl_set_mm* Date: Thu, 21 Mar 2019 17:52:37 +0000 Message-ID: References: <76f96eb9162b3a7fa5949d71af38bf8fdf6924c4.1553093421.git.andreyknvl@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <76f96eb9162b3a7fa5949d71af38bf8fdf6924c4.1553093421.git.andreyknvl@google.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrey Konovalov , Catalin Marinas , Will Deacon , Mark Rutland , Robin Murphy , Kees Cook , Kate Stewart , Greg Kroah-Hartman , Andrew Morton , Ingo Molnar , "Kirill A . Shutemov" , Shuah Khan , Vincenzo Frascino , Eric Dumazet , "David S. Miller" , Alexei Starovoitov , Daniel Borkmann , Steven Rostedt , Ingo Molnar , Peter Zijlstra , Arnaldo Carvalho de Melo , Alex Deucher Cc: Chintan Pandya , Jacob Bramley , Ruben Ayrapetyan , Szabolcs Nagy , Lee Smith , Kostya Serebryany , Dmitry Vyukov , Ramana Radhakrishnan , Luc Van Oostenryck , Dave Martin , Evgeniy Stepanov List-Id: dri-devel@lists.freedesktop.org T24gMjAvMDMvMjAxOSAxNDo1MSwgQW5kcmV5IEtvbm92YWxvdiB3cm90ZToKPiBUaGlzIHBhdGNo IGlzIGEgcGFydCBvZiBhIHNlcmllcyB0aGF0IGV4dGVuZHMgYXJtNjQga2VybmVsIEFCSSB0byBh bGxvdyB0bwo+IHBhc3MgdGFnZ2VkIHVzZXIgcG9pbnRlcnMgKHdpdGggdGhlIHRvcCBieXRlIHNl dCB0byBzb21ldGhpbmcgZWxzZSBvdGhlcgo+IHRoYW4gMHgwMCkgYXMgc3lzY2FsbCBhcmd1bWVu dHMuCj4KPiBwcmN0bF9zZXRfbW0oKSBhbmQgcHJjdGxfc2V0X21tX21hcCgpIHVzZSBwcm92aWRl ZCB1c2VyIHBvaW50ZXJzIGZvciB2bWEKPiBsb29rdXBzIGFuZCBkbyBzb21lIHBvaW50ZXIgY29t cGFyaXNvbnMgdG8gcGVyZm9ybSB2YWxpZGF0aW9uLCB3aGljaCBjYW4KPiBvbmx5IGJ5IGRvbmUg d2l0aCB1bnRhZ2dlZCBwb2ludGVycy4KPgo+IFVudGFnIHVzZXIgcG9pbnRlcnMgaW4gdGhlc2Ug ZnVuY3Rpb25zIGZvciB2bWEgbG9va3VwIGFuZCB2YWxpZGl0eSBjaGVja3MuCj4KPiBTaWduZWQt b2ZmLWJ5OiBBbmRyZXkgS29ub3ZhbG92IDxhbmRyZXlrbnZsQGdvb2dsZS5jb20+Cj4gLS0tCj4g ICBrZXJuZWwvc3lzLmMgfCA0NCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9u cygtKQo+Cj4gZGlmZiAtLWdpdCBhL2tlcm5lbC9zeXMuYyBiL2tlcm5lbC9zeXMuYwo+IGluZGV4 IDEyZGYwZTU0MzRiOC4uZmUyNmNjZjNjOWU2IDEwMDY0NAo+IC0tLSBhL2tlcm5lbC9zeXMuYwo+ ICsrKyBiL2tlcm5lbC9zeXMuYwo+IEBAIC0xODg1LDExICsxODg1LDEyIEBAIHN0YXRpYyBpbnQg cHJjdGxfc2V0X21tX2V4ZV9maWxlKHN0cnVjdCBtbV9zdHJ1Y3QgKm1tLCB1bnNpZ25lZCBpbnQg ZmQpCj4gICAgKiBXQVJOSU5HOiB3ZSBkb24ndCByZXF1aXJlIGFueSBjYXBhYmlsaXR5IGhlcmUg c28gYmUgdmVyeSBjYXJlZnVsCj4gICAgKiBpbiB3aGF0IGlzIGFsbG93ZWQgZm9yIG1vZGlmaWNh dGlvbiBmcm9tIHVzZXJzcGFjZS4KPiAgICAqLwo+IC1zdGF0aWMgaW50IHZhbGlkYXRlX3ByY3Rs X21hcChzdHJ1Y3QgcHJjdGxfbW1fbWFwICpwcmN0bF9tYXApCj4gK3N0YXRpYyBpbnQgdmFsaWRh dGVfcHJjdGxfbWFwKHN0cnVjdCBwcmN0bF9tbV9tYXAgKnRhZ2dlZF9wcmN0bF9tYXApCj4gICB7 Cj4gICAJdW5zaWduZWQgbG9uZyBtbWFwX21heF9hZGRyID0gVEFTS19TSVpFOwo+ICAgCXN0cnVj dCBtbV9zdHJ1Y3QgKm1tID0gY3VycmVudC0+bW07Cj4gICAJaW50IGVycm9yID0gLUVJTlZBTCwg aTsKPiArCXN0cnVjdCBwcmN0bF9tbV9tYXAgcHJjdGxfbWFwOwo+ICAgCj4gICAJc3RhdGljIGNv bnN0IHVuc2lnbmVkIGNoYXIgb2Zmc2V0c1tdID0gewo+ICAgCQlvZmZzZXRvZihzdHJ1Y3QgcHJj dGxfbW1fbWFwLCBzdGFydF9jb2RlKSwKPiBAQCAtMTkwNSwxMiArMTkwNiwyNSBAQCBzdGF0aWMg aW50IHZhbGlkYXRlX3ByY3RsX21hcChzdHJ1Y3QgcHJjdGxfbW1fbWFwICpwcmN0bF9tYXApCj4g ICAJCW9mZnNldG9mKHN0cnVjdCBwcmN0bF9tbV9tYXAsIGVudl9lbmQpLAo+ICAgCX07Cj4gICAK PiArCW1lbWNweSgmcHJjdGxfbWFwLCB0YWdnZWRfcHJjdGxfbWFwLCBzaXplb2YocHJjdGxfbWFw KSk7Cj4gKwlwcmN0bF9tYXAuc3RhcnRfY29kZQk9IHVudGFnZ2VkX2FkZHIocHJjdGxfbWFwLnN0 YXJ0X2NvZGUpOwo+ICsJcHJjdGxfbWFwLmVuZF9jb2RlCT0gdW50YWdnZWRfYWRkcihwcmN0bF9t YXAuZW5kX2NvZGUpOwo+ICsJcHJjdGxfbWFwLnN0YXJ0X2RhdGEJPSB1bnRhZ2dlZF9hZGRyKHBy Y3RsX21hcC5zdGFydF9kYXRhKTsKPiArCXByY3RsX21hcC5lbmRfZGF0YQk9IHVudGFnZ2VkX2Fk ZHIocHJjdGxfbWFwLmVuZF9kYXRhKTsKPiArCXByY3RsX21hcC5zdGFydF9icmsJPSB1bnRhZ2dl ZF9hZGRyKHByY3RsX21hcC5zdGFydF9icmspOwo+ICsJcHJjdGxfbWFwLmJyawkJPSB1bnRhZ2dl ZF9hZGRyKHByY3RsX21hcC5icmspOwo+ICsJcHJjdGxfbWFwLnN0YXJ0X3N0YWNrCT0gdW50YWdn ZWRfYWRkcihwcmN0bF9tYXAuc3RhcnRfc3RhY2spOwo+ICsJcHJjdGxfbWFwLmFyZ19zdGFydAk9 IHVudGFnZ2VkX2FkZHIocHJjdGxfbWFwLmFyZ19zdGFydCk7Cj4gKwlwcmN0bF9tYXAuYXJnX2Vu ZAk9IHVudGFnZ2VkX2FkZHIocHJjdGxfbWFwLmFyZ19lbmQpOwo+ICsJcHJjdGxfbWFwLmVudl9z dGFydAk9IHVudGFnZ2VkX2FkZHIocHJjdGxfbWFwLmVudl9zdGFydCk7Cj4gKwlwcmN0bF9tYXAu ZW52X2VuZAk9IHVudGFnZ2VkX2FkZHIocHJjdGxfbWFwLmVudl9lbmQpOwo+ICsKPiAgIAkvKgo+ ICAgCSAqIE1ha2Ugc3VyZSB0aGUgbWVtYmVycyBhcmUgbm90IHNvbWV3aGVyZSBvdXRzaWRlCj4g ICAJICogb2YgYWxsb3dlZCBhZGRyZXNzIHNwYWNlLgo+ICAgCSAqLwo+ICAgCWZvciAoaSA9IDA7 IGkgPCBBUlJBWV9TSVpFKG9mZnNldHMpOyBpKyspIHsKPiAtCQl1NjQgdmFsID0gKih1NjQgKiko KGNoYXIgKilwcmN0bF9tYXAgKyBvZmZzZXRzW2ldKTsKPiArCQl1NjQgdmFsID0gKih1NjQgKiko KGNoYXIgKikmcHJjdGxfbWFwICsgb2Zmc2V0c1tpXSk7Cj4gICAKPiAgIAkJaWYgKCh1bnNpZ25l ZCBsb25nKXZhbCA+PSBtbWFwX21heF9hZGRyIHx8Cj4gICAJCSAgICAodW5zaWduZWQgbG9uZyl2 YWwgPCBtbWFwX21pbl9hZGRyKQo+IEBAIC0xOTIxLDggKzE5MzUsOCBAQCBzdGF0aWMgaW50IHZh bGlkYXRlX3ByY3RsX21hcChzdHJ1Y3QgcHJjdGxfbW1fbWFwICpwcmN0bF9tYXApCj4gICAJICog TWFrZSBzdXJlIHRoZSBwYWlycyBhcmUgb3JkZXJlZC4KPiAgIAkgKi8KPiAgICNkZWZpbmUgX19w cmN0bF9jaGVja19vcmRlcihfX20xLCBfX29wLCBfX20yKQkJCQlcCj4gLQkoKHVuc2lnbmVkIGxv bmcpcHJjdGxfbWFwLT5fX20xIF9fb3AJCQkJXAo+IC0JICh1bnNpZ25lZCBsb25nKXByY3RsX21h cC0+X19tMikgPyAwIDogLUVJTlZBTAo+ICsJKCh1bnNpZ25lZCBsb25nKXByY3RsX21hcC5fX20x IF9fb3AJCQkJXAo+ICsJICh1bnNpZ25lZCBsb25nKXByY3RsX21hcC5fX20yKSA/IDAgOiAtRUlO VkFMCj4gICAJZXJyb3IgID0gX19wcmN0bF9jaGVja19vcmRlcihzdGFydF9jb2RlLCA8LCBlbmRf Y29kZSk7Cj4gICAJZXJyb3IgfD0gX19wcmN0bF9jaGVja19vcmRlcihzdGFydF9kYXRhLCA8LCBl bmRfZGF0YSk7Cj4gICAJZXJyb3IgfD0gX19wcmN0bF9jaGVja19vcmRlcihzdGFydF9icmssIDw9 LCBicmspOwo+IEBAIC0xOTM3LDIzICsxOTUxLDI0IEBAIHN0YXRpYyBpbnQgdmFsaWRhdGVfcHJj dGxfbWFwKHN0cnVjdCBwcmN0bF9tbV9tYXAgKnByY3RsX21hcCkKPiAgIAkvKgo+ICAgCSAqIEBi cmsgc2hvdWxkIGJlIGFmdGVyIEBlbmRfZGF0YSBpbiB0cmFkaXRpb25hbCBtYXBzLgo+ICAgCSAq Lwo+IC0JaWYgKHByY3RsX21hcC0+c3RhcnRfYnJrIDw9IHByY3RsX21hcC0+ZW5kX2RhdGEgfHwK PiAtCSAgICBwcmN0bF9tYXAtPmJyayA8PSBwcmN0bF9tYXAtPmVuZF9kYXRhKQo+ICsJaWYgKHBy Y3RsX21hcC5zdGFydF9icmsgPD0gcHJjdGxfbWFwLmVuZF9kYXRhIHx8Cj4gKwkgICAgcHJjdGxf bWFwLmJyayA8PSBwcmN0bF9tYXAuZW5kX2RhdGEpCj4gICAJCWdvdG8gb3V0Owo+ICAgCj4gICAJ LyoKPiAgIAkgKiBOZWl0aGVyIHdlIHNob3VsZCBhbGxvdyB0byBvdmVycmlkZSBsaW1pdHMgaWYg dGhleSBzZXQuCj4gICAJICovCj4gLQlpZiAoY2hlY2tfZGF0YV9ybGltaXQocmxpbWl0KFJMSU1J VF9EQVRBKSwgcHJjdGxfbWFwLT5icmssCj4gLQkJCSAgICAgIHByY3RsX21hcC0+c3RhcnRfYnJr LCBwcmN0bF9tYXAtPmVuZF9kYXRhLAo+IC0JCQkgICAgICBwcmN0bF9tYXAtPnN0YXJ0X2RhdGEp KQo+ICsJaWYgKGNoZWNrX2RhdGFfcmxpbWl0KHJsaW1pdChSTElNSVRfREFUQSksIHByY3RsX21h cC5icmssCj4gKwkJCSAgICAgIHByY3RsX21hcC5zdGFydF9icmssIHByY3RsX21hcC5lbmRfZGF0 YSwKPiArCQkJICAgICAgcHJjdGxfbWFwLnN0YXJ0X2RhdGEpKQo+ICAgCQkJZ290byBvdXQ7Cj4g ICAKPiAgIAkvKgo+ICAgCSAqIFNvbWVvbmUgaXMgdHJ5aW5nIHRvIGNoZWF0IHRoZSBhdXh2IHZl Y3Rvci4KPiAgIAkgKi8KPiAtCWlmIChwcmN0bF9tYXAtPmF1eHZfc2l6ZSkgewo+IC0JCWlmICgh cHJjdGxfbWFwLT5hdXh2IHx8IHByY3RsX21hcC0+YXV4dl9zaXplID4gc2l6ZW9mKG1tLT5zYXZl ZF9hdXh2KSkKPiArCWlmIChwcmN0bF9tYXAuYXV4dl9zaXplKSB7Cj4gKwkJaWYgKCFwcmN0bF9t YXAuYXV4diB8fCBwcmN0bF9tYXAuYXV4dl9zaXplID4KPiArCQkJCQkJc2l6ZW9mKG1tLT5zYXZl ZF9hdXh2KSkKPiAgIAkJCWdvdG8gb3V0Owo+ICAgCX0KPiAgIAo+IEBAIC0xOTYyLDcgKzE5Nzcs NyBAQCBzdGF0aWMgaW50IHZhbGlkYXRlX3ByY3RsX21hcChzdHJ1Y3QgcHJjdGxfbW1fbWFwICpw cmN0bF9tYXApCj4gICAJICogY2hhbmdlIC9wcm9jL3BpZC9leGUgbGluazogb25seSBsb2NhbCBz eXMgYWRtaW4gc2hvdWxkCj4gICAJICogYmUgYWxsb3dlZCB0by4KPiAgIAkgKi8KPiAtCWlmIChw cmN0bF9tYXAtPmV4ZV9mZCAhPSAodTMyKS0xKSB7Cj4gKwlpZiAocHJjdGxfbWFwLmV4ZV9mZCAh PSAodTMyKS0xKSB7Cj4gICAJCWlmICghbnNfY2FwYWJsZShjdXJyZW50X3VzZXJfbnMoKSwgQ0FQ X1NZU19BRE1JTikpCj4gICAJCQlnb3RvIG91dDsKPiAgIAl9Cj4gQEAgLTIxMjAsMTMgKzIxMzUs MTQgQEAgc3RhdGljIGludCBwcmN0bF9zZXRfbW0oaW50IG9wdCwgdW5zaWduZWQgbG9uZyBhZGRy LAo+ICAgCWlmIChvcHQgPT0gUFJfU0VUX01NX0FVWFYpCj4gICAJCXJldHVybiBwcmN0bF9zZXRf YXV4dihtbSwgYWRkciwgYXJnNCk7Cj4gICAKPiAtCWlmIChhZGRyID49IFRBU0tfU0laRSB8fCBh ZGRyIDwgbW1hcF9taW5fYWRkcikKPiArCWlmICh1bnRhZ2dlZF9hZGRyKGFkZHIpID49IFRBU0tf U0laRSB8fAo+ICsJCQl1bnRhZ2dlZF9hZGRyKGFkZHIpIDwgbW1hcF9taW5fYWRkcikKPiAgIAkJ cmV0dXJuIC1FSU5WQUw7Cj4gICAKPiAgIAllcnJvciA9IC1FSU5WQUw7Cj4gICAKPiAgIAlkb3du X3dyaXRlKCZtbS0+bW1hcF9zZW0pOwo+IC0Jdm1hID0gZmluZF92bWEobW0sIGFkZHIpOwo+ICsJ dm1hID0gZmluZF92bWEobW0sIHVudGFnZ2VkX2FkZHIoYWRkcikpOwo+ICAgCj4gICAJcHJjdGxf bWFwLnN0YXJ0X2NvZGUJPSBtbS0+c3RhcnRfY29kZTsKPiAgIAlwcmN0bF9tYXAuZW5kX2NvZGUJ PSBtbS0+ZW5kX2NvZGU7CgpJIHRoaW5rIHRoaXMgbmV3IHZlcnNpb24gaXMgY29uc2lzdGVudCB3 LnIudC4gdGFnZ2VkL3VudGFnZ2VkIHBvaW50ZXIgdXNhZ2UuIEhvd2V2ZXIsIApJIGFsc28gbm90 ZSB0aGF0IGEgc2lnbmlmaWNhbnQgY2hhbmdlIGhhcyBiZWVuIGludHJvZHVjZWQ6IGl0IGlzIG5v dyBwb3NzaWJsZSB0byBzZXQgCk1NIGZpZWxkcyB0byB0YWdnZWQgYWRkcmVzc2VzICh0YWdzIGFy ZSBpZ25vcmVkIGJ5IHZhbGlkYXRlX3ByY3RsX21hcCgpKS4gSSBhbSBub3QgCm9wcG9zZWQgdG8g dGhpcyBhcyBzdWNoLCBidXQgaGF2ZSB5b3UgY29uc2lkZXJlZCB0aGUgaW1wbGljYXRpb25zPyBE b2VzIGl0IG1ha2Ugc2Vuc2UgCnRvIGhhdmUgYSB0YWdnZWQgdmFsdWUgZm9yIGUuZy4gcHJjdGxf bWFwLmFyZ19zdGFydD8gSXMgdGhlIGtlcm5lbCBhYmxlIHRvIGhhbmRsZSAKdGFnZ2VkIHZhbHVl cyBpbiB0aG9zZSBmaWVsZHM/IEkgaGF2ZSB0aGUgZmVlbGluZyB0aGF0IGl0J3Mgc2FmZXIgdG8g ZGlzY2FyZCB0YWdzIGZvciAKbm93LCBhbmQgaWYgbmVjZXNzYXJ5IGFsbG93IHRoZW0gdG8gYmUg cHJlc2VydmVkIGxhdGVyIG9uLgoKS2V2aW4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVs