[PATCH] drm/i915/ehl: Remove require_force_probe protection

[PATCH] drm/i915/ehl: Remove require_force_probe protection

[Kamati Srinivas]

Removing force probe protection from EHL platform. Did
not observe warnings, errors, flickering or any visual
defects while doing ordinary tasks like browsing and
editing documents in a two monitor setup.

Signed-off-by: Kamati Srinivas <srinivasx.k@intel.com>
---
 drivers/gpu/drm/i915/i915_pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 366ddfc8df6b..aa9c17a6851c 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -841,7 +841,6 @@ static const struct intel_device_info icl_info = {
 static const struct intel_device_info ehl_info = {
 	GEN11_FEATURES,
 	PLATFORM(INTEL_ELKHARTLAKE),
-	.require_force_probe = 1,
 	.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VCS0) | BIT(VECS0),
 	.ppgtt_size = 36,
 };
-- 
2.25.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[Souza, Jose]

+Rodrigo and Jani

On Tue, 2020-10-06 at 14:56 +0000, Kamati Srinivas wrote:
> Removing force probe protection from EHL platform. Did
> not observe warnings, errors, flickering or any visual
> defects while doing ordinary tasks like browsing and
> editing documents in a two monitor setup.

One of the requirements was also to have CI BAT all green and shards as green is possible but EHL don't show up in CI results, we actually have one
single EHL machine in CI but I guess it is not able to run all tests that shards do:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/filelist.html

> 
> Signed-off-by: Kamati Srinivas <srinivasx.k@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_pci.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 366ddfc8df6b..aa9c17a6851c 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -841,7 +841,6 @@ static const struct intel_device_info icl_info = {
>  static const struct intel_device_info ehl_info = {
>  	GEN11_FEATURES,
>  	PLATFORM(INTEL_ELKHARTLAKE),
> -	.require_force_probe = 1,
>  	.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VCS0) | BIT(VECS0),
>  	.ppgtt_size = 36,
>  };

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[Chris Wilson]

Quoting Souza, Jose (2020-10-06 18:46:45)
> +Rodrigo and Jani
> 
> On Tue, 2020-10-06 at 14:56 +0000, Kamati Srinivas wrote:
> > Removing force probe protection from EHL platform. Did
> > not observe warnings, errors, flickering or any visual
> > defects while doing ordinary tasks like browsing and
> > editing documents in a two monitor setup.
> 
> One of the requirements was also to have CI BAT all green and shards as green is possible but EHL don't show up in CI results, we actually have one
> single EHL machine in CI but I guess it is not able to run all tests that shards do:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/filelist.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[Vivi, Rodrigo]

> On Oct 6, 2020, at 10:48 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> 
> Quoting Souza, Jose (2020-10-06 18:46:45)
>> +Rodrigo and Jani
>> 
>> On Tue, 2020-10-06 at 14:56 +0000, Kamati Srinivas wrote:
>>> Removing force probe protection from EHL platform. Did
>>> not observe warnings, errors, flickering or any visual
>>> defects while doing ordinary tasks like browsing and
>>> editing documents in a two monitor setup.
>> 
>> One of the requirements was also to have CI BAT all green and shards as green is possible but EHL don't show up in CI results, we actually have one
>> single EHL machine in CI but I guess it is not able to run all tests that shards do:
>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/filelist.html
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html

we are really close to that point. We just need to fix some w/a and rc6 issues
before applying this change.

> -Chris

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[Souza, Jose]

On Tue, 2020-10-06 at 10:55 -0700, Vivi, Rodrigo wrote:
> 
> > On Oct 6, 2020, at 10:48 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > 
> > Quoting Souza, Jose (2020-10-06 18:46:45)
> > > +Rodrigo and Jani
> > > 
> > > On Tue, 2020-10-06 at 14:56 +0000, Kamati Srinivas wrote:
> > > > Removing force probe protection from EHL platform. Did
> > > > not observe warnings, errors, flickering or any visual
> > > > defects while doing ordinary tasks like browsing and
> > > > editing documents in a two monitor setup.
> > > 
> > > One of the requirements was also to have CI BAT all green and shards as green is possible but EHL don't show up in CI results, we actually have one
> > > single EHL machine in CI but I guess it is not able to run all tests that shards do:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/filelist.html
> > 
> > https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html
> 
> we are really close to that point. We just need to fix some w/a and rc6 issues
> before applying this change.
> 
> > -Chris
> 

Huum okay we have drm-tip results for EHL but if someone sends a patch that breaks EHL it will not be caught in pre-merge testing.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[K, SrinivasX]

Hi Rodrigo,

How do we get W/A and rc6 changes in, do you have any details? 

Thanks,
Srinivas

-----Original Message-----
From: Souza, Jose <jose.souza@intel.com> 
Sent: 06 October 2020 23:33
To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; chris@chris-wilson.co.uk
Cc: Ausmus, James <james.ausmus@intel.com>; Nikula, Jani <jani.nikula@intel.com>; Pandey, Hariom <hariom.pandey@intel.com>; Roper, Matthew D <matthew.d.roper@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; K, SrinivasX <srinivasx.k@intel.com>; Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

On Tue, 2020-10-06 at 10:55 -0700, Vivi, Rodrigo wrote:
> 
> > On Oct 6, 2020, at 10:48 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > 
> > Quoting Souza, Jose (2020-10-06 18:46:45)
> > > +Rodrigo and Jani
> > > 
> > > On Tue, 2020-10-06 at 14:56 +0000, Kamati Srinivas wrote:
> > > > Removing force probe protection from EHL platform. Did not 
> > > > observe warnings, errors, flickering or any visual defects while 
> > > > doing ordinary tasks like browsing and editing documents in a 
> > > > two monitor setup.
> > > 
> > > One of the requirements was also to have CI BAT all green and 
> > > shards as green is possible but EHL don't show up in CI results, we actually have one single EHL machine in CI but I guess it is not able to run all tests that shards do:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/filelist.html
> > 
> > https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html
> 
> we are really close to that point. We just need to fix some w/a and 
> rc6 issues before applying this change.
> 
> > -Chris
> 

Huum okay we have drm-tip results for EHL but if someone sends a patch that breaks EHL it will not be caught in pre-merge testing.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[Vivi, Rodrigo]

> On Oct 9, 2020, at 1:31 AM, K, SrinivasX <srinivasx.k@intel.com> wrote:
> 
> Hi Rodrigo,
> 
> How do we get W/A and rc6 changes in, do you have any details?

I told based on what I was seeing on https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html?
focusing on the issues that are exclusively for ehl and not happening on other platforms.

It looks like workarounds are fine there now. so I'm not sure if it was sporadic thing that day.

for the rc6 there are a few testcases failing around it:
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_pm_rc6_residency@rc6-fence.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_pm_rc6_residency@rc6-idle.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_selftest@live@gt_pm.html#dmesg-warnings415

> 
> Thanks,
> Srinivas
> 
> -----Original Message-----
> From: Souza, Jose <jose.souza@intel.com>
> Sent: 06 October 2020 23:33
> To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; chris@chris-wilson.co.uk
> Cc: Ausmus, James <james.ausmus@intel.com>; Nikula, Jani <jani.nikula@intel.com>; Pandey, Hariom <hariom.pandey@intel.com>; Roper, Matthew D <matthew.d.roper@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; K, SrinivasX <srinivasx.k@intel.com>; Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection
> 
> On Tue, 2020-10-06 at 10:55 -0700, Vivi, Rodrigo wrote:
>> 
>>> On Oct 6, 2020, at 10:48 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>> 
>>> Quoting Souza, Jose (2020-10-06 18:46:45)
>>>> +Rodrigo and Jani
>>>> 
>>>> On Tue, 2020-10-06 at 14:56 +0000, Kamati Srinivas wrote:
>>>>> Removing force probe protection from EHL platform. Did not
>>>>> observe warnings, errors, flickering or any visual defects while
>>>>> doing ordinary tasks like browsing and editing documents in a
>>>>> two monitor setup.
>>>> 
>>>> One of the requirements was also to have CI BAT all green and
>>>> shards as green is possible but EHL don't show up in CI results, we actually have one single EHL machine in CI but I guess it is not able to run all tests that shards do:
>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/filelist.html
>>> 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html
>> 
>> we are really close to that point. We just need to fix some w/a and
>> rc6 issues before applying this change.
>> 
>>> -Chris
>> 
> 
> Huum okay we have drm-tip results for EHL but if someone sends a patch that breaks EHL it will not be caught in pre-merge testing.
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[Pandey, Hariom]

Hi Srinivas,

Take Sunil's help who has recently validated RC6 on EHL DRM tip and found to be passing. If the WA were sporadically failing and if you confirm that RC6 is passing, this patch can be proceeded with. 

Thanks
Hariom Pandey

-----Original Message-----
From: Vivi, Rodrigo <rodrigo.vivi@intel.com> 
Sent: Friday, October 9, 2020 7:09 PM
To: K, SrinivasX <srinivasx.k@intel.com>
Cc: Souza, Jose <jose.souza@intel.com>; chris@chris-wilson.co.uk; Ausmus, James <james.ausmus@intel.com>; Nikula, Jani <jani.nikula@intel.com>; Pandey, Hariom <hariom.pandey@intel.com>; Roper, Matthew D <matthew.d.roper@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection



> On Oct 9, 2020, at 1:31 AM, K, SrinivasX <srinivasx.k@intel.com> wrote:
> 
> Hi Rodrigo,
> 
> How do we get W/A and rc6 changes in, do you have any details?

I told based on what I was seeing on https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html?
focusing on the issues that are exclusively for ehl and not happening on other platforms.

It looks like workarounds are fine there now. so I'm not sure if it was sporadic thing that day.

for the rc6 there are a few testcases failing around it:
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_pm_rc6_residency@rc6-fence.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_pm_rc6_residency@rc6-idle.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_selftest@live@gt_pm.html#dmesg-warnings415

> 
> Thanks,
> Srinivas
> 
> -----Original Message-----
> From: Souza, Jose <jose.souza@intel.com>
> Sent: 06 October 2020 23:33
> To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; chris@chris-wilson.co.uk
> Cc: Ausmus, James <james.ausmus@intel.com>; Nikula, Jani 
> <jani.nikula@intel.com>; Pandey, Hariom <hariom.pandey@intel.com>; 
> Roper, Matthew D <matthew.d.roper@intel.com>; 
> intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; K, 
> SrinivasX <srinivasx.k@intel.com>; Surendrakumar Upadhyay, TejaskumarX 
> <tejaskumarx.surendrakumar.upadhyay@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove 
> require_force_probe protection
> 
> On Tue, 2020-10-06 at 10:55 -0700, Vivi, Rodrigo wrote:
>> 
>>> On Oct 6, 2020, at 10:48 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>> 
>>> Quoting Souza, Jose (2020-10-06 18:46:45)
>>>> +Rodrigo and Jani
>>>> 
>>>> On Tue, 2020-10-06 at 14:56 +0000, Kamati Srinivas wrote:
>>>>> Removing force probe protection from EHL platform. Did not observe 
>>>>> warnings, errors, flickering or any visual defects while doing 
>>>>> ordinary tasks like browsing and editing documents in a two 
>>>>> monitor setup.
>>>> 
>>>> One of the requirements was also to have CI BAT all green and 
>>>> shards as green is possible but EHL don't show up in CI results, we actually have one single EHL machine in CI but I guess it is not able to run all tests that shards do:
>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/filelist.html
>>> 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html
>> 
>> we are really close to that point. We just need to fix some w/a and
>> rc6 issues before applying this change.
>> 
>>> -Chris
>> 
> 
> Huum okay we have drm-tip results for EHL but if someone sends a patch that breaks EHL it will not be caught in pre-merge testing.
> 


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[K, SrinivasX]

Hi Hariom,

With Sunil's help was able to see EHL achieving rc6 state. 
Verified from sys entries, under no load to gpu rc6_residency_ms counter is changing.
Also ran all the Rodrigo mention tests and I see them passing. But with i915_selftest dmesg warnings are still seen.

Thanks,
Srinivas

-----Original Message-----
From: Pandey, Hariom <hariom.pandey@intel.com> 
Sent: 09 October 2020 23:39
To: K, SrinivasX <srinivasx.k@intel.com>
Cc: Souza, Jose <jose.souza@intel.com>; chris@chris-wilson.co.uk; Ausmus, James <james.ausmus@intel.com>; Nikula, Jani <jani.nikula@intel.com>; Roper, Matthew D <matthew.d.roper@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>
Subject: RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

Hi Srinivas,

Take Sunil's help who has recently validated RC6 on EHL DRM tip and found to be passing. If the WA were sporadically failing and if you confirm that RC6 is passing, this patch can be proceeded with. 

Thanks
Hariom Pandey

-----Original Message-----
From: Vivi, Rodrigo <rodrigo.vivi@intel.com> 
Sent: Friday, October 9, 2020 7:09 PM
To: K, SrinivasX <srinivasx.k@intel.com>
Cc: Souza, Jose <jose.souza@intel.com>; chris@chris-wilson.co.uk; Ausmus, James <james.ausmus@intel.com>; Nikula, Jani <jani.nikula@intel.com>; Pandey, Hariom <hariom.pandey@intel.com>; Roper, Matthew D <matthew.d.roper@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection



> On Oct 9, 2020, at 1:31 AM, K, SrinivasX <srinivasx.k@intel.com> wrote:
> 
> Hi Rodrigo,
> 
> How do we get W/A and rc6 changes in, do you have any details?

I told based on what I was seeing on https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html?
focusing on the issues that are exclusively for ehl and not happening on other platforms.

It looks like workarounds are fine there now. so I'm not sure if it was sporadic thing that day.

for the rc6 there are a few testcases failing around it:
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_pm_rc6_residency@rc6-fence.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_pm_rc6_residency@rc6-idle.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_selftest@live@gt_pm.html#dmesg-warnings415

> 
> Thanks,
> Srinivas
> 
> -----Original Message-----
> From: Souza, Jose <jose.souza@intel.com>
> Sent: 06 October 2020 23:33
> To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; chris@chris-wilson.co.uk
> Cc: Ausmus, James <james.ausmus@intel.com>; Nikula, Jani 
> <jani.nikula@intel.com>; Pandey, Hariom <hariom.pandey@intel.com>; 
> Roper, Matthew D <matthew.d.roper@intel.com>; 
> intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; K, 
> SrinivasX <srinivasx.k@intel.com>; Surendrakumar Upadhyay, TejaskumarX 
> <tejaskumarx.surendrakumar.upadhyay@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove 
> require_force_probe protection
> 
> On Tue, 2020-10-06 at 10:55 -0700, Vivi, Rodrigo wrote:
>> 
>>> On Oct 6, 2020, at 10:48 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>> 
>>> Quoting Souza, Jose (2020-10-06 18:46:45)
>>>> +Rodrigo and Jani
>>>> 
>>>> On Tue, 2020-10-06 at 14:56 +0000, Kamati Srinivas wrote:
>>>>> Removing force probe protection from EHL platform. Did not observe 
>>>>> warnings, errors, flickering or any visual defects while doing 
>>>>> ordinary tasks like browsing and editing documents in a two 
>>>>> monitor setup.
>>>> 
>>>> One of the requirements was also to have CI BAT all green and 
>>>> shards as green is possible but EHL don't show up in CI results, we actually have one single EHL machine in CI but I guess it is not able to run all tests that shards do:
>>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/filelist.html
>>> 
>>> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html
>> 
>> we are really close to that point. We just need to fix some w/a and
>> rc6 issues before applying this change.
>> 
>>> -Chris
>> 
> 
> Huum okay we have drm-tip results for EHL but if someone sends a patch that breaks EHL it will not be caught in pre-merge testing.
> 


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[Rodrigo Vivi]

I just checked the CI picture and it looks much better indeed.

Only bad case being the gt_pm, which is also failing on other platforms.

So,

Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>



On Thu, Oct 15, 2020 at 08:41:32AM +0000, K, SrinivasX wrote:
> Hi Hariom,
> 
> With Sunil's help was able to see EHL achieving rc6 state. 
> Verified from sys entries, under no load to gpu rc6_residency_ms counter is changing.
> Also ran all the Rodrigo mention tests and I see them passing. But with i915_selftest dmesg warnings are still seen.
> 
> Thanks,
> Srinivas
> 
> -----Original Message-----
> From: Pandey, Hariom <hariom.pandey@intel.com> 
> Sent: 09 October 2020 23:39
> To: K, SrinivasX <srinivasx.k@intel.com>
> Cc: Souza, Jose <jose.souza@intel.com>; chris@chris-wilson.co.uk; Ausmus, James <james.ausmus@intel.com>; Nikula, Jani <jani.nikula@intel.com>; Roper, Matthew D <matthew.d.roper@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>
> Subject: RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection
> 
> Hi Srinivas,
> 
> Take Sunil's help who has recently validated RC6 on EHL DRM tip and found to be passing. If the WA were sporadically failing and if you confirm that RC6 is passing, this patch can be proceeded with. 
> 
> Thanks
> Hariom Pandey
> 
> -----Original Message-----
> From: Vivi, Rodrigo <rodrigo.vivi@intel.com> 
> Sent: Friday, October 9, 2020 7:09 PM
> To: K, SrinivasX <srinivasx.k@intel.com>
> Cc: Souza, Jose <jose.souza@intel.com>; chris@chris-wilson.co.uk; Ausmus, James <james.ausmus@intel.com>; Nikula, Jani <jani.nikula@intel.com>; Pandey, Hariom <hariom.pandey@intel.com>; Roper, Matthew D <matthew.d.roper@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection
> 
> 
> 
> > On Oct 9, 2020, at 1:31 AM, K, SrinivasX <srinivasx.k@intel.com> wrote:
> > 
> > Hi Rodrigo,
> > 
> > How do we get W/A and rc6 changes in, do you have any details?
> 
> I told based on what I was seeing on https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html?
> focusing on the issues that are exclusively for ehl and not happening on other platforms.
> 
> It looks like workarounds are fine there now. so I'm not sure if it was sporadic thing that day.
> 
> for the rc6 there are a few testcases failing around it:
> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_pm_rc6_residency@rc6-fence.html
> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_pm_rc6_residency@rc6-idle.html
> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_selftest@live@gt_pm.html#dmesg-warnings415
> 
> > 
> > Thanks,
> > Srinivas
> > 
> > -----Original Message-----
> > From: Souza, Jose <jose.souza@intel.com>
> > Sent: 06 October 2020 23:33
> > To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; chris@chris-wilson.co.uk
> > Cc: Ausmus, James <james.ausmus@intel.com>; Nikula, Jani 
> > <jani.nikula@intel.com>; Pandey, Hariom <hariom.pandey@intel.com>; 
> > Roper, Matthew D <matthew.d.roper@intel.com>; 
> > intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; K, 
> > SrinivasX <srinivasx.k@intel.com>; Surendrakumar Upadhyay, TejaskumarX 
> > <tejaskumarx.surendrakumar.upadhyay@intel.com>
> > Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove 
> > require_force_probe protection
> > 
> > On Tue, 2020-10-06 at 10:55 -0700, Vivi, Rodrigo wrote:
> >> 
> >>> On Oct 6, 2020, at 10:48 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >>> 
> >>> Quoting Souza, Jose (2020-10-06 18:46:45)
> >>>> +Rodrigo and Jani
> >>>> 
> >>>> On Tue, 2020-10-06 at 14:56 +0000, Kamati Srinivas wrote:
> >>>>> Removing force probe protection from EHL platform. Did not observe 
> >>>>> warnings, errors, flickering or any visual defects while doing 
> >>>>> ordinary tasks like browsing and editing documents in a two 
> >>>>> monitor setup.
> >>>> 
> >>>> One of the requirements was also to have CI BAT all green and 
> >>>> shards as green is possible but EHL don't show up in CI results, we actually have one single EHL machine in CI but I guess it is not able to run all tests that shards do:
> >>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/filelist.html
> >>> 
> >>> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html
> >> 
> >> we are really close to that point. We just need to fix some w/a and
> >> rc6 issues before applying this change.
> >> 
> >>> -Chris
> >> 
> > 
> > Huum okay we have drm-tip results for EHL but if someone sends a patch that breaks EHL it will not be caught in pre-merge testing.
> > 
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[Chris Wilson]

Quoting Rodrigo Vivi (2020-10-19 19:29:36)
> 
> I just checked the CI picture and it looks much better indeed.
> 
> Only bad case being the gt_pm, which is also failing on other platforms.

Not nearly in the same manner. CI is indicating that there is no RC6
entry and no power saving at all; neither in the selftests nor visible
from userspace. That is a critical battery eating bug.

If there's a patch to fix it for ehl and jsl, send it to CI for proving.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[Vivi, Rodrigo]

> On Oct 27, 2020, at 11:49 PM, Pandey, Hariom <hariom.pandey@intel.com> wrote:
> 
> Hi Chris,
>  
> Awaiting your kind response here…

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9208/fi-ehl-1/igt@i915_selftest@live@gt_pm.html
"Did not enter RC6!"

Chris already told that we need to get RC6 working on CI.
If we need BIOS update or machine replacement there we need to work with CI team to make that happen.

>  
> Thanks
> Hariom Pandey
>  
> From: Pandey, Hariom 
> Sent: Tuesday, October 20, 2020 9:28 PM
> To: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ausmus, James <james.ausmus@intel.com>; Nikula, Jani <jani.nikula@intel.com>; intel-gfx@ <lists.freedesktop.org intel-gfx@lists.freedesktop.org>; Souza, Jose <jose.souza@intel.com>; dri-devel@ <lists.freedesktop.org dri-devel@lists.freedesktop.org>; Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay@intel.com>; K, SrinivasX <srinivasx.k@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; Meena, Mahesh <Mahesh.Meena@intel.com>
> Subject: RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection
>  
> Hi Chris,
>  
> We have run RC6 test cases as recently as 4 days ago on EHL and they have passed. Below are the pass log links & attached email has the DRM/IGT tag where they have passed. We are finding that the “EHL BAT setup” is not upto date in terms of Silicon & BIOS which we are working to upgrade. But just for that, should we block this patch? Just trying to understand as there is no inherent or latent RC6 issue anymore.
>  
> 	• igt@i915_pm_rc6_residency@rc6-accuracy --- PASS - Log
> 	• igt@i915_pm_rc6_residency@rc6-fence --- PASS – Log
> 	• igt@i915_pm_rc6_residency@rc6-idle --- PASS - Log
> 	• igt@perf@rc6-disable --- PASS - Log
> 	• igt@perf_pmu@rc6 --- PASS - Log
> 	• igt@perf_pmu@rc6-runtime-pm --- PASS - Log
> 	• igt@perf_pmu@rc6-runtime-pm-long --- PASS – Log
>  
>  
> Thanks
> Hariom Pandey
>  
> > -----Original Message-----
> > From: Chris Wilson <chris@chris-wilson.co.uk>
> > Sent: Tuesday, October 20, 2020 12:04 AM
> > To: K, SrinivasX <srinivasx.k@intel.com>; Vivi, Rodrigo
> > <rodrigo.vivi@intel.com>
> > Cc: Pandey, Hariom <hariom.pandey@intel.com>; Ausmus, James
> > <james.ausmus@intel.com>; Nikula, Jani <jani.nikula@intel.com>; intel-gfx@
> > <lists.freedesktop.org intel-gfx@lists.freedesktop.org>; Souza, Jose
> > <jose.souza@intel.com>; dri-devel@ <lists.freedesktop.org dri-
> > devel@lists.freedesktop.org>; Surendrakumar Upadhyay, TejaskumarX
> > <tejaskumarx.surendrakumar.upadhyay@intel.com>
> > Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe
> > protection
> > 
> > Quoting Rodrigo Vivi (2020-10-19 19:29:36)
> > >
> > > I just checked the CI picture and it looks much better indeed.
> > >
> > > Only bad case being the gt_pm, which is also failing on other platforms.
> > 
> > Not nearly in the same manner. CI is indicating that there is no RC6 entry and
> > no power saving at all; neither in the selftests nor visible from userspace.
> > That is a critical battery eating bug.
> > 
> > If there's a patch to fix it for ehl and jsl, send it to CI for proving.
> > -Chris
> <Mail Attachment.eml>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[Pandey, Hariom]

Ok, I have initiated the steps to upgrade the CI machine's silicon & BIOS.

Thanks
Hariom Pandey

> -----Original Message-----
> From: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> Sent: Wednesday, October 28, 2020 5:24 PM
> To: Pandey, Hariom <hariom.pandey@intel.com>; Szwichtenberg, Radoslaw
> <radoslaw.szwichtenberg@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>; Ausmus, James
> <james.ausmus@intel.com>; Nikula, Jani <jani.nikula@intel.com>; intel-
> gfx@lists.freedesktop.org; Souza, Jose <jose.souza@intel.com>; dri-devel
> <dri-devel@lists.freedesktop.org>; Surendrakumar Upadhyay, TejaskumarX
> <tejaskumarx.surendrakumar.upadhyay@intel.com>; K, SrinivasX
> <srinivasx.k@intel.com>; Meena, Mahesh <mahesh.meena@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe
> protection
> 
> 
> 
> > On Oct 27, 2020, at 11:49 PM, Pandey, Hariom
> <hariom.pandey@intel.com> wrote:
> >
> > Hi Chris,
> >
> > Awaiting your kind response here…
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9208/fi-ehl-
> 1/igt@i915_selftest@live@gt_pm.html
> "Did not enter RC6!"
> 
> Chris already told that we need to get RC6 working on CI.
> If we need BIOS update or machine replacement there we need to work with
> CI team to make that happen.
> 
> >
> > Thanks
> > Hariom Pandey
> >
> > From: Pandey, Hariom
> > Sent: Tuesday, October 20, 2020 9:28 PM
> > To: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Ausmus, James <james.ausmus@intel.com>; Nikula, Jani
> > <jani.nikula@intel.com>; intel-gfx@ <lists.freedesktop.org
> > intel-gfx@lists.freedesktop.org>; Souza, Jose <jose.souza@intel.com>;
> > dri-devel@ <lists.freedesktop.org dri-devel@lists.freedesktop.org>;
> > Surendrakumar Upadhyay, TejaskumarX
> > <tejaskumarx.surendrakumar.upadhyay@intel.com>; K, SrinivasX
> > <srinivasx.k@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> > Meena, Mahesh <Mahesh.Meena@intel.com>
> > Subject: RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove
> > require_force_probe protection
> >
> > Hi Chris,
> >
> > We have run RC6 test cases as recently as 4 days ago on EHL and they have
> passed. Below are the pass log links & attached email has the DRM/IGT tag
> where they have passed. We are finding that the “EHL BAT setup” is not upto
> date in terms of Silicon & BIOS which we are working to upgrade. But just for
> that, should we block this patch? Just trying to understand as there is no
> inherent or latent RC6 issue anymore.
> >
> > • igt@i915_pm_rc6_residency@rc6-accuracy --- PASS - Log •
> > igt@i915_pm_rc6_residency@rc6-fence --- PASS – Log •
> > igt@i915_pm_rc6_residency@rc6-idle --- PASS - Log •
> > igt@perf@rc6-disable --- PASS - Log • igt@perf_pmu@rc6 --- PASS - Log
> > • igt@perf_pmu@rc6-runtime-pm --- PASS - Log •
> > igt@perf_pmu@rc6-runtime-pm-long --- PASS – Log
> >
> >
> > Thanks
> > Hariom Pandey
> >
> > > -----Original Message-----
> > > From: Chris Wilson <chris@chris-wilson.co.uk>
> > > Sent: Tuesday, October 20, 2020 12:04 AM
> > > To: K, SrinivasX <srinivasx.k@intel.com>; Vivi, Rodrigo
> > > <rodrigo.vivi@intel.com>
> > > Cc: Pandey, Hariom <hariom.pandey@intel.com>; Ausmus, James
> > > <james.ausmus@intel.com>; Nikula, Jani <jani.nikula@intel.com>;
> > > intel-gfx@ <lists.freedesktop.org intel-gfx@lists.freedesktop.org>;
> > > Souza, Jose <jose.souza@intel.com>; dri-devel@
> > > <lists.freedesktop.org dri- devel@lists.freedesktop.org>;
> > > Surendrakumar Upadhyay, TejaskumarX
> > > <tejaskumarx.surendrakumar.upadhyay@intel.com>
> > > Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove
> > > require_force_probe protection
> > >
> > > Quoting Rodrigo Vivi (2020-10-19 19:29:36)
> > > >
> > > > I just checked the CI picture and it looks much better indeed.
> > > >
> > > > Only bad case being the gt_pm, which is also failing on other platforms.
> > >
> > > Not nearly in the same manner. CI is indicating that there is no RC6
> > > entry and no power saving at all; neither in the selftests nor visible from
> userspace.
> > > That is a critical battery eating bug.
> > >
> > > If there's a patch to fix it for ehl and jsl, send it to CI for proving.
> > > -Chris
> > <Mail Attachment.eml>
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[Chris Wilson]

Quoting Pandey, Hariom (2020-10-28 11:55:04)
> Ok, I have initiated the steps to upgrade the CI machine's silicon & BIOS.

The single ehl we have in CI is still failing to enter rc6, both in the
selftest and runtime testing. And I note that RAPL doesn't recognise it,
so it doesn't report the power consumption.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel