From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAB61C2BB86 for ; Mon, 13 Apr 2020 13:18:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC0A620936 for ; Mon, 13 Apr 2020 13:18:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC0A620936 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2202589EB8; Mon, 13 Apr 2020 13:18:08 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 7003B89E3E for ; Mon, 13 Apr 2020 13:18:06 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E2F131FB; Mon, 13 Apr 2020 06:18:05 -0700 (PDT) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AC2583F68F; Mon, 13 Apr 2020 06:18:04 -0700 (PDT) Subject: Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Rob Herring , Tomeu Vizoso , Alyssa Rosenzweig , Viresh Kumar , Nishanth Menon , Stephen Boyd References: <20200411200632.4045-1-peron.clem@gmail.com> <20200411200632.4045-2-peron.clem@gmail.com> From: Steven Price Message-ID: Date: Mon, 13 Apr 2020 14:18:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200411200632.4045-2-peron.clem@gmail.com> Content-Language: en-GB X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMTEvMDQvMjAyMCAyMTowNiwgQ2zDqW1lbnQgUMOpcm9uIHdyb3RlOgo+IE9QUCB0YWJsZSBj YW4gZGVmaW5lZCBib3RoIGZyZXF1ZW5jeSBhbmQgdm9sdGFnZS4KPiAKPiBSZWdpc3RlciB0aGUg bWFsaSByZWd1bGF0b3IgaWYgaXQgZXhpc3QuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2zDqW1lbnQg UMOpcm9uIDxwZXJvbi5jbGVtQGdtYWlsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9w YW5mcm9zdC9wYW5mcm9zdF9kZXZmcmVxLmMgfCAzNCArKysrKysrKysrKysrKysrKystLS0KPiAg IGRyaXZlcnMvZ3B1L2RybS9wYW5mcm9zdC9wYW5mcm9zdF9kZXZpY2UuaCAgfCAgMSArCj4gICAy IGZpbGVzIGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9wYW5mcm9zdC9wYW5mcm9zdF9kZXZmcmVxLmMgYi9k cml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZGV2ZnJlcS5jCj4gaW5kZXggNjI1NDFm NGVkZDgxLi4yZGM4ZTIzNTUzNTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3BhbmZy b3N0L3BhbmZyb3N0X2RldmZyZXEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5mcm9zdC9w YW5mcm9zdF9kZXZmcmVxLmMKPiBAQCAtNzgsMTIgKzc4LDI2IEBAIGludCBwYW5mcm9zdF9kZXZm cmVxX2luaXQoc3RydWN0IHBhbmZyb3N0X2RldmljZSAqcGZkZXYpCj4gICAJc3RydWN0IGRldmlj ZSAqZGV2ID0gJnBmZGV2LT5wZGV2LT5kZXY7Cj4gICAJc3RydWN0IGRldmZyZXEgKmRldmZyZXE7 Cj4gICAJc3RydWN0IHRoZXJtYWxfY29vbGluZ19kZXZpY2UgKmNvb2xpbmc7Cj4gKwljb25zdCBj aGFyICptYWxpID0gIm1hbGkiOwo+ICsJc3RydWN0IG9wcF90YWJsZSAqb3BwX3RhYmxlID0gTlVM TDsKPiArCj4gKwkvKiBSZWd1bGF0b3IgaXMgb3B0aW9uYWwgKi8KPiArCW9wcF90YWJsZSA9IGRl dl9wbV9vcHBfc2V0X3JlZ3VsYXRvcnMoZGV2LCAmbWFsaSwgMSk7CgpUaGlzIGxvb2tzIGxpa2Ug aXQgYXBwbGllcyBiZWZvcmUgM2UxMzk5YmNjZjUxICgiZHJtL3BhbmZyb3N0OiBBZGQgCnN1cHBv cnQgZm9yIG11bHRpcGxlIHJlZ3VsYXRvcnMiKSB3aGljaCBpcyBjdXJyZW50bHkgaW4gZHJtLW1p c2MtbmV4dCAKKGFuZCBsaW51eC1uZXh0KS4gWW91IHdhbnQgc29tZXRoaW5nIG1vcmUgbGlrZToK CiAgICAgb3BwX3RhYmxlID0gZGV2X3BtX29wcF9zZXRfcmVndWxhdG9ycyhkZXYsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwZmRldi0+Y29tcC0+c3VwcGx5X25h bWVzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGZkZXYtPmNv bXAtPm51bV9zdXBwbGllcyk7CgpPdGhlcndpc2UgYSBwbGF0Zm9ybSB3aXRoIG11bHRpcGxlIHJl Z3VsYXRvcnMgd29uJ3Qgd29yayBjb3JyZWN0bHkuCgpBbHNvIHJ1bm5pbmcgb24gbXkgZmlyZWZs eSAoUkszMjg4KSBib2FyZCBJIGdldCB0aGUgZm9sbG93aW5nIHdhcm5pbmc6CgogICAgZGVidWdm czogRGlyZWN0b3J5ICdmZmEzMDAwMC5ncHUtbWFsaScgd2l0aCBwYXJlbnQgJ3ZkZF9ncHUnIGFs cmVhZHkgCnByZXNlbnQhCgpUaGlzIGlzIGR1ZSB0byB0aGUgcmVndWxhdG9yIGRlYnVnZnMgZW50 cmllcyBnZXR0aW5nIGNyZWF0ZWQgdHdpY2UgKG9uY2UgCmluIHBhbmZyb3N0X3JlZ3VsYXRvcl9p bml0KCkgYW5kIG9uY2UgaGVyZSkuCgpJIGhhdmUgYmVlbiB0YWtpbmcgYSBsb29rIGF0IGRvaW5n IHRoZSBzYW1lIHRoaW5nIChJIHBpY2tlZCB1cCBNYXJ0aW4gCkJsdW1lbnN0aW5nbCdzIHBhdGNo IHNlcmllc1sxXSksIGJ1dCBoYXZlbid0IGhhZCBtdWNoIHRpbWUgdG8gZm9jdXMgb24gCnRoaXMg cmVjZW50bHkuCgpUaGFua3MsCgpTdGV2ZQoKWzFdIApodHRwczovL2xvcmUua2VybmVsLm9yZy9k cmktZGV2ZWwvMjAyMDAxMTIwMDE2MjMuMjEyMTIyNy0xLW1hcnRpbi5ibHVtZW5zdGluZ2xAZ29v Z2xlbWFpbC5jb20vCgoKPiArCWlmIChJU19FUlIob3BwX3RhYmxlKSkgewo+ICsJCXJldCA9IFBU Ul9FUlIob3BwX3RhYmxlKTsKPiArCQlpZiAocmV0ICE9IC1FTk9ERVYpIHsKPiArCQkJRFJNX0RF Vl9FUlJPUihkZXYsICJGYWlsZWQgdG8gc2V0IHJlZ3VsYXRvcjogJWRcbiIsIHJldCk7Cj4gKwkJ CXJldHVybiByZXQ7Cj4gKwkJfQo+ICsJfQo+ICsJcGZkZXYtPmRldmZyZXEub3BwX3RhYmxlID0g b3BwX3RhYmxlOwo+ICAgCj4gICAJcmV0ID0gZGV2X3BtX29wcF9vZl9hZGRfdGFibGUoZGV2KTsK PiAtCWlmIChyZXQgPT0gLUVOT0RFVikgLyogT3B0aW9uYWwsIGNvbnRpbnVlIHdpdGhvdXQgZGV2 ZnJlcSAqLwo+IC0JCXJldHVybiAwOwo+IC0JZWxzZSBpZiAocmV0KQo+IC0JCXJldHVybiByZXQ7 Cj4gKwlpZiAocmV0KSB7Cj4gKwkJaWYgKHJldCA9PSAtRU5PREVWKSAvKiBPcHRpb25hbCwgY29u dGludWUgd2l0aG91dCBkZXZmcmVxICovCj4gKwkJCXJldCA9IDA7Cj4gKwkJZ290byBlcnJfb3Bw X3JlZzsKPiArCX0KPiAgIAo+ICAgCXBhbmZyb3N0X2RldmZyZXFfcmVzZXQocGZkZXYpOwo+ICAg Cj4gQEAgLTExOSw2ICsxMzMsMTIgQEAgaW50IHBhbmZyb3N0X2RldmZyZXFfaW5pdChzdHJ1Y3Qg cGFuZnJvc3RfZGV2aWNlICpwZmRldikKPiAgIGVycl9vcHA6Cj4gICAJZGV2X3BtX29wcF9vZl9y ZW1vdmVfdGFibGUoZGV2KTsKPiAgIAo+ICtlcnJfb3BwX3JlZzoKPiArCWlmIChwZmRldi0+ZGV2 ZnJlcS5vcHBfdGFibGUpIHsKPiArCQlkZXZfcG1fb3BwX3B1dF9yZWd1bGF0b3JzKHBmZGV2LT5k ZXZmcmVxLm9wcF90YWJsZSk7Cj4gKwkJcGZkZXYtPmRldmZyZXEub3BwX3RhYmxlID0gTlVMTDsK PiArCX0KPiArCj4gICAJcmV0dXJuIHJldDsKPiAgIH0KPiAgIAo+IEBAIC0xMjYsNyArMTQ2LDEz IEBAIHZvaWQgcGFuZnJvc3RfZGV2ZnJlcV9maW5pKHN0cnVjdCBwYW5mcm9zdF9kZXZpY2UgKnBm ZGV2KQo+ICAgewo+ICAgCWlmIChwZmRldi0+ZGV2ZnJlcS5jb29saW5nKQo+ICAgCQlkZXZmcmVx X2Nvb2xpbmdfdW5yZWdpc3RlcihwZmRldi0+ZGV2ZnJlcS5jb29saW5nKTsKPiArCj4gICAJZGV2 X3BtX29wcF9vZl9yZW1vdmVfdGFibGUoJnBmZGV2LT5wZGV2LT5kZXYpOwo+ICsKPiArCWlmIChw ZmRldi0+ZGV2ZnJlcS5vcHBfdGFibGUpIHsKPiArCQlkZXZfcG1fb3BwX3B1dF9yZWd1bGF0b3Jz KHBmZGV2LT5kZXZmcmVxLm9wcF90YWJsZSk7Cj4gKwkJcGZkZXYtPmRldmZyZXEub3BwX3RhYmxl ID0gTlVMTDsKPiArCX0KPiAgIH0KPiAgIAo+ICAgdm9pZCBwYW5mcm9zdF9kZXZmcmVxX3Jlc3Vt ZShzdHJ1Y3QgcGFuZnJvc3RfZGV2aWNlICpwZmRldikKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL3BhbmZyb3N0L3BhbmZyb3N0X2RldmljZS5oIGIvZHJpdmVycy9ncHUvZHJtL3BhbmZy b3N0L3BhbmZyb3N0X2RldmljZS5oCj4gaW5kZXggMDY3MTM4MTFiOTJjLi5mNmIwYzc3OWRmZTUg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3BhbmZyb3N0L3BhbmZyb3N0X2RldmljZS5o Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3BhbmZyb3N0L3BhbmZyb3N0X2RldmljZS5oCj4gQEAg LTg2LDYgKzg2LDcgQEAgc3RydWN0IHBhbmZyb3N0X2RldmljZSB7Cj4gICAJc3RydWN0IHsKPiAg IAkJc3RydWN0IGRldmZyZXEgKmRldmZyZXE7Cj4gICAJCXN0cnVjdCB0aGVybWFsX2Nvb2xpbmdf ZGV2aWNlICpjb29saW5nOwo+ICsJCXN0cnVjdCBvcHBfdGFibGUgKm9wcF90YWJsZTsKPiAgIAkJ a3RpbWVfdCBidXN5X3RpbWU7Cj4gICAJCWt0aW1lX3QgaWRsZV90aW1lOwo+ICAgCQlrdGltZV90 IHRpbWVfbGFzdF91cGRhdGU7Cj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK