From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DFFCC04A68 for ; Thu, 28 Jul 2022 12:07:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1377498E45; Thu, 28 Jul 2022 12:07:45 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89D32977A3 for ; Thu, 28 Jul 2022 12:07:40 +0000 (UTC) Received: from [192.168.1.111] (91-158-154-79.elisa-laajakaista.fi [91.158.154.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F2EE56D; Thu, 28 Jul 2022 14:07:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1659010059; bh=NYs1CegJfOdzTMrWzKcwsScJu3f3bNBSqgfmlYee5Ak=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=j1bGehUMRAMkTOMtefUeFkONS1rJvY3Q2Xxaq0dKdqYuxQftsyJ6NExvMVJ6HvPtF tKvYMJGKVWbT8/2NOzCD4B3Aa2hLI5rWynCcCCP5g7oCoocWKK5fm3OFDV7pIk1i6g 4sTnfVgLdjnIVUvrq/p8qDCbyk7HKQr4lrKNPBc0= Message-ID: Date: Thu, 28 Jul 2022 15:07:35 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/8] drm/tidss: Add support for DSS port properties Content-Language: en-US To: Aradhya Bhatia , Jyri Sarha , Rob Herring , David Airlie , Daniel Vetter , Krzysztof Kozlowski References: <20220719080845.22122-1-a-bhatia1@ti.com> <20220719080845.22122-4-a-bhatia1@ti.com> From: Tomi Valkeinen In-Reply-To: <20220719080845.22122-4-a-bhatia1@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Devicetree List , Vignesh Raghavendra , Devarsh Thakkar , Linux Kernel List , DRI Development List , Darren Etheridge , Rahul T R , Krunal Bhargav Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 19/07/2022 11:08, Aradhya Bhatia wrote: > Add support to enable and read the dss port properties. > > The "ti,oldi-mode" property indicates the tidss driver how many OLDI > TXes are enabled as well as which mode do they need to be connected in. > > The "ti,rgb565_to_888" is a special property that forces the DSS to > output 16bit RGB565 data to a 24bit RGB888 bridge. This property can be > used when the bridge does not explicity support RGB565. > > Signed-off-by: Aradhya Bhatia I think it would be good if you would split the patches that contain both OLDI and rgb565 changes, and arrange the series so that you first have patches that add the rgb565 (dt and driver), and after that, the OLDI changes. They are fully separate things, and makes understanding the changes a bit easier. Tomi