From: "Michel Dänzer" <michel.daenzer@mailbox.org>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Xinhui Pan" <Xinhui.Pan@amd.com>
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: Add build directory to include path
Date: Thu, 14 Apr 2022 09:37:07 +0200 [thread overview]
Message-ID: <ca5ca8ab-9c48-8d81-2dd6-fbdfface6519@mailbox.org> (raw)
In-Reply-To: <f425b789-5081-fa70-555f-7553d7cc5bd5@gmail.com>
On 2022-04-14 08:24, Christian König wrote:
> Am 13.04.22 um 18:14 schrieb Michel Dänzer:
>> From: Michel Dänzer <mdaenzer@redhat.com>
>>
>> Fixes compile errors with out-of-tree builds, e.g.
>>
>> ../drivers/gpu/drm/radeon/r420.c:38:10: fatal error: r420_reg_safe.h: No such file or directory
>> 38 | #include "r420_reg_safe.h"
>> | ^~~~~~~~~~~~~~~~~
>
>
> Well stuff like that usually points to a broken build environment.
Just a separate build directory. Specifically, I'm hitting the errors with
make -C build-amd64 M=drivers/gpu/drm
Generated headers such as r420_reg_safe.h reside in the build directory, so source files in the source directory can't find them without an explicit search path. Are you saying that should get added automagically somehow?
FWIW, this is pretty common in the kernel according to git grep.
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer
next prev parent reply other threads:[~2022-04-14 7:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 16:14 [PATCH] drm/radeon: Add build directory to include path Michel Dänzer
2022-04-14 6:24 ` Christian König
2022-04-14 7:37 ` Michel Dänzer [this message]
2022-04-14 8:44 ` Christian König
2022-04-14 8:56 ` Michel Dänzer
2022-04-14 13:34 ` Alex Deucher
2022-04-14 13:49 ` Michel Dänzer
2022-04-14 15:04 ` Masahiro Yamada
2022-04-14 16:57 ` Michel Dänzer
2022-06-15 8:35 ` Michel Dänzer
2022-06-18 22:08 ` Masahiro Yamada
2022-06-19 16:22 ` Ernst Sjöstrand
2022-06-20 7:42 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca5ca8ab-9c48-8d81-2dd6-fbdfface6519@mailbox.org \
--to=michel.daenzer@mailbox.org \
--cc=Xinhui.Pan@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).