Re: [PATCH 07/21] drm/hisilicon/kirin: Use GEM CMA object functions

From: Thomas Zimmermann <tzimmermann@suse.de>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: alexandre.belloni@bootlin.com, linux-aspeed@lists.ozlabs.org,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Dave Airlie" <airlied@linux.ie>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"ML dri-devel" <dri-devel@lists.freedesktop.org>,
	nicolas.ferre@microchip.com,
	"Paul Cercueil" <paul@crapouillou.net>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Mihail Atanassov" <mihail.atanassov@arm.com>,
	"Sam Ravnborg" <sam@ravnborg.org>, "Marek Vašut" <marex@denx.de>,
	khilman@baylibre.com, "Alexey Brodkin" <abrodkin@synopsys.com>,
	"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
	"Xinliang Liu" <xinliang.liu@linaro.org>,
	ludovic.desroches@microchip.com,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"james qian wang (Arm Technology China)"
	<james.qian.wang@arm.com>, "NXP Linux Team" <linux-imx@nxp.com>,
	joel@jms.id.au, "Alexandre Torgue" <alexandre.torgue@st.com>,
	"Chen Feng" <puck.chen@hisilicon.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Alison Wang" <alison.wang@nxp.com>, "Jyri Sarha" <jsarha@ti.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Vincent Abriou" <vincent.abriou@st.com>,
	LAKML <linux-arm-kernel@lists.infradead.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	bbrezillon@kernel.org, andrew@aj.id.au,
	"Philippe Cornu" <philippe.cornu@st.com>,
	"Yannick Fertre" <yannick.fertre@st.com>,
	"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Rongrong Zou" <zourongrong@gmail.com>,
	"Shawn Guo" <shawnguo@kernel.org>
Subject: Re: [PATCH 07/21] drm/hisilicon/kirin: Use GEM CMA object functions
Date: Mon, 25 May 2020 14:41:54 +0200	[thread overview]
Message-ID: <ccee78e2-8930-2de6-0b7c-0f1ad1e636f8@suse.de> (raw)
In-Reply-To: <CACvgo51cYh4iLKEfrLSbgOGQM4=ojsBq54gW9VJBPoX+p04o+g@mail.gmail.com>

[-- Attachment #1.1.1: Type: text/plain, Size: 2335 bytes --]

Hi Emil

Am 22.05.20 um 20:11 schrieb Emil Velikov:
> Hi Thomas,
> 
> On Fri, 22 May 2020 at 14:53, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>>
>> The kirin driver uses the default implementation for CMA functions; except
>> for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets
>> these defaults and .dumb_create in struct drm_driver. All remaining
>> operations are provided by CMA GEM object functions.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 12 +-----------
>>  1 file changed, 1 insertion(+), 11 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
>> index c339e632522a9..b1ffd7d43e562 100644
>> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
>> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
>> @@ -921,17 +921,7 @@ DEFINE_DRM_GEM_CMA_FOPS(ade_fops);
>>  static struct drm_driver ade_driver = {
>>         .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
>>         .fops = &ade_fops,
>> -       .gem_free_object_unlocked = drm_gem_cma_free_object,
>> -       .gem_vm_ops = &drm_gem_cma_vm_ops,
>> -       .dumb_create = drm_gem_cma_dumb_create_internal,
> 
> This doesn't seem right. The _internal documentation explicitly says
> that this should _not_ be used as .dumb_create. Instead drivers should
> use it to implement their callback.
> 
> Since it yields the same result as drm_gem_cma_dumb_create we can use
> the default macro below.

I noticed this and thought that the driver authors probably had their
reasons. Changing the driver to the default macro is probably still a
good idea.

Best regards
Thomas

> 
> Weather to the .dumb_create in separate patch, or squash it here -
> I'll leave to you.
> In case of the latter, please mentioned it in the commit message.
> 
> -Emil
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel