From: Lukasz Luba <lukasz.luba@arm.com>
To: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-imx@nxp.com
Cc: nm@ti.com, juri.lelli@redhat.com, peterz@infradead.org,
viresh.kumar@linaro.org, liviu.dudau@arm.com,
bjorn.andersson@linaro.org, bsegall@google.com,
Morten.Rasmussen@arm.com, amit.kucheria@verdurent.com,
lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org,
khilman@kernel.org, daniel.lezcano@linaro.org,
steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com,
mgorman@suse.de, rui.zhang@intel.com,
alyssa.rosenzweig@collabora.com, orjan.eide@arm.com,
b.zolnierkie@samsung.com, s.hauer@pengutronix.de,
rostedt@goodmis.org, matthias.bgg@gmail.com,
Dietmar.Eggemann@arm.com, airlied@linux.ie, javi.merino@arm.com,
tomeu.vizoso@collabora.com, qperret@google.com, sboyd@kernel.org,
rjw@rjwysocki.net, agross@kernel.org, kernel@pengutronix.de,
sudeep.holla@arm.com, patrick.bellasi@matbug.net,
shawnguo@kernel.org
Subject: Re: [PATCH v3 1/4] PM / EM: add devices to Energy Model
Date: Tue, 25 Feb 2020 10:56:34 +0000 [thread overview]
Message-ID: <cf0d6bf7-ad87-4fbf-0392-646d5aa6d52b@arm.com> (raw)
In-Reply-To: <4ac6a187-1a09-335d-5c05-bf810ff81aaa@infradead.org>
Hi Randy,
Thank you for taking the time to look into this patch.
On 2/22/20 12:42 AM, Randy Dunlap wrote:
> Hi,
> One minor nit. Please see inline:
>
> On 2/21/20 11:47 AM, Lukasz Luba wrote:
>> Add support of other devices into the Energy Model framework not only the
>> CPUs. Change the interface to be more unified which can handle other
>> devices as well.
>>
>> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
>> ---
>> Documentation/power/energy-model.rst | 133 ++++----
>>
>> diff --git a/Documentation/power/energy-model.rst b/Documentation/power/energy-model.rst
>> index 90a345d57ae9..7576820664e5 100644
>> --- a/Documentation/power/energy-model.rst
>> +++ b/Documentation/power/energy-model.rst
>
>> @@ -85,13 +89,20 @@ API.
>> 2.3 Accessing performance domains
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> +There is two API functions which provide the access to the energy model:
>
> There are two
Indeed a mistake, I will fix it.
>
>> +em_cpu_get() which takes CPU id as an argument and em_pd_get() with device
>> +pointer as an argument. It depends on the subsystem which interface it is
>> +going to use, but in case of CPU devices both functions return the same
>> +performance domain.
>> +
>
>
> cheers.
>
Regards,
Lukasz
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-26 8:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 19:47 [PATCH v3 0/4] Add support for devices in the Energy Model Lukasz Luba
2020-02-21 19:47 ` [PATCH v3 1/4] PM / EM: add devices to " Lukasz Luba
2020-02-22 0:42 ` Randy Dunlap
2020-02-25 10:56 ` Lukasz Luba [this message]
2020-02-21 19:47 ` [PATCH v3 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() Lukasz Luba
2020-02-21 19:47 ` [PATCH v3 3/4] thermal: devfreq_cooling: Refactor code and switch to use Energy Model Lukasz Luba
2020-02-21 19:47 ` [PATCH v3 4/4] drm/panfrost: Register to the Energy Model with devfreq device Lukasz Luba
2020-02-25 20:57 ` Rob Herring
2020-02-26 10:06 ` Lukasz Luba
2020-02-26 13:55 ` Robin Murphy
2020-02-26 14:39 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf0d6bf7-ad87-4fbf-0392-646d5aa6d52b@arm.com \
--to=lukasz.luba@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=Morten.Rasmussen@arm.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=amit.kucheria@verdurent.com \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=bsegall@google.com \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=javi.merino@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kernel@pengutronix.de \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=nm@ti.com \
--cc=orjan.eide@arm.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).