Re: [PATCH 2/2] drm/lima: driver for ARM Mali4xx GPUs

From: "Koenig, Christian" <Christian.Koenig@amd.com>
To: Eric Anholt <eric@anholt.net>, Rob Herring <robh@kernel.org>,
	Dave Airlie <airlied@gmail.com>
Cc: "Marek Vasut" <marex@denx.de>,
	"Simon Shields" <simon@lineageos.org>,
	"lima@lists.freedesktop.org" <lima@lists.freedesktop.org>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Maxime Ripard" <maxime.ripard@bootlin.com>,
	"Christian König" <ckoenig.leichtzumerken@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"Vasily Khoruzhick" <anarsoul@gmail.com>,
	"David Airlie" <airlied@linux.ie>, "Qiang Yu" <yuq825@gmail.com>,
	"Sean Paul" <sean@poorly.run>,
	"Andreas Baierl" <ichgeh@imkreisrum.de>,
	"Erico Nunes" <nunes.erico@gmail.com>
Subject: Re: [PATCH 2/2] drm/lima: driver for ARM Mali4xx GPUs
Date: Fri, 15 Mar 2019 16:19:39 +0000	[thread overview]
Message-ID: <d02c728f-a098-0b69-9598-bb6dc35a8da3@amd.com> (raw)
In-Reply-To: <875zskrulp.fsf@anholt.net>

Am 15.03.19 um 17:05 schrieb Eric Anholt:
> [SNIP]
>>>>> I think for lima not having this is fine, but for panfrost it really
>>>>> should have it.
>>>>>
>>>>> If you can implement vulkan you probably want this, nouveau hasn't a
>>>>> vulkan driver because of exactly this problem in their uapi, so maybe
>>>>> adjust panfrost to do user-space managed vma.
>>>> Wouldn't this just require an allocation flag to not map the BO up
>>>> front and then new ioctl's like above to map and unmap at specified
>>>> VAs? Seems like we could add that when we get there.
>>> Sounds pretty reasonable to me.
>> I can only advise to NOT do this.
>>
>> A address space manager in userspace is rather easily doable, but fixing
>> up UAPI without breaking existing applications isn't.
> Can you expand on what goes wrong with Rob's idea?  The only thing I can
> come up with is maybe dmabuf imports don't have a flag for
> don't-automatically-map?

Suppressing automatically mapping is not the problem. The problem is 
that you need exactly one instance to have the authority over the 
address space management.

With Vulkan and features like PRT this must be done by userspace. So 
can't just go ahead in the kernel and allocate some address space and 
map your buffers.

You can of course hope that all client respect this and you don't have 
combinations of multiple clients in the same process, but from 
experience I can say that this won't work at all.

Regards,
Christian.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel