From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: kernel@collabora.com, "David Airlie" <airlied@linux.ie>,
"Thomas Hellström" <thomas_os@shipmail.org>,
"Emil Velikov" <emil.l.velikov@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Dmitry Osipenko" <digetx@gmail.com>,
virtualization@lists.linux-foundation.org,
"Robin Murphy" <robin.murphy@arm.com>
Subject: Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs
Date: Tue, 5 Jul 2022 17:27:35 +0300 [thread overview]
Message-ID: <d2c64d09-c4bb-9aed-069d-a9b4d07a1f66@collabora.com> (raw)
In-Reply-To: <20220705135323.emr4gdbcxoisdcxe@sirius.home.kraxel.org>
Hello Gerd,
On 7/5/22 16:53, Gerd Hoffmann wrote:
> Hi,
>
>> - * So for the moment keep things as-is, with a bulky comment
>> - * for the next person who feels like removing this
>> - * drm_dev_set_unique() quirk.
>
> Dragons lurking here. It's not the first attempt to ditch this, and so
> far all have been rolled back due to regressions. Specifically Xorg is
> notoriously picky if it doesn't find its expectations fulfilled.
I saw the previous attempt. Back then it was a mechanically created
patch that didn't get any testing.
> Also note that pci is not the only virtio transport we have.
The VirtIO indeed has other transports, but only PCI is really supported
in case of the VirtIO-GPU in kernel and in Qemu/crosvm, AFAICT. Hence
only the PCI transport was tested.
> What kind of testing has this patch seen?
The Xorg and virgl work perfectly fine in Qemu (with and without IOMMU
enabled in Qemu) and in crosvm (ChromeOS virtual machine).
--
Best regards,
Dmitry
next prev parent reply other threads:[~2022-07-05 14:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 20:07 [PATCH v7 0/9] VirtIO-GPU driver fixes and improvements Dmitry Osipenko
2022-06-30 20:07 ` [PATCH v7 1/9] drm/virtio: Correct drm_gem_shmem_get_sg_table() error handling Dmitry Osipenko
2022-06-30 20:07 ` [PATCH v7 2/9] drm/virtio: Check whether transferred 2D BO is shmem Dmitry Osipenko
2022-06-30 20:07 ` [PATCH v7 3/9] drm/virtio: Unlock reservations on virtio_gpu_object_shmem_init() error Dmitry Osipenko
2022-06-30 20:07 ` [PATCH v7 4/9] drm/virtio: Unlock reservations on dma_resv_reserve_fences() error Dmitry Osipenko
2022-06-30 20:07 ` [PATCH v7 5/9] drm/virtio: Use appropriate atomic state in virtio_gpu_plane_cleanup_fb() Dmitry Osipenko
2022-06-30 20:07 ` [PATCH v7 6/9] drm/virtio: Simplify error handling of virtio_gpu_object_create() Dmitry Osipenko
2022-06-30 20:07 ` [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs Dmitry Osipenko
2022-07-05 13:53 ` Gerd Hoffmann
2022-07-05 14:27 ` Dmitry Osipenko [this message]
2022-07-05 15:45 ` Gerd Hoffmann
2022-07-05 16:03 ` Emil Velikov
2022-07-05 17:02 ` Dmitry Osipenko
2022-07-05 20:56 ` Emil Velikov
2022-07-06 10:30 ` Laszlo Ersek
2022-07-05 21:39 ` Rob Clark
2022-07-05 23:08 ` Dmitry Osipenko
2022-07-06 7:13 ` Gerd Hoffmann
2022-07-06 7:22 ` Dmitry Osipenko
2022-07-19 10:31 ` Gerd Hoffmann
2022-07-19 11:30 ` Dmitry Osipenko
2022-06-30 20:07 ` [PATCH v7 8/9] drm/virtio: Use dev_is_pci() Dmitry Osipenko
2022-06-30 20:07 ` [PATCH v7 9/9] drm/virtio: Return proper error codes instead of -1 Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2c64d09-c4bb-9aed-069d-a9b4d07a1f66@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=airlied@linux.ie \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=gurchetansingh@chromium.org \
--cc=kernel@collabora.com \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=thomas_os@shipmail.org \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).