From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: Matthew Brost <matthew.brost@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
John Harrison <john.c.harrison@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Disable bonding on gen12+ platforms
Date: Fri, 26 Nov 2021 13:03:26 +0000 [thread overview]
Message-ID: <d3314baa-0720-ac04-f02b-024027cb81c4@linux.intel.com> (raw)
In-Reply-To: <20210807050222.GP1556418@mdroper-desk1.amr.corp.intel.com>
On 07/08/2021 06:02, Matt Roper wrote:
> On Fri, Aug 06, 2021 at 08:54:59PM +0200, Daniel Vetter wrote:
>> On Fri, Aug 6, 2021 at 8:25 PM John Harrison <john.c.harrison@intel.com> wrote:
>>> On 7/28/2021 12:21, Matthew Brost wrote:
>>>> Disable bonding on gen12+ platforms aside from ones already supported by
>>>> the i915 - TGL, RKL, and ADL-S.
Does this needs adjusting for the change in ADL-P plans?
Regards,
Tvrtko
>>>>
>>>> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
>>>> ---
>>>> drivers/gpu/drm/i915/gem/i915_gem_context.c | 7 +++++++
>>>> 1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
>>>> index 05c3ee191710..9c3672bac0e2 100644
>>>> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
>>>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
>>>> @@ -446,6 +446,13 @@ set_proto_ctx_engines_bond(struct i915_user_extension __user *base, void *data)
>>>> u16 idx, num_bonds;
>>>> int err, n;
>>>>
>>>> + if (GRAPHICS_VER(i915) >= 12 && !IS_TIGERLAKE(i915) &&
>>>> + !IS_ROCKETLAKE(i915) && !IS_ALDERLAKE_S(i915)) {
>>>> + drm_dbg(&i915->drm,
>>>> + "Bonding on gen12+ aside from TGL, RKL, and ADL_S not allowed\n");
>>> I would have said not supported rather than not allowed. Either way:
>>> Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
>>
>> Either is fine with me.
>>
>> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>
>
> Applied to drm-intel-gt-next (with the suggested debug message wording
> tweak). Thanks for the patch and reviews.
>
>
> Matt
>
>>>
>>>> + return -ENODEV;
>>>> + }
>>>> +
>>>> if (get_user(idx, &ext->virtual_index))
>>>> return -EFAULT;
>>>>
>>>
>>
>>
>> --
>> Daniel Vetter
>> Software Engineer, Intel Corporation
>> http://blog.ffwll.ch
>
prev parent reply other threads:[~2021-11-26 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 19:21 [PATCH] drm/i915: Disable bonding on gen12+ platforms Matthew Brost
2021-08-06 18:25 ` [Intel-gfx] " John Harrison
2021-08-06 18:54 ` Daniel Vetter
2021-08-07 5:02 ` Matt Roper
2021-11-26 13:03 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3314baa-0720-ac04-f02b-024027cb81c4@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=john.c.harrison@intel.com \
--cc=matthew.brost@intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).