From: Philippe CORNU <philippe.cornu@st.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Yannick FERTRE <yannick.fertre@st.com>,
Fabien DESSENNE <fabien.dessenne@st.com>,
Mickael REULIER <mickael.reulier@st.com>,
Vincent ABRIOU <vincent.abriou@st.com>,
Gabriel FERNANDEZ <gabriel.fernandez@st.com>,
Ludovic BARRE <ludovic.barre@st.com>
Subject: Re: [PATCH v1 2/2] drm/bridge/synopsys: dsi: Register list clean up
Date: Wed, 19 Jul 2017 09:11:44 +0000 [thread overview]
Message-ID: <d33a6382-7128-2565-8b63-745210b55d21@st.com> (raw)
In-Reply-To: <1549201.DAvZbLDVYF@avalon>
On 07/18/2017 03:39 PM, Laurent Pinchart wrote:
> Hi Philippe,
>
> Thank you for the patch.
>
> On Tuesday 18 Jul 2017 13:43:52 Philippe CORNU wrote:
>> This patch cleans up the Synopsys mipi dsi register list:
>> - remove unused registers
>
> Is the documentation for the DSI transmitter core public ? If not, it could be
> useful to keep unused registers for reference. That's nine lines only.
>
Hi Laurent,
And many thanks for the code review.
Unfortunately the Synopsys Documentation seems not public (I may google
more), so I will put back these registers :)
Nevertheless, the stm32 documentation is public and it is probably the
same for rockchip (and hisilicon and...), and in these public
documentations, register and bitfield names are slightly different but
register addresses and bitfield descriptions are the same...
I do not know if it makes sense or not but we may ask Synopsys to
publicly release the mipi dsi documentation...
Did you manage to get it "publicly" for the Synopsys hdmi?
>> - rename registers according to the Synopsys documentation
>> (1.30 & 1.31)
>> - fix typos
>> - re-order registers for a better coherency
>
> For the rest,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
Thank you
Philippe
>> Signed-off-by: Philippe CORNU <philippe.cornu@st.com>
>> ---
>> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 77 +++++++++---------------
>> 1 file changed, 33 insertions(+), 44 deletions(-)
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-07-19 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 11:43 [PATCH v1 0/2] drm/bridge/synopsys: dsi: Various cleanups Philippe CORNU
2017-07-18 11:43 ` [PATCH v1 1/2] drm/bridge/synopsys: dsi: Constify funcs structures Philippe CORNU
2017-07-18 13:26 ` Laurent Pinchart
2017-07-18 11:43 ` [PATCH v1 2/2] drm/bridge/synopsys: dsi: Register list clean up Philippe CORNU
2017-07-18 13:39 ` Laurent Pinchart
2017-07-19 9:11 ` Philippe CORNU [this message]
2017-07-20 9:47 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d33a6382-7128-2565-8b63-745210b55d21@st.com \
--to=philippe.cornu@st.com \
--cc=alexandre.torgue@st.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabien.dessenne@st.com \
--cc=gabriel.fernandez@st.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.barre@st.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mickael.reulier@st.com \
--cc=vincent.abriou@st.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).