From: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
To: "Sandy Huang" <hjc@rock-chips.com>,
"Emil Velikov" <emil.l.velikov@gmail.com>,
"Heiko Stübner" <heiko@sntech.de>
Cc: kernel@collabora.com, Mihail Atanassov <mihail.atanassov@arm.com>,
David Airlie <airlied@linux.ie>,
Liviu Dudau <liviu.dudau@arm.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
James Wang <james.qian.wang@arm.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Ayan Halder <Ayan.Halder@arm.com>
Subject: Re: [PATCHv7 6/6] drm/rockchip: Add support for afbc
Date: Thu, 19 Mar 2020 10:54:00 +0100 [thread overview]
Message-ID: <d422f838-2c93-b356-c74d-d7da80000f8d@collabora.com> (raw)
In-Reply-To: <3d4f027e-8de3-ba7c-5654-31eda66a7681@rock-chips.com>
Hi Sandy,
W dniu 19.03.2020 o 03:57, Sandy Huang pisze:
> Hi Emil,
>
<snip>
>>> --
>>> 2.17.1
>> Heiko, Sandy, being the maintainers of the Rockchip driver, can you
>> review/ack this patch?
>>
>> I believe the intention is to merge the series via drm-misc. Andrzej
>> already has commit access.
>>
>> -Emil
>>
>>
> Thanks for you patch, maybe we need to consider the compatibility with px30
> platform afbc features,the main difference is:
>
> 1. px30 support x offset and y offset display, and the state->src.x1 /
> state->src.y1 should be alibegned as 16pixel/line;
>
> 2.px30 only win1 can support afbdc format;
>
>
Actually I sent the patch, Emil kindly forwarded it to you.
Unfortunately I don't have px30 hardware, so I can't test. Can we
merge the patch as is (if you are ok with the way it is now) and then
I will help reviewing the patch adding px30 support on top of it?
Regards,
Andrzej
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-19 9:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 14:55 [PATCHv7 0/6] Add AFBC support for Rockchip Andrzej Pietrasiewicz
2020-03-11 14:55 ` [PATCHv7 1/6] drm/core: Allow drivers allocate a subclass of struct drm_framebuffer Andrzej Pietrasiewicz
2020-03-17 3:08 ` james qian wang (Arm Technology China)
2020-03-11 14:55 ` [PATCHv7 2/6] drm/core: Add drm_afbc_framebuffer and a corresponding helper Andrzej Pietrasiewicz
2020-03-17 3:15 ` james qian wang (Arm Technology China)
2020-03-17 10:16 ` Daniel Vetter
2020-03-30 17:01 ` Daniel Vetter
2020-03-30 17:44 ` Andrzej Pietrasiewicz
2020-03-30 18:24 ` Daniel Vetter
2020-03-31 15:53 ` [PATCH 0/2] AFBC fixes Andrzej Pietrasiewicz
2020-03-31 15:53 ` [PATCH 1/2] drm/core: Use proper debugging macro Andrzej Pietrasiewicz
2020-04-01 9:13 ` Daniel Vetter
2020-03-31 15:53 ` [PATCH 2/2] drm/core: Calculate bpp in afbc helper Andrzej Pietrasiewicz
2020-04-01 9:13 ` Daniel Vetter
2020-03-11 14:55 ` [PATCHv7 3/6] drm/arm/malidp: Factor-in framebuffer creation Andrzej Pietrasiewicz
2020-03-11 14:55 ` [PATCHv7 4/6] drm/arm/malidp: Allocate an afbc-specific drm_framebuffer Andrzej Pietrasiewicz
2020-03-16 14:05 ` Emil Velikov
2020-03-11 14:55 ` [PATCHv7 5/6] drm/arm/malidp: Switch to afbc helpers Andrzej Pietrasiewicz
2020-03-11 14:55 ` [PATCHv7 6/6] drm/rockchip: Add support for afbc Andrzej Pietrasiewicz
2020-03-16 14:10 ` Emil Velikov
2020-03-19 2:57 ` Sandy Huang
2020-03-19 9:54 ` Andrzej Pietrasiewicz [this message]
2020-03-20 11:34 ` Sandy Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d422f838-2c93-b356-c74d-d7da80000f8d@collabora.com \
--to=andrzej.p@collabora.com \
--cc=Ayan.Halder@arm.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=james.qian.wang@arm.com \
--cc=kernel@collabora.com \
--cc=liviu.dudau@arm.com \
--cc=mihail.atanassov@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).