From: Helen Koike <helen.koike@collabora.com>
To: "André Almeida" <andrealmeid@igalia.com>,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: pierre-eric.pelloux-prayer@amd.com,
"'Marek Olšák'" <maraeo@gmail.com>,
"Michel Dänzer" <michel.daenzer@mailbox.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Pekka Paalanen" <ppaalanen@gmail.com>,
kernel-dev@igalia.com, alexander.deucher@amd.com,
hwentlan@amd.com, christian.koenig@amd.com, joshua@froggi.es
Subject: Re: [PATCH v7 0/6] drm: Add support for atomic async page-flip
Date: Tue, 17 Oct 2023 10:47:08 -0300 [thread overview]
Message-ID: <d724ea14-bd35-4f02-88c2-f691691b0376@collabora.com> (raw)
In-Reply-To: <20231017092837.32428-1-andrealmeid@igalia.com>
On 17/10/2023 06:28, André Almeida wrote:
> Hi,
>
> This work from me and Simon adds support for DRM_MODE_PAGE_FLIP_ASYNC through
> the atomic API. This feature is already available via the legacy API. The use
> case is to be able to present a new frame immediately (or as soon as
> possible), even if after missing a vblank. This might result in tearing, but
> it's useful when a high framerate is desired, such as for gaming.
>
> Differently from earlier versions, this one refuses to flip if any prop changes
> for async flips. The idea is that the fast path of immediate page flips doesn't
> play well with modeset changes, so only the fb_id can be changed.
> Thanks,
> André
>
> - User-space patch: https://github.com/Plagman/gamescope/pull/595
> - IGT tests: https://gitlab.freedesktop.org/andrealmeid/igt-gpu-tools/-/tree/atomic_async_page_flip
>
> Changes from v6:
> - Dropped the exception to allow MODE_ID changes (Simon)
> - Clarify what happens when flipping with the same FB_ID (Pekka)
>
> v6: https://lore.kernel.org/dri-devel/20230815185710.159779-1-andrealmeid@igalia.com/
>
> Changes from v5:
> - Add note in the docs that not every redundant attribute will result in no-op,
> some might cause oversynchronization issues.
>
> v5: https://lore.kernel.org/dri-devel/20230707224059.305474-1-andrealmeid@igalia.com/
>
> Changes from v4:
> - Documentation rewrote by Pekka Paalanen
>
> v4: https://lore.kernel.org/dri-devel/20230701020917.143394-1-andrealmeid@igalia.com/
>
> Changes from v3:
> - Add new patch to reject prop changes
> - Add a documentation clarifying the KMS atomic state set
>
> v3: https://lore.kernel.org/dri-devel/20220929184307.258331-1-contact@emersion.fr/
>
> André Almeida (1):
> drm: Refuse to async flip with atomic prop changes
>
> Pekka Paalanen (1):
> drm/doc: Define KMS atomic state set
>
> Simon Ser (4):
> drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits
> drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP
> drm: introduce drm_mode_config.atomic_async_page_flip_not_supported
> amd/display: indicate support for atomic async page-flips on DC
>
> Documentation/gpu/drm-uapi.rst | 47 ++++++++++++
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 1 +
> drivers/gpu/drm/drm_atomic_uapi.c | 75 +++++++++++++++++--
> drivers/gpu/drm/drm_crtc_internal.h | 2 +-
> drivers/gpu/drm/drm_ioctl.c | 5 ++
> drivers/gpu/drm/drm_mode_object.c | 2 +-
> .../drm/i915/display/intel_display_driver.c | 1 +
> drivers/gpu/drm/nouveau/nouveau_display.c | 1 +
> include/drm/drm_mode_config.h | 11 +++
> include/uapi/drm/drm.h | 10 ++-
> include/uapi/drm/drm_mode.h | 9 +++
> 11 files changed, 155 insertions(+), 9 deletions(-)
>
Hello o/
Maybe it is not related (since there are a few years I don't work on
this) but this reminds me of
https://yhbt.net/lore/all/20190412125827.5877-1-helen.koike@collabora.com/T/
(just sharing for the sake of communication flow)
Regards,
Helen
prev parent reply other threads:[~2023-10-17 13:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 9:28 [PATCH v7 0/6] drm: Add support for atomic async page-flip André Almeida
2023-10-17 9:28 ` [PATCH v7 1/6] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits André Almeida
2023-10-17 9:28 ` [PATCH v7 2/6] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP André Almeida
2023-10-17 9:28 ` [PATCH v7 3/6] drm: introduce drm_mode_config.atomic_async_page_flip_not_supported André Almeida
2023-10-17 9:28 ` [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes André Almeida
2023-10-17 10:18 ` Simon Ser
2023-10-17 12:16 ` Simon Ser
2023-10-22 10:12 ` Michel Dänzer
2023-10-23 8:27 ` Simon Ser
2023-10-23 8:42 ` Michel Dänzer
2023-10-23 8:44 ` Simon Ser
2023-10-17 15:55 ` kernel test robot
2023-10-17 9:28 ` [PATCH v7 5/6] drm/doc: Define KMS atomic state set André Almeida
2023-10-17 9:28 ` [PATCH v7 6/6] amd/display: indicate support for atomic async page-flips on DC André Almeida
2023-10-17 13:47 ` Helen Koike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d724ea14-bd35-4f02-88c2-f691691b0376@collabora.com \
--to=helen.koike@collabora.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrealmeid@igalia.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hwentlan@amd.com \
--cc=joshua@froggi.es \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maraeo@gmail.com \
--cc=michel.daenzer@mailbox.org \
--cc=pierre-eric.pelloux-prayer@amd.com \
--cc=ppaalanen@gmail.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).