From: Felix Kuehling <felix.kuehling@amd.com>
To: Souptick Joarder <jrdr.linux@gmail.com>,
alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@linux.ie, daniel@ffwll.ch, Hawking.Zhang@amd.com,
evan.quan@amd.com, Dennis.Li@amd.com, luben.tuikov@amd.com,
jonathan.kim@amd.com
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amdgpu: Added missing prototype
Date: Fri, 23 Apr 2021 19:33:55 -0400 [thread overview]
Message-ID: <da39ded9-7222-8530-2388-aef3879d1ca3@amd.com> (raw)
In-Reply-To: <1619213997-5475-1-git-send-email-jrdr.linux@gmail.com>
Am 2021-04-23 um 5:39 p.m. schrieb Souptick Joarder:
> Kernel test robot throws below warning ->
>
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:125:5: warning:
>>> no previous prototype for 'kgd_arcturus_hqd_sdma_load'
>>> [-Wmissing-prototypes]
> 125 | int kgd_arcturus_hqd_sdma_load(struct kgd_dev *kgd, void
> *mqd,
>
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:227:6: warning:
>>> no previous prototype for 'kgd_arcturus_hqd_sdma_is_occupied'
>>> [-Wmissing-prototypes]
> 227 | bool kgd_arcturus_hqd_sdma_is_occupied(struct kgd_dev *kgd,
> void *mqd)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:246:5: warning:
>>> no previous prototype for 'kgd_arcturus_hqd_sdma_destroy'
>>> [-Wmissing-prototypes]
> 246 | int kgd_arcturus_hqd_sdma_destroy(struct kgd_dev *kgd, void
> *mqd,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Added prototype for these functions.
The prototypes are already defined in amdgpu_amdkfd_arcturus.h. I think
we just need to add a #include in amdgpu_amdkfd_arcturus.c.
Regards,
Felix
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index dc3a692..8fff0e7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -316,6 +316,11 @@ int amdgpu_device_ip_wait_for_idle(struct amdgpu_device *adev,
> enum amd_ip_block_type block_type);
> bool amdgpu_device_ip_is_idle(struct amdgpu_device *adev,
> enum amd_ip_block_type block_type);
> +int kgd_arcturus_hqd_sdma_load(struct kgd_dev *kgd, void *mqd,
> + uint32_t __user *wptr, struct mm_struct *mm);
> +bool kgd_arcturus_hqd_sdma_is_occupied(struct kgd_dev *kgd, void *mqd);
> +int kgd_arcturus_hqd_sdma_destroy(struct kgd_dev *kgd, void *mqd,
> + unsigned int utimeout);
>
> #define AMDGPU_MAX_IP_NUM 16
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-23 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 21:39 [PATCH] drm/amdgpu: Added missing prototype Souptick Joarder
2021-04-23 23:33 ` Felix Kuehling [this message]
2021-04-24 9:27 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da39ded9-7222-8530-2388-aef3879d1ca3@amd.com \
--to=felix.kuehling@amd.com \
--cc=Dennis.Li@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=jonathan.kim@amd.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luben.tuikov@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).