From: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Jonas Karlman" <jonas@kwiboo.se>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Alvin Šipraga" <alvin@pqrs.dk>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>
Subject: Re: [PATCH] drm: bridge: adv7511: get edid in hpd_work to update CEC phys address
Date: Wed, 25 Oct 2023 07:26:43 +0000 [thread overview]
Message-ID: <dbmznxaf2vb44g66a45kzdzpsyyrmqh5opnh4q6it4a2ncikkt@p5ojks5dz6lc> (raw)
In-Reply-To: <87pm15bm4f.fsf@intel.com>
Hi Jani,
On Mon, Oct 23, 2023 at 02:42:56PM +0300, Jani Nikula wrote:
> On Sat, 14 Oct 2023, Alvin Šipraga <alvin@pqrs.dk> wrote:
> > @@ -457,6 +460,9 @@ static void adv7511_hpd_work(struct work_struct *work)
> > if (adv7511->connector.dev) {
> > if (status == connector_status_disconnected)
> > cec_phys_addr_invalidate(adv7511->cec_adap);
> > + else
> > + adv7511_get_edid(adv7511, &adv7511->connector);
>
> This leaks the returned EDID.
Thanks for catching this - I will fix in v2.
Kind regards,
Alvin
prev parent reply other threads:[~2023-10-25 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 19:43 [PATCH] drm: bridge: adv7511: get edid in hpd_work to update CEC phys address Alvin Šipraga
2023-10-14 19:48 ` Alvin Šipraga
2023-10-16 8:17 ` Laurent Pinchart
2023-10-16 8:46 ` Alvin Šipraga
2023-10-23 11:42 ` Jani Nikula
2023-10-25 7:26 ` Alvin Šipraga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbmznxaf2vb44g66a45kzdzpsyyrmqh5opnh4q6it4a2ncikkt@p5ojks5dz6lc \
--to=alsi@bang-olufsen.dk \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=alvin@pqrs.dk \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).