From: Hans Verkuil <hverkuil@xs4all.nl>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 00/14] Renesas R-Car VSP: Add H3 ES2.0 support
Date: Tue, 18 Jul 2017 15:03:50 +0200 [thread overview]
Message-ID: <ddcad88f-0b34-0cc9-c021-3c7f5cd02de5@xs4all.nl> (raw)
In-Reply-To: <20170626181226.29575-1-laurent.pinchart+renesas@ideasonboard.com>
On 26/06/17 20:12, Laurent Pinchart wrote:
> Hello,
>
> This patch series implements support for the R-Car H3 ES2.0 SoC in the VSP
> and DU drivers.
>
> Compared to the H3 ES1.1, the H3 ES2.0 has a new VSP2-DL instance that
> includes two blending units, a BRU and a BRS. The BRS is similar to the BRU
> but has two inputs only, and is used to service a second DU channel from the
> same VSP through a second LIF instances connected to WPF.1.
>
> The patch series starts with a small fixes and cleanups in patches 01/14 to
> 05/14. Patch 06/14 prepares the VSP driver for multiple DU channels support by
> extending the DU-VSP API with an additional argument. Patches 07/14 to 10/14
> gradually build H3 ES2.0 support on top of that by implementing all needed
> features in the VSP driver.
>
> So far the VSP driver always used headerless display lists when operating in
> connection with the DU. This mode of operation is only available on WPF.0, so
> support for regular display lists with headers when operating with the DU is
> added in patch 11/14.
>
> The remaining patches finally implement H3 ES2.0 support in the DU driver,
> with support for VSP sharing implemented in patch 12/14, for H3 ES2.0 PLL in
> patch 13/14 (by restricting the ES1.x workaround to ES1.x SoCs) and for RGB
> output routing in patch 14/14.
>
> Compared to v1, the series has gone under considerable changes. Testing
> locally on H3 ES2.0 uncovered multiple issues in the previous partially tested
> version, which have been fixed in additional patches. The following changes
> can be noted in particular.
>
> - New small cleanups in patches 02/14 to 05/14
> - Pass the pipe index to vsp1_du_atomic_update() explicitly
> - Rebase on top of the VSP-DU flicker fixes, resulting in a major rework of
> "v4l: vsp1: Add support for header display lists in continuous mode"
> - New patches 09/14, 10/14 and 12/14 to support the previously untested VGA
> output
>
> The series is based on top of Dave's latest drm-next branch as it depends on
> patches merged by Dave for v4.13. It depends, for testing, on
>
> - the sh-pfc-for-v4.13 branch from Geert's renesas-drivers tree
> - the "[PATCH v2 0/2] R-Car H3 ES2.0 Salvator-X: Enable DU support in DT"
> patch series
>
> For convenience, a branch merging this series with all dependencies is
> available from
>
> git://linuxtv.org/pinchartl/media.git drm/next/h3-es2/merged
>
> with the DT and driver series split in two branches respectively tagged
> drm-h3-es2-dt-20170626 and drm-h3-es2-vsp-du-20170626.
>
> The patches have been tested on the Lager, Salvator-X H3 ES1.x, Salvator-X
> M3-W and Salvator-XS boards. All outputs have been tested using modetest
> without any noticeable regression.
>
> Laurent Pinchart (14):
> v4l: vsp1: Fill display list headers without holding dlm spinlock
> v4l: vsp1: Don't recycle active list at display start
> v4l: vsp1: Don't set WPF sink pointer
> v4l: vsp1: Store source and sink pointers as vsp1_entity
> v4l: vsp1: Don't create links for DRM pipeline
> v4l: vsp1: Add pipe index argument to the VSP-DU API
> v4l: vsp1: Add support for the BRS entity
> v4l: vsp1: Add support for new VSP2-BS, VSP2-DL and VSP2-D instances
> v4l: vsp1: Add support for multiple LIF instances
> v4l: vsp1: Add support for multiple DRM pipelines
> v4l: vsp1: Add support for header display lists in continuous mode
> drm: rcar-du: Support multiple sources from the same VSP
> drm: rcar-du: Restrict DPLL duty cycle workaround to H3 ES1.x
> drm: rcar-du: Configure DPAD0 routing through last group on Gen3
For this patch series:
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
>
> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 39 ++--
> drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 3 +
> drivers/gpu/drm/rcar-du/rcar_du_group.c | 21 ++-
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 91 ++++++++--
> drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 37 ++--
> drivers/gpu/drm/rcar-du/rcar_du_vsp.h | 10 +-
> drivers/media/platform/vsp1/vsp1.h | 7 +-
> drivers/media/platform/vsp1/vsp1_bru.c | 45 +++--
> drivers/media/platform/vsp1/vsp1_bru.h | 4 +-
> drivers/media/platform/vsp1/vsp1_dl.c | 205 +++++++++++++---------
> drivers/media/platform/vsp1/vsp1_dl.h | 1 -
> drivers/media/platform/vsp1/vsp1_drm.c | 283 +++++++++++++++---------------
> drivers/media/platform/vsp1/vsp1_drm.h | 38 ++--
> drivers/media/platform/vsp1/vsp1_drv.c | 115 ++++++++----
> drivers/media/platform/vsp1/vsp1_entity.c | 40 +++--
> drivers/media/platform/vsp1/vsp1_entity.h | 5 +-
> drivers/media/platform/vsp1/vsp1_lif.c | 5 +-
> drivers/media/platform/vsp1/vsp1_lif.h | 2 +-
> drivers/media/platform/vsp1/vsp1_pipe.c | 7 +-
> drivers/media/platform/vsp1/vsp1_regs.h | 46 +++--
> drivers/media/platform/vsp1/vsp1_video.c | 63 ++++---
> drivers/media/platform/vsp1/vsp1_wpf.c | 4 +-
> include/media/vsp1.h | 10 +-
> 23 files changed, 676 insertions(+), 405 deletions(-)
>
prev parent reply other threads:[~2017-07-18 13:03 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 18:12 [PATCH v2 00/14] Renesas R-Car VSP: Add H3 ES2.0 support Laurent Pinchart
2017-06-26 18:12 ` [PATCH v2 01/14] v4l: vsp1: Fill display list headers without holding dlm spinlock Laurent Pinchart
2017-07-13 12:48 ` Kieran Bingham
2017-07-20 13:50 ` Mauro Carvalho Chehab
2017-06-26 18:12 ` [PATCH v2 02/14] v4l: vsp1: Don't recycle active list at display start Laurent Pinchart
2017-07-13 17:02 ` Kieran Bingham
2017-07-20 13:51 ` Mauro Carvalho Chehab
2017-06-26 18:12 ` [PATCH v2 03/14] v4l: vsp1: Don't set WPF sink pointer Laurent Pinchart
2017-07-13 12:50 ` Kieran Bingham
2017-07-20 13:52 ` Mauro Carvalho Chehab
2017-06-26 18:12 ` [PATCH v2 04/14] v4l: vsp1: Store source and sink pointers as vsp1_entity Laurent Pinchart
2017-07-13 13:00 ` Kieran Bingham
2017-07-20 13:53 ` Mauro Carvalho Chehab
2017-06-26 18:12 ` [PATCH v2 05/14] v4l: vsp1: Don't create links for DRM pipeline Laurent Pinchart
2017-07-13 13:06 ` Kieran Bingham
2017-07-20 13:54 ` Mauro Carvalho Chehab
2017-06-26 18:12 ` [PATCH v2 06/14] v4l: vsp1: Add pipe index argument to the VSP-DU API Laurent Pinchart
2017-07-13 13:16 ` Kieran Bingham
2017-07-13 23:04 ` Laurent Pinchart
2017-07-20 13:56 ` Mauro Carvalho Chehab
2017-06-26 18:12 ` [PATCH v2 07/14] v4l: vsp1: Add support for the BRS entity Laurent Pinchart
2017-07-13 13:38 ` Kieran Bingham
2017-07-20 13:58 ` Mauro Carvalho Chehab
2017-06-26 18:12 ` [PATCH v2 08/14] v4l: vsp1: Add support for new VSP2-BS, VSP2-DL and VSP2-D instances Laurent Pinchart
2017-07-13 17:49 ` Kieran Bingham
2017-07-13 23:31 ` Laurent Pinchart
2017-07-14 7:36 ` Kieran Bingham
2017-07-14 0:35 ` [PATCH v2.1 " Laurent Pinchart
2017-07-20 13:59 ` Mauro Carvalho Chehab
2017-06-26 18:12 ` [PATCH v2 09/14] v4l: vsp1: Add support for multiple LIF instances Laurent Pinchart
2017-07-13 17:57 ` Kieran Bingham
2017-07-20 14:00 ` Mauro Carvalho Chehab
2017-06-26 18:12 ` [PATCH v2 10/14] v4l: vsp1: Add support for multiple DRM pipelines Laurent Pinchart
2017-07-20 14:02 ` Mauro Carvalho Chehab
2017-08-01 18:39 ` Kieran Bingham
2017-06-26 18:12 ` [PATCH v2 11/14] v4l: vsp1: Add support for header display lists in continuous mode Laurent Pinchart
2017-07-20 14:03 ` Mauro Carvalho Chehab
2017-08-01 17:35 ` Kieran Bingham
2017-08-01 18:47 ` Laurent Pinchart
2017-08-02 11:06 ` Kieran Bingham
2017-06-26 18:12 ` [PATCH v2 12/14] drm: rcar-du: Support multiple sources from the same VSP Laurent Pinchart
2017-08-01 18:10 ` Kieran Bingham
2017-08-01 19:01 ` Laurent Pinchart
2017-06-26 18:12 ` [PATCH v2 13/14] drm: rcar-du: Restrict DPLL duty cycle workaround to H3 ES1.x Laurent Pinchart
2017-08-01 14:06 ` Kieran Bingham
2017-08-01 18:39 ` Laurent Pinchart
2017-12-11 20:58 ` Laurent Pinchart
2017-06-26 18:12 ` [PATCH v2 14/14] drm: rcar-du: Configure DPAD0 routing through last group on Gen3 Laurent Pinchart
2017-08-01 13:46 ` Kieran Bingham
2017-08-01 13:51 ` Laurent Pinchart
2017-08-01 17:20 ` [PATCH v2.1 " Laurent Pinchart
2017-08-01 17:23 ` Kieran Bingham
2017-07-13 12:25 ` [PATCH v2 00/14] Renesas R-Car VSP: Add H3 ES2.0 support Kieran Bingham
2017-07-14 0:54 ` Laurent Pinchart
2017-07-18 13:03 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddcad88f-0b34-0cc9-c021-3c7f5cd02de5@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).