From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [RFC 1/7] drm/gem: Add drm_gem_dumb_map_offset() Date: Thu, 20 Jul 2017 00:13:07 +0200 Message-ID: References: <1499867165-60925-1-git-send-email-noralf@tronnes.org> <1499867165-60925-2-git-send-email-noralf@tronnes.org> <87h8y8dtu3.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 51C6F6E5BD for ; Wed, 19 Jul 2017 22:13:12 +0000 (UTC) In-Reply-To: <87h8y8dtu3.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CkRlbiAxOS4wNy4yMDE3IDIzLjAxLCBza3JldiBFcmljIEFuaG9sdDoKPiBOb3JhbGYgVHLDuG5u ZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4gd3JpdGVzOgo+Cj4+IEFkZCBhIGNvbW1vbiBkcm1fZHJp dmVyLmR1bWJfbWFwX29mZnNldCBmdW5jdGlvbiBmb3IgR0VNIGJhY2tlZCBkcml2ZXJzLgo+Pgo+ PiBTaWduZWQtb2ZmLWJ5OiBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KPiBJ bnN0ZWFkIG9mIGp1c3QgaW50cm9kdWNpbmcgdGhlIG5ldyBjb2RlLCBjb3VsZCB3ZSByZXBsYWNl IENNQSdzIGNvZGUKPiB3aXRoIGNhbGxzIHRvIHRoaXMgYXQgdGhlIHNhbWUgdGltZT8KCkkgaGF2 ZSBnb25lIHRocm91Z2ggYWxsIHRoZSBkcm1fZHJpdmVyLT5kdW1iX21hcF9vZmZzZXQKaW1wbGVt ZW50YXRpb25zIGFuZCBmb3VuZCAyMyBkcml2ZXJzIHRoYXQgY291bGQgdXNlIGl0OgotIDE4IGRy aXZlcnMgdXNlIGRybV9nZW1fY21hX2R1bWJfbWFwX29mZnNldCgpCi0gZXh5bm9zX2RybV9nZW1f ZHVtYl9tYXBfb2Zmc2V0KCkKLSBtdGtfZHJtX2dlbV9kdW1iX21hcF9vZmZzZXQoKQotIHBzYl9n ZW1fZHVtYl9tYXBfZ3R0KCkKLSByb2NrY2hpcF9nZW1fZHVtYl9tYXBfb2Zmc2V0KCkKLSB0ZWdy YV9ib19kdW1iX21hcF9vZmZzZXQoKQoKdmdlbV9nZW1fZHVtYl9tYXAoKSBjYW4ndCB1c2UgaXQg YmVjYXVzZSBvZiB0aGlzIGNoZWNrOgogICAgIGlmICghb2JqLT5maWxwKSB7CiAgICAgICAgIHJl dCA9IC1FSU5WQUw7CiAgICAgICAgIGdvdG8gdW5yZWY7CiAgICAgfQoKYXJtYWRhX2dlbV9kdW1i X21hcF9vZmZzZXQoKSBjYW4ndCB1c2UgaXQgYmVjYXVzZSBvZiB0aGlzIGNoZWNrOgogICAgIC8q IERvbid0IGFsbG93IGltcG9ydGVkIG9iamVjdHMgdG8gYmUgbWFwcGVkICovCiAgICAgaWYgKG9i ai0+b2JqLmltcG9ydF9hdHRhY2gpIHsKICAgICAgICAgcmV0ID0gLUVJTlZBTDsKICAgICAgICAg Z290byBlcnJfdW5yZWY7CiAgICAgfQoKSSBzZWUgdGhhdCBkcml2ZXJzIG11c3QgaW1wbGVtZW50 IGFsbCAzIC5kdW1iXyogY2FsbGJhY2tzOgoKICAqIFRvIHN1cHBvcnQgZHVtYiBvYmplY3RzIGRy aXZlcnMgbXVzdCBpbXBsZW1lbnQgdGhlIAomZHJtX2RyaXZlci5kdW1iX2NyZWF0ZSwKICAqICZk cm1fZHJpdmVyLmR1bWJfZGVzdHJveSBhbmQgJmRybV9kcml2ZXIuZHVtYl9tYXBfb2Zmc2V0IG9w ZXJhdGlvbnMuIFNlZQogICogdGhlcmUgZm9yIGZ1cnRoZXIgZGV0YWlscy4KCkknbSBhIGZhbiBv ZiBkZWZhdWx0cywgaXMgdGhlcmUgYW55IHJlYXNvbiB3ZSBjYW4ndCBkbyB0aGlzOgoKICBpbnQg ZHJtX21vZGVfbW1hcF9kdW1iX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCiAgICAgICAg ICAgICAgICAgICB2b2lkICpkYXRhLCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdikKICB7CiAg ICAgIHN0cnVjdCBkcm1fbW9kZV9tYXBfZHVtYiAqYXJncyA9IGRhdGE7CgogICAgICAvKiBjYWxs IGRyaXZlciBpb2N0bCB0byBnZXQgbW1hcCBvZmZzZXQgKi8KLSAgICAgaWYgKCFkZXYtPmRyaXZl ci0+ZHVtYl9tYXBfb2Zmc2V0KQorICAgIGlmICghZGV2LT5kcml2ZXItPmR1bWJfY3JlYXRlKQog ICAgICAgICByZXR1cm4gLUVOT1NZUzsKCi0gICAgIHJldHVybiBkZXYtPmRyaXZlci0+ZHVtYl9t YXBfb2Zmc2V0KGZpbGVfcHJpdiwgZGV2LCBhcmdzLT5oYW5kbGUsIAomYXJncy0+b2Zmc2V0KTsK KyAgICAgaWYgKGRldi0+ZHJpdmVyLT5kdW1iX21hcF9vZmZzZXQpCisgICAgICAgIHJldHVybiBk ZXYtPmRyaXZlci0+ZHVtYl9tYXBfb2Zmc2V0KGZpbGVfcHJpdiwgZGV2LCAKYXJncy0+aGFuZGxl LCAmYXJncy0+b2Zmc2V0KTsKKyAgICBlbHNlCisgICAgICAgIHJldHVybiBkcm1fZ2VtX2R1bWJf bWFwX29mZnNldChmaWxlX3ByaXYsIGRldiwgYXJncy0+aGFuZGxlLCAKJmFyZ3MtPm9mZnNldCk7 CiAgfQoKICBpbnQgZHJtX21vZGVfZGVzdHJveV9kdW1iX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsCiAgICAgICAgICAgICAgICAgIHZvaWQgKmRhdGEsIHN0cnVjdCBkcm1fZmlsZSAqZmls ZV9wcml2KQogIHsKICAgICAgc3RydWN0IGRybV9tb2RlX2Rlc3Ryb3lfZHVtYiAqYXJncyA9IGRh dGE7CgotICAgICBpZiAoIWRldi0+ZHJpdmVyLT5kdW1iX2Rlc3Ryb3kpCisgICAgaWYgKCFkZXYt PmRyaXZlci0+ZHVtYl9jcmVhdGUpCiAgICAgICAgICByZXR1cm4gLUVOT1NZUzsKCi0gICAgcmV0 dXJuIGRldi0+ZHJpdmVyLT5kdW1iX2Rlc3Ryb3koZmlsZV9wcml2LCBkZXYsIGFyZ3MtPmhhbmRs ZSk7CisgICAgIGlmIChkZXYtPmRyaXZlci0+ZHVtYl9kZXN0cm95KQorICAgICAgICByZXR1cm4g ZGV2LT5kcml2ZXItPmR1bWJfZGVzdHJveShmaWxlX3ByaXYsIGRldiwgYXJncy0+aGFuZGxlKTsK KyAgICBlbHNlCisgICAgICAgIHJldHVybiBkcm1fZ2VtX2R1bWJfZGVzdHJveShmaWxlX3ByaXYs IGRldiwgYXJncy0+aGFuZGxlKTsKICB9CgpUaGVyZSBhcmUgMzYgZHJpdmVycyB0aGF0IHVzZSBk cm1fZ2VtX2R1bWJfZGVzdHJveSgpIGRpcmVjdGx5Lgp2Z2VtIHZpb2xhdGVzIHRoZSBkb2NzIGFu ZCBkb2Vzbid0IHNldCAuZHVtYl9kZXN0cm95LgoKPiBJIHN1c3BlY3QgdGhhdCBpZiB3ZSBoYWQg Q01BIHN1YmNsYXNzIGZyb20gZHJtX2ZiX2dlbSAob3Igd2UgbW92ZSB0aGUKPiBnZW0gb2JqZWN0 cyB0byB0aGUgYmFzZSBjbGFzcyksIHdlIGNvdWxkIHJlbW92ZSBhIGxvdCBvZiBpdHMgY29kZSB0 aGF0Cj4geW91J3JlIGNvcHlpbmcgaW4gcGF0Y2ggMiwgYXMgd2VsbC4KClllcywgdGhhdCB3YXMg dGhlIGludGVudGlvbi4KCk5vcmFsZi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=