From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD220C54EE9 for ; Wed, 7 Sep 2022 19:51:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 91F6110E85E; Wed, 7 Sep 2022 19:51:53 +0000 (UTC) Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 618D810E85E; Wed, 7 Sep 2022 19:51:51 +0000 (UTC) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 287CwWYV016421; Wed, 7 Sep 2022 19:51:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=lbNjg6mf5bcFwUdUu4JORWd32T51/1ci58XSYrEo4AY=; b=mYqgYkrGNrCm5Hrd6S/iUByxCU0aRmNNaDgPkIxNC+8ZLrIIz9ltEnXbyR/YsLzNyucE JXE2LrMpmREoFTQyIDy08h9f4F6BipUA3SAcUSlZ3gXTsz6zATVCBlJ0rQCMv69WbVEn EghImACtqoZMg5yfesQBfRwYD1KHG1hYWO/kusxZqgCONQ3Ca6Fyl4iffAOA4wAawzhs igDq/By5p+a8ST+2//bMHslgBHV0KOO2ya5whxLzezdwNPBVQ8lKo9gzIxsdDEaE4yFk qFBmV1LGt1bldpneySd/Ule0QuVbabal/AzwutQaoiOH//zjwEeyP6BIYKviAvufnVaZ fw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3jenmjtwsq-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Sep 2022 19:51:47 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 287J6BgB017128 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 7 Sep 2022 19:06:11 GMT Received: from [10.111.169.242] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Wed, 7 Sep 2022 12:06:09 -0700 Message-ID: Date: Wed, 7 Sep 2022 12:06:07 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2 4/5] drm/msm/hdmi: don't take extra reference on PHY device Content-Language: en-US To: Dmitry Baryshkov , Rob Clark , Sean Paul References: <20220826093927.851597-1-dmitry.baryshkov@linaro.org> <20220826093927.851597-5-dmitry.baryshkov@linaro.org> From: Abhinav Kumar In-Reply-To: <20220826093927.851597-5-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: JM_foTwCAIxGxhOUNbA1Tk1COGgdnIUA X-Proofpoint-ORIG-GUID: JM_foTwCAIxGxhOUNbA1Tk1COGgdnIUA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-07_10,2022-09-07_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 suspectscore=0 mlxlogscore=982 mlxscore=0 bulkscore=0 spamscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209070074 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote: > The of_find_device_by_node() already increments the device's usage > count, so there is no need to increment it again using get_device(). > Drop this extra get_device(). > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c > index c298a36f3b42..926274eeee25 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c > @@ -106,7 +106,7 @@ static int msm_hdmi_get_phy(struct hdmi *hdmi) > return -EPROBE_DEFER; > } > > - hdmi->phy_dev = get_device(&phy_pdev->dev); > + hdmi->phy_dev = &phy_pdev->dev; > > return 0; > }