From: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
To: cgel.zte@gmail.com, harry.wentland@amd.com
Cc: sunpeng.li@amd.com, Zeal Robot <zealci@zte.com.cn>,
Xinhui.Pan@amd.com, wenjing.liu@amd.com,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
meenakshikumar.somasundaram@amd.com, airlied@linux.ie,
Jerry.Zuo@amd.com, zhang songyi <zhang.songyi@zte.com.cn>,
dri-devel@lists.freedesktop.org, alexander.deucher@amd.com,
hanghong.ma@amd.com, Jun.Lei@amd.com, christian.koenig@amd.com,
Jimmy.Kizito@amd.com
Subject: Re: [PATCH linux-next] drm/amd/display: Remove the unneeded result variable
Date: Tue, 6 Sep 2022 11:44:53 -0400 [thread overview]
Message-ID: <df28cb7b-f19d-fd8e-d1b7-dd893e3d2c77@amd.com> (raw)
In-Reply-To: <20220902075450.319982-1-zhang.songyi@zte.com.cn>
On 2022-09-02 03:54, cgel.zte@gmail.com wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> Return the enable_link_dp() directly instead of storing it in another
> redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index f9b798b7933c..4ab27e231337 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -2077,11 +2077,7 @@ static enum dc_status enable_link_edp(
> struct dc_state *state,
> struct pipe_ctx *pipe_ctx)
> {
> - enum dc_status status;
> -
> - status = enable_link_dp(state, pipe_ctx);
> -
> - return status;
> + return enable_link_dp(state, pipe_ctx);
> }
>
> static enum dc_status enable_link_dp_mst(
LGTM,
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
and applied to amd-staging-drm-next.
Thanks
Siqueira
prev parent reply other threads:[~2022-09-06 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 7:54 [PATCH linux-next] drm/amd/display: Remove the unneeded result variable cgel.zte
2022-09-06 15:44 ` Rodrigo Siqueira Jordao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df28cb7b-f19d-fd8e-d1b7-dd893e3d2c77@amd.com \
--to=rodrigo.siqueira@amd.com \
--cc=Jerry.Zuo@amd.com \
--cc=Jimmy.Kizito@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=cgel.zte@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hanghong.ma@amd.com \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meenakshikumar.somasundaram@amd.com \
--cc=sunpeng.li@amd.com \
--cc=wenjing.liu@amd.com \
--cc=zealci@zte.com.cn \
--cc=zhang.songyi@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).