From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0310C433ED for ; Fri, 7 May 2021 13:26:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43D5D61076 for ; Fri, 7 May 2021 13:26:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43D5D61076 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A06D6E079; Fri, 7 May 2021 13:26:44 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C5F36E079 for ; Fri, 7 May 2021 13:26:42 +0000 (UTC) Received: from [192.168.1.111] (91-157-208-71.elisa-laajakaista.fi [91.157.208.71]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5CDA3EF; Fri, 7 May 2021 15:26:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1620394000; bh=Y4ZVCz504AX3zFCTILayJKZwb9oWengQbtFqgQe03Ks=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=g4cMR6R+Vzrds2ZDhFTz8PI5fkdtNX98/tJzBPmCIAECKyDC3Pulm6aWC6aZ5M+Ze Y/Uaj0Zehit+f1HZn9nFk7DmxYIG2E4tFqQB7+YP+tDSGHc5WlRx4IisQhzSdcwbdh q185JnEk+E54ws9an2BIWpA+B50D296UqUbTJnUQ= Subject: Re: [PATCHv2] drm/omap: Fix issue with clocks left on after resume To: Tony Lindgren References: <20210428092500.23521-1-tony@atomide.com> <79bea9b8-b2d2-11ec-87a3-34626347e122@ideasonboard.com> From: Tomi Valkeinen Message-ID: Date: Fri, 7 May 2021 16:26:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-omap@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org, Sebastian Reichel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 05/05/2021 14:12, Tony Lindgren wrote: > * Tony Lindgren [210503 12:18]: >> I think we still fix the dispc related issue too, otherwise the parent >> child_count will just keep increasing on each suspend. I check that >> again though. > > After tons more debugging, I found the root cause for the parent child_count > increasing and posted a patch for it at [0] below. > > This means the $subject patch here can be done later on as clean-up to > leave out lots of unnecessary PM runtime calls and simplify the system > suspend :) Great work, thanks! It's always nice when someone else does the tons of debugging ;). I tested the patch you sent, works fine for me. While testing I noticed another problem, which happens also without your fix: go to suspend with HDMI connected, remove the cable, resume the board -> boom. I didn't debug that yet. Tomi