From: "Arnd Bergmann" <arnd@arndb.de>
To: "Daniel Vetter" <daniel@ffwll.ch>,
"Markuss Broks" <markuss.broks@gmail.com>
Cc: linux-fbdev@vger.kernel.org, linux-efi@vger.kernel.org,
linux-doc@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
dri-devel@lists.freedesktop.org,
Wei Ming Chen <jj251510319013@gmail.com>,
phone-devel@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Javier Martinez Canillas <javierm@redhat.com>,
linux-serial@vger.kernel.org, Borislav Petkov <bp@suse.de>,
Kees Cook <keescook@chromium.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
~postmarketos/upstreaming@lists.sr.ht,
Michal Suchanek <msuchanek@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Helge Deller <deller@gmx.de>
Subject: Re: [PATCH v2 3/3] efi: earlycon: Add support for generic framebuffers and move to console subsystem
Date: Wed, 07 Sep 2022 10:22:03 +0200 [thread overview]
Message-ID: <e2e2a0c7-d859-4255-94b6-b030aa9dc277@www.fastmail.com> (raw)
In-Reply-To: <YxfBGDg6YkIQ6Wzq@phenom.ffwll.local>
On Tue, Sep 6, 2022, at 11:52 PM, Daniel Vetter wrote:
> On Sat, Aug 06, 2022 at 07:32:24PM +0300, Markuss Broks wrote:
>
> Ok I have a more fundamental issue with this than the lack of proper patch
> splitting I mentioned in the other thread.
>
> This is the wrong place.
>
> drivers/video/console is about the various vt console implementations,
> which supply a struct consw to con_register_driver.
You are right, that was my mistake. The original patch was for
drivers/video/fbdev/, and I suggested moving it out of there because
it does not depend on the fbdev subsystem, but clearly my suggestions
of drivers/video/console was equally wrong.
> This otoh is an (early) kernel/printk console implemented using struct
> console. Totally different thing, and really shouldn't end up in
> drivers/video/console imo. Somewhere in drivers/firmware might still be
> the best place, the sysfb stuff is also there. Maybe
> drivers/firmware/sysfb_earlycon.c?
drivers/firmware/ is better but doesn't sound great to me either,
since one important thing the patch does is to not make it depend
on EFI firmware or BIOS style screen_info any more.
Maybe drivers/tty/earlycon_simplefb.c would work better, keeping
it close to the earlycon base support in drivers/tty/serial/,
the vt console and the old simplefb driver/, without tying to too
closely to fbdev of UEFI.
Arnd
next prev parent reply other threads:[~2022-09-07 8:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 16:32 [PATCH v2 0/3] Add generic framebuffer support to EFI earlycon driver Markuss Broks
2022-08-06 16:32 ` [PATCH v2 1/3] drivers: serial: earlycon: Correct argument name Markuss Broks
2022-08-06 16:56 ` Andy Shevchenko
2022-08-08 1:28 ` kernel test robot
2022-08-08 15:55 ` Rob Herring
2022-08-06 16:32 ` [PATCH v2 2/3] drivers: serial: earlycon: Pass device-tree node Markuss Broks
2022-08-06 16:32 ` [PATCH v2 3/3] efi: earlycon: Add support for generic framebuffers and move to console subsystem Markuss Broks
2022-08-06 21:37 ` Andy Shevchenko
2022-08-07 13:16 ` kernel test robot
2022-08-14 0:01 ` kernel test robot
2022-08-14 7:04 ` kernel test robot
2022-09-06 21:52 ` Daniel Vetter
2022-09-07 6:55 ` Thomas Zimmermann
2022-09-07 8:22 ` Arnd Bergmann [this message]
2022-09-06 16:54 ` [PATCH v2 0/3] Add generic framebuffer support to EFI earlycon driver Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2e2a0c7-d859-4255-94b6-b030aa9dc277@www.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=jirislaby@kernel.org \
--cc=jj251510319013@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=msuchanek@suse.de \
--cc=paulmck@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=tony@atomide.com \
--cc=tzimmermann@suse.de \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).