From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sandor Yu <Sandor.yu@nxp.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
andrzej.hajda@intel.com, neil.armstrong@linaro.org,
robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com,
jonas@kwiboo.se, jernej.skrabec@gmail.com, kishon@ti.com,
vkoul@kernel.org
Cc: oliver.brown@nxp.com, krzysztof.kozlowski+dt@linaro.org,
sam@ravnborg.org, jani.nikula@intel.com, tzimmermann@suse.de,
s.hauer@pengutronix.de, javierm@redhat.com,
penguin-kernel@I-love.SAKURA.ne.jp, robh+dt@kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org,
p.yadav@ti.com, maxime@cerno.tech
Subject: Re: [v2 07/10] dts-bindings: phy: Add Cadence HDP-TX DP PHY bindings
Date: Fri, 4 Nov 2022 09:45:42 -0400 [thread overview]
Message-ID: <e2ea63b4-3be1-0a5a-9618-8495026ccead@linaro.org> (raw)
In-Reply-To: <bea6eb888717e1c0a3efc58761b0e75e4104f737.1667463263.git.Sandor.yu@nxp.com>
On 04/11/2022 02:44, Sandor Yu wrote:
> Add bindings for Cadence HDP-TX DisplayPort PHY.
>
> Signed-off-by: Sandor Yu <Sandor.yu@nxp.com>
> ---
> .../bindings/phy/phy-cadence-hdptx-dp.yaml | 70 +++++++++++++++++++
> 1 file changed, 70 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/phy-cadence-hdptx-dp.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-hdptx-dp.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-hdptx-dp.yaml
> new file mode 100644
> index 000000000000..ab6f4e25c425
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/phy-cadence-hdptx-dp.yaml
Use filename matching compatible, so cdns,hdptx-dp-phy.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/phy/phy-cadence-hdptx-dp.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
Drop quotes from both lines.
> +
> +title: Cadence HDP(HDMI/DisplayPort) TX PHY for DisplayPort protocol binding
Drop binding
> +
> +description:
> + This binding describes the Cadence HDP-TX PHY for DispalyPort protocol.
Drop "This binding describes"
> +
> +maintainers:
> + - Sandor Yu <sandor.yu@nxp.com>
> +
> +properties:
> + compatible:
> + enum:
> + - cdns,hdptx-dp-phy
> +
> + reg:
> + description:
> + Offset of Cadence HDPTX APB configuration registers.
Same comments as usual.
> +
> + clocks:
> + items:
> + description:
> + PHY reference clock. Must contain an entry in clock-names.
Drop "Must contain an entry in clock-names."
> +
> + clock-names:
> + items:
> + - const: refclk
> +
> + "#phy-cells":
> + const: 0
> +
> + cdns,num-lanes:
> + description:
> + Number of lanes.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [1, 2, 3, 4]
> + default: 4
> +
> + cdns,max-bit-rate:
> + description:
> + Maximum DisplayPort link bit rate to use, in Mbps
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [2160, 2430, 2700, 3240, 4320, 5400]
> + default: 5400
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - "#phy-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/phy/phy.h>
> + dp_phy: dp_phy@32c00000 {
phy
(and no underscores in node names)
> + compatible = "cdns,hdptx-dp-phy";
> + reg = <0x32c00000 0x100000>;
> + #phy-cells = <0>;
> + clocks = <&hdmi_phy_27m>;
> + clock-names = "refclk";
> + cdns,num-lanes = <4>;
> + cdns,max-bit-rate = <5400>;
> + };
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-04 13:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 6:44 [v2 0/10] Initial support for Cadence MHDP(HDMI/DP) for i.MX8MQ Sandor Yu
2022-11-04 6:44 ` [v2 01/10] drm: bridge: cadence: convert mailbox functions to macro functions Sandor Yu
2022-11-04 6:44 ` [v2 02/10] dts-bingings: display: bridge: Add MHDP HDMI bindings for i.MX8MQ Sandor Yu
2022-11-04 13:42 ` Krzysztof Kozlowski
2022-11-07 20:14 ` Rob Herring
2022-11-04 6:44 ` [v2 03/10] drm: bridge: cadence: Add MHDP DP driver " Sandor Yu
2022-11-04 6:44 ` [v2 04/10] phy: Add HDMI configuration options Sandor Yu
2022-11-04 6:44 ` [v2 05/10] dts-bindings: display: bridge: Add MHDP DP bindings for i.MX8MQ Sandor Yu
2022-11-04 13:43 ` Krzysztof Kozlowski
2022-11-04 6:44 ` [v2 06/10] drm: bridge: cadence: Add MHDP HDMI driver " Sandor Yu
2022-11-08 13:16 ` Alexander Stein
2022-11-09 13:26 ` [EXT] " Sandor Yu
2022-11-10 15:43 ` Alexander Stein
2022-11-14 7:53 ` Sandor Yu
2022-11-04 6:44 ` [v2 07/10] dts-bindings: phy: Add Cadence HDP-TX DP PHY bindings Sandor Yu
2022-11-04 13:45 ` Krzysztof Kozlowski [this message]
2022-11-04 6:44 ` [v2 08/10] phy: cadence: Add driver for HDP-TX DisplyPort PHY Sandor Yu
2022-11-04 6:44 ` [v2 09/10] dts-bindings: phy: Add Cadence HDP-TX HDMI PHY bindings Sandor Yu
2022-11-04 13:46 ` Krzysztof Kozlowski
2022-11-04 6:45 ` [v2 10/10] phy: cadence: Add driver for HDP-TX HDMI PHY Sandor Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2ea63b4-3be1-0a5a-9618-8495026ccead@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=Sandor.yu@nxp.com \
--cc=andrzej.hajda@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=maxime@cerno.tech \
--cc=neil.armstrong@linaro.org \
--cc=oliver.brown@nxp.com \
--cc=p.yadav@ti.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).