From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kazlauskas, Nicholas" Subject: Re: [PATCH 1/5] drm: don't block fb changes for async plane updates Date: Mon, 4 Mar 2019 15:46:49 +0000 Message-ID: References: <20190304144909.6267-1-helen.koike@collabora.com> <20190304144909.6267-2-helen.koike@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-eopbgr790085.outbound.protection.outlook.com [40.107.79.85]) by gabe.freedesktop.org (Postfix) with ESMTPS id A2CF589C6A for ; Mon, 4 Mar 2019 15:46:52 +0000 (UTC) In-Reply-To: <20190304144909.6267-2-helen.koike@collabora.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Helen Koike , "dri-devel@lists.freedesktop.org" Cc: =?utf-8?B?U3TDqXBoYW5lIE1hcmNoZXNpbg==?= , Sean Paul , David Airlie , "daniel.vetter@ffwll.ch" , "linux-kernel@vger.kernel.org" , Tomasz Figa , "boris.brezillon@collabora.com" , "kernel@collabora.com" List-Id: dri-devel@lists.freedesktop.org T24gMy80LzE5IDk6NDkgQU0sIEhlbGVuIEtvaWtlIHdyb3RlOg0KPiBJbiB0aGUgY2FzZSBvZiBh IG5vcm1hbCBzeW5jIHVwZGF0ZSwgdGhlIHByZXBhcmF0aW9uIG9mIGZyYW1lYnVmZmVycyAoYmUN Cj4gaXQgY2FsbGluZyBkcm1fYXRvbWljX2hlbHBlcl9wcmVwYXJlX3BsYW5lcygpIG9yIGRvaW5n IHNldHVwcyB3aXRoDQo+IGRybV9mcmFtZWJ1ZmZlcl9nZXQoKSkgYXJlIHBlcmZvcm1lZCBpbiB0 aGUgbmV3X3N0YXRlIGFuZCB0aGUgcmVzcGVjdGl2ZQ0KPiBjbGVhbnVwcyBhcmUgcGVyZm9ybWVk IGluIHRoZSBvbGRfc3RhdGUuDQo+IA0KPiBJbiB0aGUgY2FzZSBvZiBhc3luYyB1cGRhdGVzLCB0 aGUgcHJlcGFyYXRpb24gaXMgYWxzbyBkb25lIGluIHRoZQ0KPiBuZXdfc3RhdGUgYnV0IHRoZSBj bGVhbnVwcyBhcmUgZG9uZSBpbiB0aGUgbmV3X3N0YXRlIChiZWNhdXNlIHVwZGF0ZXMNCj4gYXJl IHBlcmZvcm1lZCBpbiBwbGFjZSwgaS5lLiBpbiB0aGUgY3VycmVudCBzdGF0ZSkuDQo+IA0KPiBU aGUgY3VycmVudCBjb2RlIGJsb2NrcyBhc3luYyB1ZHBhdGVzIHdoZW4gdGhlIGZiIGlzIGNoYW5n ZWQsIHR1cm5pbmcNCj4gYXN5bmMgdXBkYXRlcyBpbnRvIHN5bmMgdXBkYXRlcywgc2xvd2luZyBk b3duIGN1cnNvciB1cGRhdGVzIGFuZA0KPiBpbnRyb2R1Y2luZyByZWdyZXNzaW9ucyBpbiBpZ3Qg dGVzdHMgd2l0aCBlcnJvcnMgb2YgdHlwZToNCj4gDQo+ICJDUklUSUNBTDogY29tcGxldGVkIDk3 IGN1cnNvciB1cGRhdGVkIGluIGEgcGVyaW9kIG9mIDMwIGZsaXBzLCB3ZQ0KPiBleHBlY3QgdG8g Y29tcGxldGUgYXBwcm94aW1hdGVseSAxNTM2MCB1cGRhdGVzLCB3aXRoIHRoZSB0aHJlc2hvbGQg c2V0DQo+IGF0IDc2ODAiDQo+IA0KPiBGYiBjaGFuZ2VzIGluIGFzeW5jIHVwZGF0ZXMgd2VyZSBw cmV2ZW50ZWQgdG8gYXZvaWQgdGhlIGZvbGxvd2luZyBzY2VuYXJpbzoNCj4gDQo+IC0gQXN5bmMg dXBkYXRlLCBvbGRmYiA9IE5VTEwsIG5ld2ZiID0gZmIxLCBwcmVwYXJlIGZiMSwgY2xlYW51cCBm YjENCj4gLSBBc3luYyB1cGRhdGUsIG9sZGZiID0gZmIxLCBuZXdmYiA9IGZiMiwgcHJlcGFyZSBm YjIsIGNsZWFudXAgZmIyDQo+IC0gTm9uLWFzeW5jIGNvbW1pdCwgb2xkZmIgPSBmYjIsIG5ld2Zi ID0gZmIxLCBwcmVwYXJlIGZiMSwgY2xlYW51cCBmYjIgKHdyb25nKQ0KPiBXaGVyZSB3ZSBoYXZl IGEgc2luZ2xlIGNhbGwgdG8gcHJlcGFyZSBmYjIgYnV0IGRvdWJsZSBjbGVhbnVwIGNhbGwgdG8g ZmIyLg0KPiANCj4gVG8gc29sdmUgdGhlIGFib3ZlIHByb2JsZW1zLCBpbnN0ZWFkIG9mIGJsb2Nr aW5nIGFzeW5jIGZiIGNoYW5nZXMsIHdlDQo+IHBsYWNlIHRoZSBvbGQgZnJhbWVidWZmZXIgaW4g dGhlIG5ld19zdGF0ZSBvYmplY3QsIHNvIHdoZW4gdGhlIGNvZGUNCj4gcGVyZm9ybXMgY2xlYW51 cHMgaW4gdGhlIG5ld19zdGF0ZSBpdCB3aWxsIGNsZWFudXAgdGhlIG9sZF9mYiBhbmQgd2UNCj4g d2lsbCBoYXZlIHRoZSBmb2xsb3dpbmcgc2NlbmFyaW8gaW5zdGVhZDoNCj4gDQo+IC0gQXN5bmMg dXBkYXRlLCBvbGRmYiA9IE5VTEwsIG5ld2ZiID0gZmIxLCBwcmVwYXJlIGZiMSwgbm8gY2xlYW51 cA0KPiAtIEFzeW5jIHVwZGF0ZSwgb2xkZmIgPSBmYjEsIG5ld2ZiID0gZmIyLCBwcmVwYXJlIGZi MiwgY2xlYW51cCBmYjENCj4gLSBOb24tYXN5bmMgY29tbWl0LCBvbGRmYiA9IGZiMiwgbmV3ZmIg PSBmYjEsIHByZXBhcmUgZmIxLCBjbGVhbnVwIGZiMg0KPiANCj4gV2hlcmUgY2FsbHMgdG8gcHJl cGFyZS9jbGVhbnVwIGFyZSBiYWxsYW5jZWQuDQo+IA0KPiBDYzogPHN0YWJsZUB2Z2VyLmtlcm5l bC5vcmc+ICMgdjQuMTQrOiAyNWRjMTk0YjM0ZGQ6IGRybTogQmxvY2sgZmIgY2hhbmdlcyBmb3Ig YXN5bmMgcGxhbmUgdXBkYXRlcw0KPiBGaXhlczogMjVkYzE5NGIzNGRkICgiZHJtOiBCbG9jayBm YiBjaGFuZ2VzIGZvciBhc3luYyBwbGFuZSB1cGRhdGVzIikNCj4gU3VnZ2VzdGVkLWJ5OiBCb3Jp cyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBjb2xsYWJvcmEuY29tPg0KPiBTaWduZWQtb2Zm LWJ5OiBIZWxlbiBLb2lrZSA8aGVsZW4ua29pa2VAY29sbGFib3JhLmNvbT4NCj4gDQo+IC0tLQ0K PiBIZWxsbywNCj4gDQo+IEFzIG1lbnRpb25lZCBpbiB0aGUgY292ZXIgbGV0dGVyLA0KPiBJIHRl c3RlZCBvbiB0aGUgcm9ja2NoaXAgYW5kIG9uIGk5MTUgKHdpdGggYSBwYXRjaCBJIGFtIHN0aWxs IHdvcmtpbmcgb24gZm9yDQo+IHJlcGxhY2luZyBjdXJzb3JzIGJ5IGFzeW5jIHVwZGF0ZSksIHdp dGggaWd0IHBsYW5lX2N1cnNvcl9sZWdhY3kgYW5kDQo+IGttc19jdXJzb3JfbGVnYWN5IGFuZCBJ IGRpZG4ndCBzZWUgYW55IHJlZ3Jlc3Npb25zLg0KPiBJIGNvdWxkbid0IHRlc3Qgb24gTVNNIGFu ZCBBTUQgYmVjYXVzZSBJIGRvbid0IGhhdmUgdGhlIGhhcmR3YXJlIChhbmQgSSBhbQ0KPiBoYXZp bmcgc29tZSBpc3N1ZXMgdGVzdGluZyBvbiB2YzQpIGFuZCBJIHdvdWxkIGFwcHJlY2lhdGUgaWYg YW55b25lIGNvdWxkIGhlbHANCj4gbWUgdGVzdGluZyB0aG9zZS4NCj4gDQo+IEkgYWxzbyB0aGlu ayBpdCB3b3VsZCBiZSBhIGJldHRlciBzb2x1dGlvbiBpZiwgaW5zdGVhZCBvZiBoYXZpbmcgYXN5 bmMNCj4gdG8gZG8gaW4tcGxhY2UgdXBkYXRlcyBpbiB0aGUgY3VycmVudCBzdGF0ZSwgdGhlIGFz eW5jIHBhdGggc2hvdWxkIGJlDQo+IGVxdWl2YWxlbnQgdG8gYSBzeW5jcm9ub3VzIHVwZGF0ZSwg aS5lLiwgbW9kaWZ5aW5nIG5ld19zdGF0ZSBhbmQNCj4gcGVyZm9ybWluZyBhIGZsaXANCj4gSU1I TywgdGhlIG9ubHkgZGlmZmVyZW5jZSBiZXR3ZWVuIHN5bmMgYW5kIGFzeW5jIHNob3VsZCBiZSB0 aGF0IGFzeW5jIHVwZGF0ZQ0KPiBkb2Vzbid0IHdhaXQgZm9yIHZibGFuayBhbmQgYXBwbGllcyB0 aGUgY2hhbmdlcyBpbW1lZGl0YWxseSB0byB0aGUgaHcsDQo+IGJ1dCB0aGUgY29kZSBwYXRoIGNv dWxkIGJlIGFsbW9zdCB0aGUgc2FtZS4NCj4gQnV0IGZvciBub3cgSSB0aGluayB0aGlzIHNvbHV0 aW9uIGlzIG9rIChzd2FwaW5nIG5ld19mYi9vbGRfZmIpLCBhbmQNCj4gdGhlbiB3ZSBjYW4gYWRq dXN0IHRoaW5ncyBsaXR0bGUgYnkgbGl0dGxlLCB3aGF0IGRvIHlvdSB0aGluaz8NCj4gDQo+IFRo YW5rcyENCj4gSGVsZW4NCj4gDQo+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVy LmMgfCAyMCArKysrKysrKysrLS0tLS0tLS0tLQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNl cnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hl bHBlci5jDQo+IGluZGV4IDU0MGE3N2EyYWRlOS4uZTdlYjk2ZjFlZmMyIDEwMDY0NA0KPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYw0KPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYw0KPiBAQCAtMTYwOCwxNSArMTYwOCw2IEBAIGludCBk cm1fYXRvbWljX2hlbHBlcl9hc3luY19jaGVjayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LA0KPiAg IAkgICAgb2xkX3BsYW5lX3N0YXRlLT5jcnRjICE9IG5ld19wbGFuZV9zdGF0ZS0+Y3J0YykNCj4g ICAJCXJldHVybiAtRUlOVkFMOw0KPiAgIA0KPiAtCS8qDQo+IC0JICogRklYTUU6IFNpbmNlIHBy ZXBhcmVfZmIgYW5kIGNsZWFudXBfZmIgYXJlIGFsd2F5cyBjYWxsZWQgb24NCj4gLQkgKiB0aGUg bmV3X3BsYW5lX3N0YXRlIGZvciBhc3luYyB1cGRhdGVzIHdlIG5lZWQgdG8gYmxvY2sgZnJhbWVi dWZmZXINCj4gLQkgKiBjaGFuZ2VzLiBUaGlzIHByZXZlbnRzIHVzZSBvZiBhIGZiIHRoYXQncyBi ZWVuIGNsZWFuZWQgdXAgYW5kDQo+IC0JICogZG91YmxlIGNsZWFudXBzIGZyb20gb2NjdXJpbmcu DQo+IC0JICovDQo+IC0JaWYgKG9sZF9wbGFuZV9zdGF0ZS0+ZmIgIT0gbmV3X3BsYW5lX3N0YXRl LT5mYikNCj4gLQkJcmV0dXJuIC1FSU5WQUw7DQo+IC0NCj4gICAJZnVuY3MgPSBwbGFuZS0+aGVs cGVyX3ByaXZhdGU7DQo+ICAgCWlmICghZnVuY3MtPmF0b21pY19hc3luY191cGRhdGUpDQo+ICAg CQlyZXR1cm4gLUVJTlZBTDsNCj4gQEAgLTE2NTcsNiArMTY0OCw5IEBAIHZvaWQgZHJtX2F0b21p Y19oZWxwZXJfYXN5bmNfY29tbWl0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsDQo+ICAgCWludCBp Ow0KPiAgIA0KPiAgIAlmb3JfZWFjaF9uZXdfcGxhbmVfaW5fc3RhdGUoc3RhdGUsIHBsYW5lLCBw bGFuZV9zdGF0ZSwgaSkgew0KPiArCQlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpuZXdfZmIgPSBw bGFuZV9zdGF0ZS0+ZmI7DQo+ICsJCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKm9sZF9mYiA9IHBs YW5lLT5zdGF0ZS0+ZmI7DQo+ICsNCj4gICAJCWZ1bmNzID0gcGxhbmUtPmhlbHBlcl9wcml2YXRl Ow0KPiAgIAkJZnVuY3MtPmF0b21pY19hc3luY191cGRhdGUocGxhbmUsIHBsYW5lX3N0YXRlKTsN Cj4gICANCj4gQEAgLTE2NjUsMTEgKzE2NTksMTcgQEAgdm9pZCBkcm1fYXRvbWljX2hlbHBlcl9h c3luY19jb21taXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwNCj4gICAJCSAqIHBsYW5lLT5zdGF0 ZSBpbi1wbGFjZSwgbWFrZSBzdXJlIGF0IGxlYXN0IGNvbW1vbg0KPiAgIAkJICogcHJvcGVydGll cyBoYXZlIGJlZW4gcHJvcGVybHkgdXBkYXRlZC4NCj4gICAJCSAqLw0KPiAtCQlXQVJOX09OX09O Q0UocGxhbmUtPnN0YXRlLT5mYiAhPSBwbGFuZV9zdGF0ZS0+ZmIpOw0KPiArCQlXQVJOX09OX09O Q0UocGxhbmUtPnN0YXRlLT5mYiAhPSBuZXdfZmIpOw0KPiAgIAkJV0FSTl9PTl9PTkNFKHBsYW5l LT5zdGF0ZS0+Y3J0Y194ICE9IHBsYW5lX3N0YXRlLT5jcnRjX3gpOw0KPiAgIAkJV0FSTl9PTl9P TkNFKHBsYW5lLT5zdGF0ZS0+Y3J0Y195ICE9IHBsYW5lX3N0YXRlLT5jcnRjX3kpOw0KPiAgIAkJ V0FSTl9PTl9PTkNFKHBsYW5lLT5zdGF0ZS0+c3JjX3ggIT0gcGxhbmVfc3RhdGUtPnNyY194KTsN Cj4gICAJCVdBUk5fT05fT05DRShwbGFuZS0+c3RhdGUtPnNyY195ICE9IHBsYW5lX3N0YXRlLT5z cmNfeSk7DQo+ICsNCj4gKwkJLyoNCj4gKwkJICogTWFrZSBzdXJlIHRoZSBGQnMgaGF2ZSBiZWVu IHN3YXBwZWQgc28gdGhhdCBjbGVhbnVwcyBpbiB0aGUNCj4gKwkJICogbmV3X3N0YXRlIHBlcmZv cm1zIGEgY2xlYW51cCBpbiB0aGUgb2xkIEZCLg0KPiArCQkgKi8NCj4gKwkJV0FSTl9PTl9PTkNF KHBsYW5lX3N0YXRlLT5mYiAhPSBvbGRfZmIpOw0KDQpJIHBlcnNvbmFsbHkgdGhpbmsgdGhpcyBh cHByb2FjaCBpcyBmaW5lIGFuZCB0aGUgV0FSTl9PTiBzIGFyZSBnb29kIGZvciANCmNhdGNoaW5n IGRyaXZlcnMgdGhhdCB3YW50IHRvIHVzZSB0aGVzZSBpbiB0aGUgZnV0dXJlLg0KDQpJIGRvIHRo aW5rIGl0IHdvdWxkIGJlIGdvb2QgdG8gYWRkIHNvbWV0aGluZyB0byB0aGUgZnVuY3Rpb24gZG9j cyB0aGF0IA0KZXhwbGFpbnMgdGhpcyByZXF1aXJlbWVudCBhbmQgdGhlIGlzc3VlIHRoYXQgaXQg YWRkcmVzc2VzLiBJdCdzIGEgbGl0dGxlIA0KdW5pbnR1aXRpdmUgdG8gcmVxdWlyZSB0aGF0IHRo ZSBvbGQgZmIgaXMgcGxhY2VkIGludG8gdGhlIG5ldyBzdGF0ZSwgYnV0IA0KaXQgbWFrZXMgc2Vu c2UgYXMgYSB3b3JrYXJvdW5kIHRvIHRoaXMgcHJvYmxlbS4NCg0KTmljaG9sYXMgS2F6bGF1c2th cw0KDQo+ICAgCX0NCj4gICB9DQo+ICAgRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9h c3luY19jb21taXQpOw0KPiANCg0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVs