From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5925EC433FE for ; Wed, 2 Nov 2022 22:58:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AB89710E4AA; Wed, 2 Nov 2022 22:58:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id C09E510E4AA for ; Wed, 2 Nov 2022 22:58:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=dxk7K79E1a8j7qASi8UQ2LttUIuZKzMJZffkVtXcjv8=; b=iWBbbhrEXXa6MQNABq2X7pMhEs inJT+scZCXfLnDU7VWcfXsxYgqGktw8wWcIxHvwAJb+JpXzA1z5KOgv62IBCqoVvt6knYk6QIgZtV 0kq+sCGrFenv7jgBUkHfptnS9NjeIQbaNxLBe6qPukDj9fAnHLGTZrJo65sGYORxLFPqxmtC2nFOL j4UODS7DwOVJa3BM8exn1O5tJGX8kXfibP7pJ4xiqsECVEtF1rprd8b77mUyCUrCAmRKfTOI3znQT BOVq009EEtWksI3G95Dbcf9iYjnp8sYZXSumod9w+gA+QJRi7Nla/ze0WnfU9ysXljPJ8jJ0uepat TNn2gSOA==; Received: from [2601:1c2:d80:3110:e65e:37ff:febd:ee53] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqMga-00EpZH-1q; Wed, 02 Nov 2022 22:58:16 +0000 Message-ID: Date: Wed, 2 Nov 2022 15:58:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major Content-Language: en-US To: Oded Gabbay , David Airlie , Daniel Vetter , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jason Gunthorpe , John Hubbard , Alex Deucher References: <20221102203405.1797491-1-ogabbay@kernel.org> <20221102203405.1797491-2-ogabbay@kernel.org> From: Randy Dunlap In-Reply-To: <20221102203405.1797491-2-ogabbay@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , Jacek Lawrynowicz , Jeffrey Hugo , Jiho Chu , Christoph Hellwig , Thomas Zimmermann , Kevin Hilman , Yuji Ishikawa , Maciej Kwapulinski , Jagan Teki Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 11/2/22 13:34, Oded Gabbay wrote: > diff --git a/drivers/accel/Kconfig b/drivers/accel/Kconfig > new file mode 100644 > index 000000000000..282ea24f90c5 > --- /dev/null > +++ b/drivers/accel/Kconfig > @@ -0,0 +1,24 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# Compute Acceleration device configuration > +# > +# This framework provides support for compute acceleration devices, such > +# as, but not limited to, Machine-Learning and Deep-Learning acceleration > +# devices > +# > +menuconfig ACCEL > + tristate "Compute Acceleration Framework" > + depends on DRM > + help > + Framework for device drivers of compute acceleration devices, such > + as, but not limited to, Machine-Learning and Deep-Learning > + acceleration devices. > + If you say Y here, you need to select the module that's right for > + your acceleration device from the list below. > + This framework is integrated with the DRM subsystem as compute > + accelerators and GPUs share a lot in common and can use almost the > + same infrastructure code. > + Having said that, acceleration devices will have a different > + major number than GPUs, and will be exposed to user-space using > + different device files, called accel/accel* (in /dev, sysfs > + and debugfs) Please add a period at the end of the help text. + and debugfs). -- ~Randy