From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A76ACC4338F for ; Fri, 23 Jul 2021 11:21:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D2F0608FE for ; Fri, 23 Jul 2021 11:21:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D2F0608FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 71B956FADE; Fri, 23 Jul 2021 11:21:20 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id F22F06FADE; Fri, 23 Jul 2021 11:21:18 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10053"; a="233697310" X-IronPort-AV: E=Sophos;i="5.84,263,1620716400"; d="scan'208";a="233697310" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2021 04:21:17 -0700 X-IronPort-AV: E=Sophos;i="5.84,263,1620716400"; d="scan'208";a="502479554" Received: from mrapopor-mobl.ger.corp.intel.com (HELO [10.213.214.117]) ([10.213.214.117]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2021 04:21:13 -0700 Subject: Re: [Intel-gfx] [RFC 0/8] Per client GPU stats From: Tvrtko Ursulin To: Intel-gfx@lists.freedesktop.org References: <20210715091820.1613726-1-tvrtko.ursulin@linux.intel.com> Organization: Intel Corporation UK Plc Message-ID: Date: Fri, 23 Jul 2021 12:21:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210715091820.1613726-1-tvrtko.ursulin@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Christian_K=c3=b6nig?= , dri-devel@lists.freedesktop.org, "Nieto, David M" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 15/07/2021 10:18, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Same old work but now rebased and series ending with some DRM docs proposing > the common specification which should enable nice common userspace tools to be > written. > > For the moment I only have intel_gpu_top converted to use this and that seems to > work okay. > > v2: > * Added prototype of possible amdgpu changes and spec updates to align with the > common spec. Not much interest for the common specification? For reference I've just posted the intel-gpu-top adaptation required to parse it here: https://patchwork.freedesktop.org/patch/446041/?series=90464&rev=2. Note that this is not attempting to be a vendor agnostic tool but is adding per client data to existing i915 tool which uses PMU counters for global stats. intel-gpu-top: Intel Skylake (Gen9) @ /dev/dri/card0 - 335/ 339 MHz; 10% RC6; 1.24/ 4.18 W; 527 irqs/s IMC reads: 3297 MiB/s IMC writes: 2767 MiB/s ENGINES BUSY MI_SEMA MI_WAIT Render/3D 78.74% |██████████████████████████████████████████████████████████████████████████▏ | 0% 0% Blitter 0.00% | | 0% 0% Video 0.00% | | 0% 0% VideoEnhance 0.00% | | 0% 0% PID NAME Render/3D Blitter Video VideoEnhance 10202 neverball |███████████████▎ || || || | 5665 Xorg |███████▍ || || || | 5679 xfce4-session | || || || | 5772 ibus-ui-gtk3 | || || || | 5775 ibus-extension- | || || || | 5777 ibus-x11 | || || || | 5823 xfwm4 | || || || | Regards, Tvrtko > Tvrtko Ursulin (8): > drm/i915: Explicitly track DRM clients > drm/i915: Make GEM contexts track DRM clients > drm/i915: Track runtime spent in closed and unreachable GEM contexts > drm/i915: Track all user contexts per client > drm/i915: Track context current active time > drm: Document fdinfo format specification > drm/i915: Expose client engine utilisation via fdinfo > drm/amdgpu: Convert to common fdinfo format > > Documentation/gpu/amdgpu.rst | 26 ++++ > Documentation/gpu/drm-usage-stats.rst | 108 +++++++++++++ > Documentation/gpu/i915.rst | 27 ++++ > Documentation/gpu/index.rst | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 18 ++- > drivers/gpu/drm/i915/Makefile | 5 +- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 42 ++++- > .../gpu/drm/i915/gem/i915_gem_context_types.h | 6 + > drivers/gpu/drm/i915/gt/intel_context.c | 27 +++- > drivers/gpu/drm/i915/gt/intel_context.h | 15 +- > drivers/gpu/drm/i915/gt/intel_context_types.h | 24 ++- > .../drm/i915/gt/intel_execlists_submission.c | 23 ++- > .../gpu/drm/i915/gt/intel_gt_clock_utils.c | 4 + > drivers/gpu/drm/i915/gt/intel_lrc.c | 27 ++-- > drivers/gpu/drm/i915/gt/intel_lrc.h | 24 +++ > drivers/gpu/drm/i915/gt/selftest_lrc.c | 10 +- > drivers/gpu/drm/i915/i915_drm_client.c | 143 ++++++++++++++++++ > drivers/gpu/drm/i915/i915_drm_client.h | 66 ++++++++ > drivers/gpu/drm/i915/i915_drv.c | 9 ++ > drivers/gpu/drm/i915/i915_drv.h | 5 + > drivers/gpu/drm/i915/i915_gem.c | 21 ++- > drivers/gpu/drm/i915/i915_gpu_error.c | 9 +- > drivers/gpu/drm/i915/i915_gpu_error.h | 2 +- > 23 files changed, 581 insertions(+), 61 deletions(-) > create mode 100644 Documentation/gpu/drm-usage-stats.rst > create mode 100644 drivers/gpu/drm/i915/i915_drm_client.c > create mode 100644 drivers/gpu/drm/i915/i915_drm_client.h >