From: "Iddamsetty, Aravind" <aravind.iddamsetty@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/mtl: Media GT and Render GT share common GGTT
Date: Mon, 7 Nov 2022 19:43:59 +0530 [thread overview]
Message-ID: <e7658756-aee3-5d29-bb8e-6d652cc89c88@intel.com> (raw)
In-Reply-To: <Y2AJ6yybXsknyUcH@mdroper-desk1.amr.corp.intel.com>
On 31-10-2022 23:16, Matt Roper wrote:
> On Mon, Oct 31, 2022 at 06:01:11PM +0530, Aravind Iddamsetty wrote:
>> On XE_LPM+ platforms the media engines are carved out into a separate
>> GT but have a common GGTMMADR address range which essentially makes
>> the GGTT address space to be shared between media and render GT.
>
<snip>
>>
>> int intel_gt_init_mmio(struct intel_gt *gt)
>> @@ -965,6 +973,9 @@ int intel_gt_tiles_init(struct drm_i915_private *i915)
>> int ret;
>>
>> for_each_gt(gt, i915, id) {
>> + if (GRAPHICS_VER(i915) >= 8)
>> + setup_private_pat(gt);
>> +
>
> Since the term "tile" is used for PVC-style remote tiles (which we have
> some framework for, but haven't enabled yet), it seems confusing to have
> the PAT setup for all GTs (including the standalone media GT) in a
> function called intel_gt_tiles_init(). Maybe we should also have a prep
> patch that renames this function if we're going to start doing non-tile
> things in here too?
But isn't GT and Tile used interchangeably. Also, Could you please
elaborate what do you mean by non tile related things here and as i
understand PAT are per GT registers and in case of SA Media the
gsi_offset get added.
>
>> ret = intel_gt_probe_lmem(gt);
>> if (ret)
>> return ret;
<snip>
Thanks,
Aravind.
next prev parent reply other threads:[~2022-11-07 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 12:31 [PATCH] drm/i915/mtl: Media GT and Render GT share common GGTT Aravind Iddamsetty
2022-10-31 17:46 ` Matt Roper
2022-11-07 14:13 ` Iddamsetty, Aravind [this message]
2022-11-07 23:35 ` Matt Roper
2022-11-09 11:22 ` Iddamsetty, Aravind
2022-11-04 7:05 ` [Intel-gfx] " Lucas De Marchi
2022-11-04 8:08 ` Iddamsetty, Aravind
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7658756-aee3-5d29-bb8e-6d652cc89c88@intel.com \
--to=aravind.iddamsetty@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).