dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	alexander.deucher@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
	daniel@ffwll.ch, javierm@redhat.com
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 00/10] drm/radeon: Convert fbdev to DRM client
Date: Fri, 17 Mar 2023 09:53:20 +0100	[thread overview]
Message-ID: <e84bdd5b-6615-33c0-bfff-208d6165a183@amd.com> (raw)
In-Reply-To: <20230316093738.28866-1-tzimmermann@suse.de>

Am 16.03.23 um 10:37 schrieb Thomas Zimmermann:
> Convert radeon's fbdev code to drm_client. Replaces the current
> ad-hoc integration. The conversion includes a number of cleanups.
> Only build fbdev support if the config option has been set.

I'm torn apart on that. On the one hand it looks like a really nice 
cleanup on the other hand we don't really want to touch radeon any more.

Alex what do you think? Is that worth the risk of breaking stuff?

Christian.

>
> Thomas Zimmermann (10):
>    drm/radeon: Move radeon_align_pitch() next to dumb-buffer helpers
>    drm/radeon: Improve fbdev object-test helper
>    drm/radeon: Remove struct radeon_fbdev
>    drm/radeon: Remove test for !screen_base in fbdev probing
>    drm/radeon: Move fbdev object helpers before struct fb_ops et al
>    drm/radeon: Fix coding style in fbdev emulation
>    drm/radeon: Move fbdev cleanup code into fb_destroy callback
>    drm/radeon: Correctly clean up failed display probing
>    drm/radeon: Implement client-based fbdev emulation
>    drm/radeon: Only build fbdev if DRM_FBDEV_EMULATION is set
>
>   drivers/gpu/drm/radeon/Makefile         |   3 +-
>   drivers/gpu/drm/radeon/radeon.h         |   2 +
>   drivers/gpu/drm/radeon/radeon_display.c |   4 -
>   drivers/gpu/drm/radeon/radeon_drv.c     |   3 +-
>   drivers/gpu/drm/radeon/radeon_drv.h     |   1 -
>   drivers/gpu/drm/radeon/radeon_fb.c      | 400 ----------------------
>   drivers/gpu/drm/radeon/radeon_fbdev.c   | 422 ++++++++++++++++++++++++
>   drivers/gpu/drm/radeon/radeon_gem.c     |  24 ++
>   drivers/gpu/drm/radeon/radeon_kms.c     |  18 -
>   drivers/gpu/drm/radeon/radeon_mode.h    |  20 +-
>   10 files changed, 464 insertions(+), 433 deletions(-)
>   delete mode 100644 drivers/gpu/drm/radeon/radeon_fb.c
>   create mode 100644 drivers/gpu/drm/radeon/radeon_fbdev.c
>
>
> base-commit: ec0708e846b819c8d5b642de42448a87d7526564


  parent reply	other threads:[~2023-03-17  8:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16  9:37 [PATCH 00/10] drm/radeon: Convert fbdev to DRM client Thomas Zimmermann
2023-03-16  9:37 ` [PATCH 01/10] drm/radeon: Move radeon_align_pitch() next to dumb-buffer helpers Thomas Zimmermann
2023-03-16  9:37 ` [PATCH 02/10] drm/radeon: Improve fbdev object-test helper Thomas Zimmermann
2023-03-16  9:37 ` [PATCH 03/10] drm/radeon: Remove struct radeon_fbdev Thomas Zimmermann
2023-03-16  9:37 ` [PATCH 04/10] drm/radeon: Remove test for !screen_base in fbdev probing Thomas Zimmermann
2023-03-16  9:37 ` [PATCH 05/10] drm/radeon: Move fbdev object helpers before struct fb_ops et al Thomas Zimmermann
2023-03-16  9:37 ` [PATCH 06/10] drm/radeon: Fix coding style in fbdev emulation Thomas Zimmermann
2023-03-16  9:37 ` [PATCH 07/10] drm/radeon: Move fbdev cleanup code into fb_destroy callback Thomas Zimmermann
2023-03-16  9:37 ` [PATCH 08/10] drm/radeon: Correctly clean up failed display probing Thomas Zimmermann
2023-03-16  9:37 ` [PATCH 09/10] drm/radeon: Implement client-based fbdev emulation Thomas Zimmermann
2023-03-16  9:37 ` [PATCH 10/10] drm/radeon: Only build fbdev if DRM_FBDEV_EMULATION is set Thomas Zimmermann
2023-03-17  8:53 ` Christian König [this message]
2023-03-17  9:20   ` [PATCH 00/10] drm/radeon: Convert fbdev to DRM client Thomas Zimmermann
2023-03-20 15:11     ` Christian König
2023-03-20 15:19       ` Thomas Zimmermann
2023-03-20 15:23         ` Alex Deucher
2023-03-21  9:33           ` Thomas Zimmermann
2023-03-24 21:44             ` Alex Deucher
2023-03-27 22:39               ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e84bdd5b-6615-33c0-bfff-208d6165a183@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).