From: Helge Deller <deller@gmx.de>
To: ruanjinjie <ruanjinjie@huawei.com>,
zheyuma97@gmail.com, javierm@redhat.com,
wsa+renesas@sang-engineering.com, tzimmermann@suse.de,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] video: fbdev: tridentfb: Fix missing pci_disable_device() in probe and remove
Date: Sun, 25 Sep 2022 18:21:34 +0200 [thread overview]
Message-ID: <eabf4405-7492-19c4-0827-a240e9c75dca@gmx.de> (raw)
In-Reply-To: <20220922013709.3324521-1-ruanjinjie@huawei.com>
On 9/22/22 03:37, ruanjinjie wrote:
> Replace pci_enable_device() with pcim_enable_device(),
> pci_disable_device() and pci_release_regions() will be
> called in release automatically.
>
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/tridentfb.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c
> index f9c3b1d38fc2..7933e01aacc5 100644
> --- a/drivers/video/fbdev/tridentfb.c
> +++ b/drivers/video/fbdev/tridentfb.c
> @@ -1475,7 +1475,7 @@ static int trident_pci_probe(struct pci_dev *dev,
> if (err)
> return err;
>
> - err = pci_enable_device(dev);
> + err = pcim_enable_device(dev);
> if (err)
> return err;
>
> @@ -1715,12 +1715,10 @@ static int trident_pci_probe(struct pci_dev *dev,
> kfree(info->pixmap.addr);
> if (info->screen_base)
> iounmap(info->screen_base);
> - release_mem_region(tridentfb_fix.smem_start, tridentfb_fix.smem_len);
> disable_mmio(info->par);
> out_unmap1:
> if (default_par->io_virt)
> iounmap(default_par->io_virt);
> - release_mem_region(tridentfb_fix.mmio_start, tridentfb_fix.mmio_len);
> framebuffer_release(info);
> return err;
> }
> @@ -1735,8 +1733,6 @@ static void trident_pci_remove(struct pci_dev *dev)
> i2c_del_adapter(&par->ddc_adapter);
> iounmap(par->io_virt);
> iounmap(info->screen_base);
> - release_mem_region(tridentfb_fix.smem_start, tridentfb_fix.smem_len);
> - release_mem_region(tridentfb_fix.mmio_start, tridentfb_fix.mmio_len);
> kfree(info->pixmap.addr);
> fb_dealloc_cmap(&info->cmap);
> framebuffer_release(info);
next prev parent reply other threads:[~2022-09-25 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 1:37 [PATCH -next] video: fbdev: tridentfb: Fix missing pci_disable_device() in probe and remove ruanjinjie
2022-09-25 16:21 ` Helge Deller [this message]
2022-09-26 1:21 ` Ruan Jinjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eabf4405-7492-19c4-0827-a240e9c75dca@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=tzimmermann@suse.de \
--cc=wsa+renesas@sang-engineering.com \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).