From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46365C4338F for ; Thu, 29 Jul 2021 16:18:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1668960E9B for ; Thu, 29 Jul 2021 16:18:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1668960E9B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 953F16EDE4; Thu, 29 Jul 2021 16:18:05 +0000 (UTC) Received: from so254-9.mailgun.net (so254-9.mailgun.net [198.61.254.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id A308B6EDEA for ; Thu, 29 Jul 2021 16:17:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1627575484; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=e1dPKh3zKj9PpqF9ZxCzzdvomuVG/QrY82xKdOIhZYE=; b=iyBHRJERtpvuomRXoNA81fwDcWUxADECMnNWsoEb7sb1bvpmqRt/pJsdhTn056AlqHCD5fjO swmK63IUyQ6UfpaBw3YZAaiftR0XPVQRrrClD9I/RjWeAjG7Mi/kSFht1gNqVYn25aGenyN6 cMK9h/TQnMDcRMOaZaNP5GBmooA= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 6102d4aae81205dd0ad6ae88 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 29 Jul 2021 16:17:46 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 52857C43217; Thu, 29 Jul 2021 16:17:46 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: khsieh) by smtp.codeaurora.org (Postfix) with ESMTPSA id B5037C433D3; Thu, 29 Jul 2021 16:17:45 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 29 Jul 2021 09:17:45 -0700 From: khsieh@codeaurora.org To: Stephen Boyd Subject: Re: [PATCH v2 5/7] drm/msm/dp: return correct edid checksum after corrupted edid checksum read In-Reply-To: References: <1626191647-13901-1-git-send-email-khsieh@codeaurora.org> <1626191647-13901-6-git-send-email-khsieh@codeaurora.org> Message-ID: X-Sender: khsieh@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, airlied@linux.ie, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, abhinavk@codeaurora.org, bjorn.andersson@linaro.org, dri-devel@lists.freedesktop.org, aravindh@codeaurora.org, sean@poorly.run Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-07-22 12:23, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-07-13 08:54:05) >> diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c >> b/drivers/gpu/drm/msm/dp/dp_panel.c >> index 88196f7..0fdb551 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_panel.c >> +++ b/drivers/gpu/drm/msm/dp/dp_panel.c >> @@ -303,7 +303,12 @@ void dp_panel_handle_sink_request(struct dp_panel >> *dp_panel) >> panel = container_of(dp_panel, struct dp_panel_private, >> dp_panel); >> >> if (panel->link->sink_request & DP_TEST_LINK_EDID_READ) { >> - u8 checksum = >> dp_panel_get_edid_checksum(dp_panel->edid); >> + u8 checksum; >> + >> + if (dp_panel->edid) >> + checksum = >> dp_panel_get_edid_checksum(dp_panel->edid); >> + else >> + checksum = >> dp_panel->connector->real_edid_checksum; > > Is there any reason why we can't use connector->real_edid_checksum all > the time? > real_edid_checksum only calculated by drm when edid checksum vitrification failed after edid read. In the good edid checksum case (edid verification succeed), real_edid_checksum is not calculated by drm. >> >> dp_link_send_edid_checksum(panel->link, checksum); >> dp_link_send_test_response(panel->link);