From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BF9DC433F5 for ; Thu, 7 Apr 2022 09:47:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A11110E068; Thu, 7 Apr 2022 09:47:39 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id EDFA610E068 for ; Thu, 7 Apr 2022 09:47:37 +0000 (UTC) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncOjo-0007h2-DP; Thu, 07 Apr 2022 11:47:36 +0200 Message-ID: Subject: Re: [PATCH v2 4/7] drm: mxsfb: Move mxsfb_get_fb_paddr() away from register IO functions From: Lucas Stach To: Marek Vasut , dri-devel@lists.freedesktop.org Date: Thu, 07 Apr 2022 11:47:34 +0200 In-Reply-To: <2e038048-c3ac-4c33-fb98-ba6bec705d5b@denx.de> References: <20220311170601.50995-1-marex@denx.de> <20220311170601.50995-4-marex@denx.de> <5f7eb7a214ec0f219c4c9ce87e6c8c87bc7f0aeb.camel@pengutronix.de> <2e038048-c3ac-4c33-fb98-ba6bec705d5b@denx.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Fan , Alexander Stein , Laurent Pinchart , Sam Ravnborg , Robby Cai Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am Donnerstag, dem 07.04.2022 um 00:05 +0200 schrieb Marek Vasut: > On 4/6/22 21:45, Lucas Stach wrote: > > Am Freitag, dem 11.03.2022 um 18:05 +0100 schrieb Marek Vasut: > > > Move mxsfb_get_fb_paddr() out of the way, away from register IO functions. > > > This is a clean up. No functional change. > > > > > > Signed-off-by: Marek Vasut > > > Cc: Alexander Stein > > > Cc: Laurent Pinchart > > > Cc: Lucas Stach > > > Cc: Peng Fan > > > Cc: Robby Cai > > > Cc: Sam Ravnborg > > > Cc: Stefan Agner > > > > Hm, I don't see any real benefit, but I also fail to see why it > > shouldn't be done so: > > The entire point of this series is to clean up the mxsfb and isolate > lcdif (the original lcdif) from any of the common code. Actually, just use drm_fb_cma_get_gem_addr() instead? Regards, Lucas