From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: "Thomas Hellström (Intel)" <thomas_os@shipmail.org>, Lang.Yu@amd.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3
Date: Mon, 7 Jun 2021 14:41:49 +0200 [thread overview]
Message-ID: <f067ec3f-ae6c-fb9d-d87b-e31311bf3cf3@gmail.com> (raw)
In-Reply-To: <0fc2844d-b954-2386-17e3-e2c4232fc247@shipmail.org>
Thanks!
Lang can anybody from your team give as an reviewed-by/test-by on the
amdgpu patches? I just want another pair of eyes looking over it.
If nobody else has time I will ask Nirmoy for a quick testing round.
Thanks,
Christian.
Am 07.06.21 um 14:38 schrieb Thomas Hellström (Intel):
> Sure. LGTM,
>
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>
>
> On 6/7/21 2:36 PM, Christian König wrote:
>> Thomas any comments on this?
>>
>> Is the purpose of this now clear enough?
>>
>> Thanks,
>> Christian.
>>
>> Am 01.06.21 um 14:25 schrieb Christian König:
>>> From: Lang Yu <Lang.Yu@amd.com>
>>>
>>> Sometimes drivers need to use bounce buffers to evict BOs. While
>>> those reside
>>> in some domain they are not necessarily suitable for CS.
>>>
>>> Add a flag so that drivers can note that a bounce buffers needs to be
>>> reallocated during validation.
>>>
>>> v2: add detailed comments
>>> v3 (chk): merge commits and rework commit message
>>>
>>> Suggested-by: Christian König <christian.koenig@amd.com>
>>> Signed-off-by: Lang Yu <Lang.Yu@amd.com>
>>> Signed-off-by: Christian König <christian.koenig@amd.com>
>>> ---
>>> drivers/gpu/drm/ttm/ttm_bo.c | 3 +++
>>> include/drm/ttm/ttm_placement.h | 7 +++++--
>>> 2 files changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c
>>> b/drivers/gpu/drm/ttm/ttm_bo.c
>>> index 51a94fd63bd7..6b393502198e 100644
>>> --- a/drivers/gpu/drm/ttm/ttm_bo.c
>>> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
>>> @@ -929,6 +929,9 @@ static bool ttm_bo_places_compat(const struct
>>> ttm_place *places,
>>> {
>>> unsigned i;
>>> + if (mem->placement & TTM_PL_FLAG_TEMPORARY)
>>> + return false;
>>> +
>>> for (i = 0; i < num_placement; i++) {
>>> const struct ttm_place *heap = &places[i];
>>> diff --git a/include/drm/ttm/ttm_placement.h
>>> b/include/drm/ttm/ttm_placement.h
>>> index aa6ba4d0cf78..8995c9e4ec1b 100644
>>> --- a/include/drm/ttm/ttm_placement.h
>>> +++ b/include/drm/ttm/ttm_placement.h
>>> @@ -47,8 +47,11 @@
>>> * top of the memory area, instead of the bottom.
>>> */
>>> -#define TTM_PL_FLAG_CONTIGUOUS (1 << 19)
>>> -#define TTM_PL_FLAG_TOPDOWN (1 << 22)
>>> +#define TTM_PL_FLAG_CONTIGUOUS (1 << 0)
>>> +#define TTM_PL_FLAG_TOPDOWN (1 << 1)
>>> +
>>> +/* For multihop handling */
>>> +#define TTM_PL_FLAG_TEMPORARY (1 << 2)
>>> /**
>>> * struct ttm_place
next prev parent reply other threads:[~2021-06-07 12:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 12:25 [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3 Christian König
2021-06-01 12:25 ` [PATCH 2/4] drm/amdgpu: user temporary GTT as bounce buffer Christian König
2021-06-01 12:25 ` [PATCH 3/4] drm/amdgpu: always allow evicting to SYSTEM domain Christian König
2021-06-02 1:30 ` Yu, Lang
2021-06-01 12:25 ` [PATCH 4/4] drm/amdgpu: switch gtt_mgr to counting used pages Christian König
2021-06-07 12:36 ` [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3 Christian König
2021-06-07 12:38 ` Thomas Hellström (Intel)
2021-06-07 12:41 ` Christian König [this message]
2021-06-07 12:58 ` Yu, Lang
2021-06-07 13:01 ` Christian König
2021-06-07 14:42 ` Das, Nirmoy
2021-06-07 15:27 ` Das, Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f067ec3f-ae6c-fb9d-d87b-e31311bf3cf3@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Lang.Yu@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=thomas_os@shipmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).