From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA07EC2BB85 for ; Wed, 15 Apr 2020 07:18:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66A96206F9 for ; Wed, 15 Apr 2020 07:18:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="tJCGtH3f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66A96206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4BD416E853; Wed, 15 Apr 2020 07:17:55 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130074.outbound.protection.outlook.com [40.107.13.74]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0CEF36E25A for ; Tue, 14 Apr 2020 17:49:45 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iyOGX9WxAd+GnyCLUeCYSog1HseE8s6vpjfqj3bdUJzKw4NH20gmeU/Rx75Jj1a0TruwZq75kG20VICDO+tvHKCX/J7cgO42cD1X2N2RhW4EFXewDdzphyJ2Um9Ln8oHG/77InMDZcI67od91tDLnp7ikrZOpm1VbF7p6YT/FveggUhgJBPW+mXmZCvEE1RV9vFbVRIL1sTKfClZbQTnUkItKa5phCS/5x0OGvHJBJW8NgZzLNzEcoDY3LWmk/mx++kUl0JF7Obrc7xumvKh0DZWH49cluXCxh9prSK5RDeWZftgSRWDf6+lSr3iUrOcZDKD3Pjfu2eHXoxv8Lxo5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wpxs3kU8/3fQJR7Txh0E1aVd1Pzhw8m1oYOxfQFrT/Y=; b=Rb0Jf0A8Xt2vn3Rr0mXqMvq3Mm5tZRlOWS0NOqqgHDP2MIIT2CloEvcqsOGLRTLTpG4ppM0imuhudETfEL1bB2vlNlsLFfUX+LZSlPO1exk299YWF6DOWRsky5vmH9DTTZBYm7McrclfxqCHrGFFoqrg2d2pVI0pWHEKtIAmoJ4q44cDH6/UWWW9ekkAQvJh1qno4m6njcQiBYeFCV2+HEOUNYU9Gje5Ev8kW0PdZWW4cgrI9qkZom9+BbvMqIqTMu4au4w1MsiwcWUVrRVLi24Ne6TdpmMeJU6XrpsD/151qd1dVAoIZcWOGNXdgyOZZMqZA2V0JY29nTIYwlOamw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wpxs3kU8/3fQJR7Txh0E1aVd1Pzhw8m1oYOxfQFrT/Y=; b=tJCGtH3faicDp6+ueuJPlsxNwmWG4oF26ioRso1QmvA7Pr7d84FU8pGbiV0M2iND5qWb/dgVKppTfvOBPFN/TIjugbE94NtF7D1WLiIAS4w5Dr4GvmPrsk/KT7Wmz+29oOMjMkxacGJ3zEdHP5ApqTnH8ZFwWG0tyulK+NoZnhM= Received: from VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23) by VI1PR05MB5215.eurprd05.prod.outlook.com (2603:10a6:803:a7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.26; Tue, 14 Apr 2020 17:49:42 +0000 Received: from VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::9d19:a564:b84e:7c19]) by VI1PR05MB5102.eurprd05.prod.outlook.com ([fe80::9d19:a564:b84e:7c19%7]) with mapi id 15.20.2900.028; Tue, 14 Apr 2020 17:49:42 +0000 From: Saeed Mahameed To: "jgg@ziepe.ca" , "arnd@arndb.de" Subject: Re: [RFC 0/6] Regressions for "imply" behavior change Thread-Topic: [RFC 0/6] Regressions for "imply" behavior change Thread-Index: AQHWDeQiJzc7TgrcN0yUMWAEU5j98qhvr4mAgAADKgCAAB92AIAAp0gAgAEtnwCAAPPSAIAAHv4AgAXrpwCAABBmgIAAD4MAgAAAr4CAACg8gA== Date: Tue, 14 Apr 2020 17:49:41 +0000 Message-ID: References: <20200408202711.1198966-1-arnd@arndb.de> <20200408224224.GD11886@ziepe.ca> <87k12pgifv.fsf@intel.com> <7d9410a4b7d0ef975f7cbd8f0b6762df114df539.camel@mellanox.com> <20200410171320.GN11886@ziepe.ca> <16441479b793077cdef9658f35773739038c39dc.camel@mellanox.com> <20200414132900.GD5100@ziepe.ca> <20200414152312.GF5100@ziepe.ca> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.34.4 (3.34.4-1.fc31) authentication-results: spf=none (sender IP is ) smtp.mailfrom=saeedm@mellanox.com; x-originating-ip: [73.15.39.150] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ac769aa8-eb06-45b6-7ff4-08d7e09c35f3 x-ms-traffictypediagnostic: VI1PR05MB5215: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0373D94D15 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB5102.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(346002)(39860400002)(376002)(396003)(136003)(366004)(186003)(71200400001)(110136005)(5660300002)(7416002)(36756003)(8676002)(6506007)(8936002)(4326008)(6486002)(6512007)(81156014)(86362001)(54906003)(316002)(91956017)(66556008)(2616005)(64756008)(478600001)(76116006)(26005)(66446008)(2906002)(66476007)(53546011)(66946007); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rm0zeaUTSgMejJQtSAwBz9bMu/mx2ECZFRTaXwd7jczXadIbDlze6tFI/xdXfrLMGOU+E2OjNRODqv4AE4oLdJPEAzKDSDpVe+pwaj4UzAS/oGlE+YRuTkMczt/RgHqM//KDwmKrfvTENztwxgnB1ogO0DXrRNmIhR8T9G8e108OG9jspYBsmqx26lHMbf162L9iJ57wDKHEM2k+P5kxCjal/FdhVffAHGgx5ZuB871ShY54VoApR7Z863JOp105F8ffkgmEFoaqmux2mlegYjYOnQ6yukU3fgOwpBcgHelfaq25p6xbfZa99wDVAAgvflv+/sRgjL73Gx3evC+yHGtKjiN8FkjtdQB9M+B8McYJvLw+/F430WyF2KEkAQTI78siDZ3aAbwcQZ8V9LgELYBCotB3a1CJOIybpPDq+U9pThnhFH34R/iuiELAkzWU x-ms-exchange-antispam-messagedata: 1NkgKHyHsKz1raQ+CJFWat9KZLvaunRuFz0VzeVRjmy9P5lMDvq5bg32Cbuk3ZV3Lg0LQMOJYBzhTwD2Kq3vH0FdeDp506pXFlhpN2ZP8/7mp7Ml0neEOquN3vtuGtQ4aBhztmVYYS8eVBqmpp7htg== x-ms-exchange-transport-forked: True Content-ID: <732BDB5CD5614D4C86B0C0233E6BE302@eurprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac769aa8-eb06-45b6-7ff4-08d7e09c35f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2020 17:49:42.0115 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NkCNURkiqLIWiek5JheVgT9BsK/z5kmnYSQK4VIif/CghHtXxXIkY9lxJgBSB5D3azWVOjo2ZNNscu+eC6maOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5215 X-Mailman-Approved-At: Wed, 15 Apr 2020 07:17:53 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "airlied@linux.ie" , "jernej.skrabec@siol.net" , "leon@kernel.org" , "narmstrong@baylibre.com" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , "masahiroy@kernel.org" , "nico@fluxnic.net" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-renesas-soc@vger.kernel.org" , "a.hajda@samsung.com" , "jonas@kwiboo.se" , "kieran.bingham+renesas@ideasonboard.com" , "Laurent.pinchart@ideasonboard.com" , "davem@davemloft.net" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 2020-04-14 at 17:25 +0200, Arnd Bergmann wrote: > On Tue, Apr 14, 2020 at 5:23 PM Jason Gunthorpe wrote: > > On Tue, Apr 14, 2020 at 04:27:41PM +0200, Arnd Bergmann wrote: > > > On Tue, Apr 14, 2020 at 3:29 PM Jason Gunthorpe > > > wrote: > > > > On Fri, Apr 10, 2020 at 07:04:27PM +0000, Saeed Mahameed wrote: > > > which in turn leads to mlx5_core.ko *not* containing > > > mlx5_vxlan.o, > > > and in turn causing that link error against > > > mlx5_vxlan_create/mlx5_vxlan_destroy, unless the IS_ENABLED() > > > is changed to IS_REACHABLE(). > > > > What about the reverse if mlx5_core is 'm' and VLXAN is 'y'? > > > > mlx5_core-m := mlx5_core.o > > mlx5_core-y += mlx5_vxlan.o > > > > Magically works out? > > Yes, Kbuild takes care of that case. > > > > > IIRC that isn't what the expression does, if vxlan is 'n' then > > > > n || !n == true > > > > > > It forces MLX5_CORE to 'm' or 'n' but not 'y' if VXLAN=m, > > > but allows any option if VXLAN=y > > > > And any option if VXLAN=n ? > > Correct. > Great ! Then bottom line we will change mlx5/Kconfig: to depends on VXLAN || !VXLAN This will force MLX5_CORE to m when necessary to make vxlan reachable to mlx5_core. So no need for explicit use of IS_REACHABLE(). in mlx5 there are 4 of these: imply PTP_1588_CLOCK imply VXLAN imply MLXFW imply PCI_HYPERV_INTERFACE I will make a patch. Thanks, Saeed. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel